From 146aeb1f5ae965c3fe2f765714d25c9ae5bb71f1 Mon Sep 17 00:00:00 2001
From: Matiss Janis Aboltins <matiss@mja.lv>
Date: Sat, 20 Dec 2025 21:38:05 +0000
Subject: [PATCH] lint: fix most eslint/no-empty-function violations (#6457)

* lint: fix most eslint/no-empty-function violations

* Remove unnecessary closing brace in .oxlintrc.json
---
 .oxlintrc.json                                | 21 +++++++++++++-
 .../src/browser-preload.browser.js            | 28 ++++++++++++++-----
 .../components/accounts/Reconcile.test.tsx    |  4 +--
 .../components/budget/envelope/IncomeMenu.tsx |  4 +--
 .../src/components/payees/PayeeTableRow.tsx   |  3 --
 .../src/components/reports/Header.tsx         | 16 +++++++----
 .../components/reports/reports/Crossover.tsx  |  4 ---
 .../components/reports/reports/Summary.tsx    |  4 ---
 .../src/components/settings/AuthSettings.tsx  |  8 ++----
 .../transactions/TransactionsTable.test.tsx   |  2 +-
 packages/desktop-client/src/index.tsx         |  2 ++
 .../desktop-client/src/modals/modalsSlice.ts  |  4 +--
 .../desktop-client/src/queries/liveQuery.ts   |  6 ++--
 .../src/queries/pagedQuery.test.ts            |  4 +--
 .../desktop-client/src/queries/pagedQuery.ts  |  6 ++--
 packages/desktop-electron/preload.ts          |  5 +++-
 .../platform/client/fetch/index.browser.ts    | 12 ++++++--
 .../src/platform/client/fetch/index.ts        |  8 ++++--
 .../platform/exceptions/__mocks__/index.ts    |  8 ++++--
 .../src/platform/exceptions/index.ts          |  4 ++-
 .../server/asyncStorage/__mocks__/index.ts    |  4 ++-
 .../src/platform/server/asyncStorage/index.ts |  4 ++-
 .../server/connection/__mocks__/index.ts      |  4 ++-
 .../platform/server/connection/index.api.ts   |  4 ++-
 .../server/connection/index.electron.ts       |  4 ++-
 .../src/platform/server/connection/index.ts   |  4 ++-
 .../platform/server/sqlite/index.electron.ts  |  4 ++-
 packages/loot-core/src/server/api.ts          |  4 ++-
 .../loot-core/src/server/budgetfiles/app.ts   |  4 ++-
 .../loot-core/src/server/cloud-storage.ts     |  4 ++-
 .../loot-core/src/server/importers/actual.ts  |  4 ++-
 .../src/server/spreadsheet/spreadsheet.ts     |  5 ++--
 .../src/server/sync/sync.property.test.ts     |  2 +-
 .../transactions/import/parse-file.test.ts    |  2 +-
 packages/loot-core/src/shared/async.test.ts   |  4 ++-
 packages/loot-core/typings/window.ts          |  7 -----
 .../sync-server/src/app-cors-proxy.test.js    |  6 ++--
 upcoming-release-notes/6457.md                |  6 ++++
 38 files changed, 148 insertions(+), 81 deletions(-)
 create mode 100644 upcoming-release-notes/6457.md

diff --git a/.oxlintrc.json b/.oxlintrc.json
index b01da26c03..489261e876 100644
--- a/.oxlintrc.json
+++ b/.oxlintrc.json
@@ -161,7 +161,7 @@
     "eslint/no-dupe-keys": "warn",
     "eslint/no-duplicate-case": "warn",
     "eslint/no-empty-character-class": "warn",
-    // "eslint/no-empty-function": "warn", // TODO: enable this
+    "eslint/no-empty-function": "warn",
     "eslint/no-empty-pattern": "warn",
     "eslint/no-eval": "warn",
     "eslint/no-ex-assign": "warn",
@@ -393,6 +393,25 @@
       "rules": {
         "import/no-default-export": "off"
       }
+    },
+    // TODO: enable these
+    {
+      "files": [
+        "packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx",
+        "packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx",
+        "packages/desktop-client/src/components/budget/BudgetCategories.tsx",
+        "packages/desktop-client/src/components/budget/envelope/BalanceMovementMenu.tsx",
+        "packages/desktop-client/src/components/ManageRules.tsx",
+        "packages/desktop-client/src/components/mobile/budget/ExpenseGroupList.tsx",
+        "packages/desktop-client/src/components/modals/EditFieldModal.tsx",
+        "packages/desktop-client/src/components/reports/reports/Calendar.tsx",
+        "packages/desktop-client/src/components/schedules/ScheduleLink.tsx",
+        "packages/desktop-client/src/components/ServerContext.tsx",
+        "packages/desktop-client/src/components/table.tsx"
+      ],
+      "rules": {
+        "eslint/no-empty-function": "off"
+      }
     }
   ]
 }
diff --git a/packages/desktop-client/src/browser-preload.browser.js b/packages/desktop-client/src/browser-preload.browser.js
index 09219fe69f..81258756bf 100644
--- a/packages/desktop-client/src/browser-preload.browser.js
+++ b/packages/desktop-client/src/browser-preload.browser.js
@@ -86,9 +86,13 @@ global.Actual = {
       });
   },
 
-  startSyncServer: () => {},
+  startSyncServer: () => {
+    // Only for electron app
+  },
 
-  stopSyncServer: () => {},
+  stopSyncServer: () => {
+    // Only for electron app
+  },
 
   isSyncServerRunning: () => false,
 
@@ -96,7 +100,9 @@ global.Actual = {
     return '';
   },
 
-  restartElectronServer: () => {},
+  restartElectronServer: () => {
+    // Only for electron app
+  },
 
   openFileDialog: async ({ filters = [] }) => {
     const FILE_ACCEPT_OVERRIDES = {
@@ -192,17 +198,23 @@ global.Actual = {
   openInFileManager: () => {
     // File manager not available in browser
   },
-  onEventFromMain: () => {},
+  onEventFromMain: () => {
+    // Only for electron app
+  },
   isUpdateReadyForDownload: () => isUpdateReadyForDownload,
   waitForUpdateReadyForDownload: () => isUpdateReadyForDownloadPromise,
   applyAppUpdate: async () => {
     updateSW();
 
     // Wait for the app to reload
-    await new Promise(() => {});
+    await new Promise(() => {
+      // Do nothing
+    });
   },
 
-  ipcConnect: () => {},
+  ipcConnect: () => {
+    // Only for electron app
+  },
   getServerSocket: async () => {
     return worker;
   },
@@ -211,5 +223,7 @@ global.Actual = {
     window.__actionsForMenu.saveGlobalPrefs({ prefs: { theme } });
   },
 
-  moveBudgetDirectory: () => {},
+  moveBudgetDirectory: () => {
+    // Only for electron app
+  },
 };
diff --git a/packages/desktop-client/src/components/accounts/Reconcile.test.tsx b/packages/desktop-client/src/components/accounts/Reconcile.test.tsx
index e2ae95b5a0..49c67ca55c 100644
--- a/packages/desktop-client/src/components/accounts/Reconcile.test.tsx
+++ b/packages/desktop-client/src/components/accounts/Reconcile.test.tsx
@@ -71,7 +71,7 @@ describe('ReconcilingMessage math & UI', () => {
         <ReconcilingMessage
           balanceQuery={makeBalanceQuery()}
           targetBalance={10000}
-          onDone={() => {}}
+          onDone={vi.fn()}
           onCreateTransaction={onCreateTransaction}
         />
       </TestProvider>,
@@ -99,7 +99,7 @@ describe('ReconcilingMessage math & UI', () => {
         <ReconcilingMessage
           balanceQuery={makeBalanceQuery()}
           targetBalance={10000}
-          onDone={() => {}}
+          onDone={vi.fn()}
           onCreateTransaction={onCreateTransaction}
         />
       </TestProvider>,
diff --git a/packages/desktop-client/src/components/budget/envelope/IncomeMenu.tsx b/packages/desktop-client/src/components/budget/envelope/IncomeMenu.tsx
index 1a553f8e0c..3c75388d70 100644
--- a/packages/desktop-client/src/components/budget/envelope/IncomeMenu.tsx
+++ b/packages/desktop-client/src/components/budget/envelope/IncomeMenu.tsx
@@ -13,7 +13,7 @@ type IncomeMenuProps = {
   month: string;
   onBudgetAction: (month: string, action: string, arg?: unknown) => void;
   onShowActivity: (id: CategoryEntity['id'], month: string) => void;
-  onClose?: () => void;
+  onClose: () => void;
 };
 
 export function IncomeMenu({
@@ -21,7 +21,7 @@ export function IncomeMenu({
   month,
   onBudgetAction,
   onShowActivity,
-  onClose = () => {},
+  onClose,
 }: IncomeMenuProps) {
   const { t } = useTranslation();
   const carryover = useEnvelopeSheetValue(
diff --git a/packages/desktop-client/src/components/payees/PayeeTableRow.tsx b/packages/desktop-client/src/components/payees/PayeeTableRow.tsx
index 177bd17053..838e0b41d8 100644
--- a/packages/desktop-client/src/components/payees/PayeeTableRow.tsx
+++ b/packages/desktop-client/src/components/payees/PayeeTableRow.tsx
@@ -234,9 +234,6 @@ export const PayeeTableRow = memo(
         <CustomCell
           width={20}
           exposed={!payee.transfer_acct}
-          onBlur={() => {}}
-          onUpdate={() => {}}
-          onClick={() => {}}
           style={{
             display: 'flex',
             justifyContent: 'center',
diff --git a/packages/desktop-client/src/components/reports/Header.tsx b/packages/desktop-client/src/components/reports/Header.tsx
index c8b4d8d98d..e6e1b353b6 100644
--- a/packages/desktop-client/src/components/reports/Header.tsx
+++ b/packages/desktop-client/src/components/reports/Header.tsx
@@ -41,22 +41,26 @@ type HeaderProps = {
     end: TimeFrame['end'],
     mode: TimeFrame['mode'],
   ) => void;
-  conditionsOp: 'and' | 'or';
-  onUpdateFilter: ComponentProps<typeof AppliedFilters>['onUpdate'];
-  onDeleteFilter: ComponentProps<typeof AppliedFilters>['onDelete'];
-  onConditionsOpChange: ComponentProps<
-    typeof AppliedFilters
-  >['onConditionsOpChange'];
   children?: ReactNode;
   inlineContent?: ReactNode;
 } & (
   | {
       filters: RuleConditionEntity[];
       onApply: (conditions: RuleConditionEntity) => void;
+      onUpdateFilter: ComponentProps<typeof AppliedFilters>['onUpdate'];
+      onDeleteFilter: ComponentProps<typeof AppliedFilters>['onDelete'];
+      conditionsOp: 'and' | 'or';
+      onConditionsOpChange: ComponentProps<
+        typeof AppliedFilters
+      >['onConditionsOpChange'];
     }
   | {
       filters?: never;
       onApply?: never;
+      onUpdateFilter?: never;
+      onDeleteFilter?: never;
+      conditionsOp?: never;
+      onConditionsOpChange?: never;
     }
 );
 
diff --git a/packages/desktop-client/src/components/reports/reports/Crossover.tsx b/packages/desktop-client/src/components/reports/reports/Crossover.tsx
index a66b8ee547..34f761b8a3 100644
--- a/packages/desktop-client/src/components/reports/reports/Crossover.tsx
+++ b/packages/desktop-client/src/components/reports/reports/Crossover.tsx
@@ -433,10 +433,6 @@ function CrossoverInner({ widget }: CrossoverInnerProps) {
         earliestTransaction={earliestTransaction}
         latestTransaction={latestTransaction}
         onChangeDates={onChangeDates}
-        conditionsOp="and"
-        onUpdateFilter={() => {}}
-        onDeleteFilter={() => {}}
-        onConditionsOpChange={() => {}}
       >
         {widget && (
           <Button variant="primary" onPress={onSaveWidget}>
diff --git a/packages/desktop-client/src/components/reports/reports/Summary.tsx b/packages/desktop-client/src/components/reports/reports/Summary.tsx
index 5d6d093445..5856e3d21f 100644
--- a/packages/desktop-client/src/components/reports/reports/Summary.tsx
+++ b/packages/desktop-client/src/components/reports/reports/Summary.tsx
@@ -346,10 +346,6 @@ function SummaryInner({ widget }: SummaryInnerProps) {
         firstDayOfWeekIdx={firstDayOfWeekIdx}
         mode={mode}
         onChangeDates={onChangeDates}
-        onUpdateFilter={dividendFilters.onUpdate}
-        onDeleteFilter={dividendFilters.onDelete}
-        conditionsOp={dividendFilters.conditionsOp}
-        onConditionsOpChange={dividendFilters.onConditionsOpChange}
         show1Month={true}
       >
         {widget && (
diff --git a/packages/desktop-client/src/components/settings/AuthSettings.tsx b/packages/desktop-client/src/components/settings/AuthSettings.tsx
index ed3a813118..8185d13ae9 100644
--- a/packages/desktop-client/src/components/settings/AuthSettings.tsx
+++ b/packages/desktop-client/src/components/settings/AuthSettings.tsx
@@ -45,9 +45,7 @@ export function AuthSettings() {
                     pushModal({
                       modal: {
                         name: 'enable-openid',
-                        options: {
-                          onSave: async () => {},
-                        },
+                        options: {},
                       },
                     }),
                   )
@@ -73,9 +71,7 @@ export function AuthSettings() {
                     pushModal({
                       modal: {
                         name: 'enable-password-auth',
-                        options: {
-                          onSave: async () => {},
-                        },
+                        options: {},
                       },
                     }),
                   )
diff --git a/packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx b/packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx
index e6f3154e88..06fa58616f 100644
--- a/packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx
+++ b/packages/desktop-client/src/components/transactions/TransactionsTable.test.tsx
@@ -208,7 +208,7 @@ function LiveTransactionTable(props: LiveTransactionTableProps) {
                 <TransactionTable
                   {...props}
                   transactions={transactions}
-                  loadMoreTransactions={() => {}}
+                  loadMoreTransactions={vi.fn()}
                   // @ts-ignore TODO:
                   commonPayees={[]}
                   payees={payees}
diff --git a/packages/desktop-client/src/index.tsx b/packages/desktop-client/src/index.tsx
index 3b63955fcc..1a3ee96200 100644
--- a/packages/desktop-client/src/index.tsx
+++ b/packages/desktop-client/src/index.tsx
@@ -8,6 +8,7 @@ import './i18n';
 import React from 'react';
 import { createRoot } from 'react-dom/client';
 import { Provider } from 'react-redux';
+import { type NavigateFunction } from 'react-router';
 
 import { bindActionCreators } from '@reduxjs/toolkit';
 
@@ -98,6 +99,7 @@ root.render(
 declare global {
   // oxlint-disable-next-line typescript/consistent-type-definitions
   interface Window {
+    __navigate?: NavigateFunction;
     __actionsForMenu: typeof boundActions & {
       undo: typeof undo;
       redo: typeof redo;
diff --git a/packages/desktop-client/src/modals/modalsSlice.ts b/packages/desktop-client/src/modals/modalsSlice.ts
index 24bef911cf..aad8c7adb7 100644
--- a/packages/desktop-client/src/modals/modalsSlice.ts
+++ b/packages/desktop-client/src/modals/modalsSlice.ts
@@ -534,13 +534,13 @@ export type Modal =
   | {
       name: 'enable-openid';
       options: {
-        onSave: () => void;
+        onSave?: () => void;
       };
     }
   | {
       name: 'enable-password-auth';
       options: {
-        onSave: () => void;
+        onSave?: () => void;
       };
     }
   | {
diff --git a/packages/desktop-client/src/queries/liveQuery.ts b/packages/desktop-client/src/queries/liveQuery.ts
index 6e5a26407c..960e9ee162 100644
--- a/packages/desktop-client/src/queries/liveQuery.ts
+++ b/packages/desktop-client/src/queries/liveQuery.ts
@@ -38,7 +38,7 @@ export class LiveQuery<TResponse = unknown> {
   private _listeners: Array<Listener<TResponse>>;
   private _supportedSyncTypes: Set<'applied' | 'success'>;
   private _query: Query;
-  private _onError: (error: Error) => void;
+  private _onError?: (error: Error) => void;
 
   get query() {
     return this._query;
@@ -77,7 +77,7 @@ export class LiveQuery<TResponse = unknown> {
     this._data = null;
     this._dependencies = null;
     this._listeners = [];
-    this._onError = onError || (() => {});
+    this._onError = onError;
 
     // TODO: error types?
     this._supportedSyncTypes = options.onlySync
@@ -104,7 +104,7 @@ export class LiveQuery<TResponse = unknown> {
   };
 
   protected onError = (error: Error) => {
-    this._onError(error);
+    this._onError?.(error);
   };
 
   protected onUpdate = (tables: string[]) => {
diff --git a/packages/desktop-client/src/queries/pagedQuery.test.ts b/packages/desktop-client/src/queries/pagedQuery.test.ts
index b14f3acf14..7a7d7a966f 100644
--- a/packages/desktop-client/src/queries/pagedQuery.test.ts
+++ b/packages/desktop-client/src/queries/pagedQuery.test.ts
@@ -467,7 +467,7 @@ describe('pagedQuery', () => {
 
     await tracer.expect('server-query', [{ result: { $count: '*' } }]);
     await tracer.expect('server-query', ['id']);
-    await tracer.expect('data', () => {});
+    await tracer.expect('data', vi.fn());
 
     paged.fetchNext();
     paged.fetchNext();
@@ -475,7 +475,7 @@ describe('pagedQuery', () => {
     paged.fetchNext();
 
     await tracer.expect('server-query', ['id']);
-    await tracer.expect('data', () => {});
+    await tracer.expect('data', vi.fn());
 
     // Wait a bit and make sure nothing comes through
     const p = Promise.race([tracer.expect('server-query'), wait(200)]);
diff --git a/packages/desktop-client/src/queries/pagedQuery.ts b/packages/desktop-client/src/queries/pagedQuery.ts
index 24a8180074..0411e16cb5 100644
--- a/packages/desktop-client/src/queries/pagedQuery.ts
+++ b/packages/desktop-client/src/queries/pagedQuery.ts
@@ -42,7 +42,7 @@ type PagedQueryOptions = LiveQueryOptions & {
 // Paging
 export class PagedQuery<TResponse = unknown> extends LiveQuery<TResponse> {
   private _hasReachedEnd: boolean;
-  private _onPageData: (data: Data<TResponse>) => void;
+  private _onPageData?: (data: Data<TResponse>) => void;
   private _pageCount: number;
   private _fetchDataPromise: Promise<void> | null;
   private _totalCount: number;
@@ -67,7 +67,7 @@ export class PagedQuery<TResponse = unknown> extends LiveQuery<TResponse> {
     this._pageCount = options.pageCount || 500;
     this._fetchDataPromise = null;
     this._hasReachedEnd = false;
-    this._onPageData = onPageData || (() => {});
+    this._onPageData = onPageData;
   }
 
   private fetchCount = () => {
@@ -171,7 +171,7 @@ export class PagedQuery<TResponse = unknown> extends LiveQuery<TResponse> {
   };
 
   private onPageData = (data: Data<TResponse>) => {
-    this._onPageData(data);
+    this._onPageData?.(data);
   };
 
   // The public version of this function is created below and
diff --git a/packages/desktop-electron/preload.ts b/packages/desktop-electron/preload.ts
index b6f4b66f84..87ed004275 100644
--- a/packages/desktop-electron/preload.ts
+++ b/packages/desktop-electron/preload.ts
@@ -75,7 +75,10 @@ contextBridge.exposeInMainWorld('Actual', {
 
   // No auto-updates in the desktop app
   isUpdateReadyForDownload: () => false,
-  waitForUpdateReadyForDownload: () => new Promise<void>(() => {}),
+  waitForUpdateReadyForDownload: () =>
+    new Promise<void>(() => {
+      // This is used in browser environment; do nothing in electron
+    }),
 
   getServerSocket: async () => {
     return null;
diff --git a/packages/loot-core/src/platform/client/fetch/index.browser.ts b/packages/loot-core/src/platform/client/fetch/index.browser.ts
index 14243fd017..71bbd19816 100644
--- a/packages/loot-core/src/platform/client/fetch/index.browser.ts
+++ b/packages/loot-core/src/platform/client/fetch/index.browser.ts
@@ -199,6 +199,12 @@ export const unlisten: T.Unlisten = function (name) {
   listeners.set(name, []);
 };
 
-export const initServer: T.InitServer = async function () {};
-export const serverPush: T.ServerPush = async function () {};
-export const clearServer: T.ClearServer = async function () {};
+export const initServer: T.InitServer = async function () {
+  // initServer is used in tests to mock the server
+};
+export const serverPush: T.ServerPush = async function () {
+  // serverPush is used in tests to mock the server
+};
+export const clearServer: T.ClearServer = async function () {
+  // clearServer is used in tests to mock the server
+};
diff --git a/packages/loot-core/src/platform/client/fetch/index.ts b/packages/loot-core/src/platform/client/fetch/index.ts
index 1a2bd5b59a..a13c22b1d6 100644
--- a/packages/loot-core/src/platform/client/fetch/index.ts
+++ b/packages/loot-core/src/platform/client/fetch/index.ts
@@ -145,5 +145,9 @@ export const clearServer: T.ClearServer = async function () {
     return new Promise(closeSocket);
   }
 };
-export const initServer: T.InitServer = async function () {};
-export const serverPush: T.ServerPush = async function () {};
+export const initServer: T.InitServer = async function () {
+  // initServer is used in tests to mock the server
+};
+export const serverPush: T.ServerPush = async function () {
+  // serverPush is used in tests to mock the server
+};
diff --git a/packages/loot-core/src/platform/exceptions/__mocks__/index.ts b/packages/loot-core/src/platform/exceptions/__mocks__/index.ts
index 9c48ca4c04..b312fad48e 100644
--- a/packages/loot-core/src/platform/exceptions/__mocks__/index.ts
+++ b/packages/loot-core/src/platform/exceptions/__mocks__/index.ts
@@ -1,3 +1,7 @@
-export const captureException = function () {};
+export const captureException = function () {
+  // Do not capture exceptions in tests
+};
 
-export const captureBreadcrumb = function () {};
+export const captureBreadcrumb = function () {
+  // Do not capture breadcrumbs in tests
+};
diff --git a/packages/loot-core/src/platform/exceptions/index.ts b/packages/loot-core/src/platform/exceptions/index.ts
index cc96d9d0e9..43e0ba3de1 100644
--- a/packages/loot-core/src/platform/exceptions/index.ts
+++ b/packages/loot-core/src/platform/exceptions/index.ts
@@ -2,4 +2,6 @@ export const captureException = function (exc: Error) {
   console.error('[Exception]', exc);
 };
 
-export const captureBreadcrumb = function (_crumb: unknown) {};
+export const captureBreadcrumb = function (crumb: unknown) {
+  console.info('[Breadcrumb]', crumb);
+};
diff --git a/packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts b/packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts
index 5faf8d9f38..3e8bd15578 100644
--- a/packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts
+++ b/packages/loot-core/src/platform/server/asyncStorage/__mocks__/index.ts
@@ -4,7 +4,9 @@ import type * as T from '../index-types';
 
 const store: GlobalPrefsJson = {};
 
-export const init: T.Init = function () {};
+export const init: T.Init = function () {
+  // No need to initialise in tests
+};
 
 export const getItem: T.GetItem = async function (key) {
   return store[key];
diff --git a/packages/loot-core/src/platform/server/asyncStorage/index.ts b/packages/loot-core/src/platform/server/asyncStorage/index.ts
index 50e8afdd51..da81e8f86a 100644
--- a/packages/loot-core/src/platform/server/asyncStorage/index.ts
+++ b/packages/loot-core/src/platform/server/asyncStorage/index.ts
@@ -4,7 +4,9 @@ import { getDatabase } from '../indexeddb';
 
 import type * as T from './index-types';
 
-export const init: T.Init = function () {};
+export const init: T.Init = function () {
+  // No need to initialise in the browser
+};
 
 export const getItem: T.GetItem = async function (key) {
   const db = await getDatabase();
diff --git a/packages/loot-core/src/platform/server/connection/__mocks__/index.ts b/packages/loot-core/src/platform/server/connection/__mocks__/index.ts
index c1fed480b8..d1d9f1f0ae 100644
--- a/packages/loot-core/src/platform/server/connection/__mocks__/index.ts
+++ b/packages/loot-core/src/platform/server/connection/__mocks__/index.ts
@@ -2,7 +2,9 @@ import type * as T from '../index-types';
 
 let events = [];
 
-export const init: T.Init = function () {};
+export const init: T.Init = function () {
+  // No need to initialise in tests
+};
 
 export const send: T.Send = function (type, args) {
   events.push([type, args]);
diff --git a/packages/loot-core/src/platform/server/connection/index.api.ts b/packages/loot-core/src/platform/server/connection/index.api.ts
index d21679d810..b204f37d08 100644
--- a/packages/loot-core/src/platform/server/connection/index.api.ts
+++ b/packages/loot-core/src/platform/server/connection/index.api.ts
@@ -1,6 +1,8 @@
 import type * as T from './index-types';
 
-export const init: T.Init = function () {};
+export const init: T.Init = function () {
+  // Nothing
+};
 
 export const send: T.Send = function () {
   // Nothing
diff --git a/packages/loot-core/src/platform/server/connection/index.electron.ts b/packages/loot-core/src/platform/server/connection/index.electron.ts
index 6ad1094c37..cf899296e2 100644
--- a/packages/loot-core/src/platform/server/connection/index.electron.ts
+++ b/packages/loot-core/src/platform/server/connection/index.electron.ts
@@ -85,4 +85,6 @@ export const send: T.Send = function (name, args) {
   process.parentPort.postMessage({ type: 'push', name, args });
 };
 
-export const resetEvents: T.ResetEvents = function () {};
+export const resetEvents: T.ResetEvents = function () {
+  // resetEvents is used in tests to mock the server
+};
diff --git a/packages/loot-core/src/platform/server/connection/index.ts b/packages/loot-core/src/platform/server/connection/index.ts
index 98b67cf256..91b8937de4 100644
--- a/packages/loot-core/src/platform/server/connection/index.ts
+++ b/packages/loot-core/src/platform/server/connection/index.ts
@@ -136,4 +136,6 @@ export const getNumClients = function () {
   return 1;
 };
 
-export const resetEvents: T.ResetEvents = function () {};
+export const resetEvents: T.ResetEvents = function () {
+  // resetEvents is used in tests to mock the server
+};
diff --git a/packages/loot-core/src/platform/server/sqlite/index.electron.ts b/packages/loot-core/src/platform/server/sqlite/index.electron.ts
index 959f28b27d..24fee4eb29 100644
--- a/packages/loot-core/src/platform/server/sqlite/index.electron.ts
+++ b/packages/loot-core/src/platform/server/sqlite/index.electron.ts
@@ -16,7 +16,9 @@ function verifyParamTypes(sql, arr) {
   });
 }
 
-export async function init() {}
+export async function init() {
+  // No need to initialise on electron
+}
 
 export function prepare(db, sql) {
   return db.prepare(sql);
diff --git a/packages/loot-core/src/server/api.ts b/packages/loot-core/src/server/api.ts
index 5b1860ec8a..e9b5eef767 100644
--- a/packages/loot-core/src/server/api.ts
+++ b/packages/loot-core/src/server/api.ts
@@ -329,7 +329,9 @@ handlers['api/finish-import'] = async function () {
   await handlers['get-budget-bounds']();
   await sheet.waitOnSpreadsheet();
 
-  await cloudStorage.upload().catch(() => {});
+  await cloudStorage.upload().catch(() => {
+    // Ignore errors
+  });
 
   connection.send('finish-import');
   IMPORT_MODE = false;
diff --git a/packages/loot-core/src/server/budgetfiles/app.ts b/packages/loot-core/src/server/budgetfiles/app.ts
index 96c4945604..b87f22ff36 100644
--- a/packages/loot-core/src/server/budgetfiles/app.ts
+++ b/packages/loot-core/src/server/budgetfiles/app.ts
@@ -290,7 +290,9 @@ async function deleteBudget({
   // If it's a cloud file, you can delete it from the server by
   // passing its cloud id
   if (cloudFileId) {
-    await cloudStorage.removeFile(cloudFileId).catch(() => {});
+    await cloudStorage.removeFile(cloudFileId).catch(() => {
+      // Ignore errors
+    });
   }
 
   // If a local file exists, you can delete it by passing its local id
diff --git a/packages/loot-core/src/server/cloud-storage.ts b/packages/loot-core/src/server/cloud-storage.ts
index 1b838a0ec2..8bf0cf59e8 100644
--- a/packages/loot-core/src/server/cloud-storage.ts
+++ b/packages/loot-core/src/server/cloud-storage.ts
@@ -357,7 +357,9 @@ export async function possiblyUpload() {
   }
 
   // Don't block on uploading
-  upload().catch(() => {});
+  upload().catch(() => {
+    // Ignore errors
+  });
 }
 
 export async function removeFile(fileId) {
diff --git a/packages/loot-core/src/server/importers/actual.ts b/packages/loot-core/src/server/importers/actual.ts
index 675b8a1161..28554be528 100644
--- a/packages/loot-core/src/server/importers/actual.ts
+++ b/packages/loot-core/src/server/importers/actual.ts
@@ -43,5 +43,7 @@ export async function importActual(_filepath: string, buffer: Buffer) {
   await handlers['load-budget']({ id });
   await handlers['get-budget-bounds']();
   await waitOnSpreadsheet();
-  await cloudStorage.upload().catch(() => {});
+  await cloudStorage.upload().catch(() => {
+    // Ignore errors
+  });
 }
diff --git a/packages/loot-core/src/server/spreadsheet/spreadsheet.ts b/packages/loot-core/src/server/spreadsheet/spreadsheet.ts
index 9920d22885..40ae747ba5 100644
--- a/packages/loot-core/src/server/spreadsheet/spreadsheet.ts
+++ b/packages/loot-core/src/server/spreadsheet/spreadsheet.ts
@@ -268,8 +268,9 @@ export class Spreadsheet {
 
     if (!this.running && this.computeQueue.length === 0) {
       func([]);
-      // The remove function does nothing
-      return () => {};
+      return () => {
+        // The remove function does nothing
+      };
     }
 
     const remove = this.addEventListener('change', (...args) => {
diff --git a/packages/loot-core/src/server/sync/sync.property.test.ts b/packages/loot-core/src/server/sync/sync.property.test.ts
index a883a4abc5..ba558537b4 100644
--- a/packages/loot-core/src/server/sync/sync.property.test.ts
+++ b/packages/loot-core/src/server/sync/sync.property.test.ts
@@ -235,7 +235,7 @@ async function run(msgs) {
   });
 
   await global.emptyDatabase()();
-  await sheet.loadSpreadsheet(db, () => {});
+  await sheet.loadSpreadsheet(db, vi.fn());
 
   // The test: split up the messages into chunks and in parallel send
   // them all through `sendMessages`. Then add some messages to the
diff --git a/packages/loot-core/src/server/transactions/import/parse-file.test.ts b/packages/loot-core/src/server/transactions/import/parse-file.test.ts
index d2a0b3163d..f976981bbf 100644
--- a/packages/loot-core/src/server/transactions/import/parse-file.test.ts
+++ b/packages/loot-core/src/server/transactions/import/parse-file.test.ts
@@ -15,7 +15,7 @@ beforeEach(global.emptyDatabase());
 // it hard to test.
 const old = console.warn;
 beforeAll(() => {
-  console.warn = () => {};
+  console.warn = vi.fn();
 });
 afterAll(() => {
   console.warn = old;
diff --git a/packages/loot-core/src/shared/async.test.ts b/packages/loot-core/src/shared/async.test.ts
index 4aa9f9000e..41043b6df5 100644
--- a/packages/loot-core/src/shared/async.test.ts
+++ b/packages/loot-core/src/shared/async.test.ts
@@ -60,7 +60,9 @@ describe('async', () => {
   test('sequential fn should still flush queue when error is thrown', async () => {
     const test = async fn => {
       fn(1);
-      fn(2, { throwError: true }).catch(() => {});
+      fn(2, { throwError: true }).catch(() => {
+        // Ignore errors
+      });
       await fn(3);
     };
 
diff --git a/packages/loot-core/typings/window.ts b/packages/loot-core/typings/window.ts
index 1d8d3e1409..e5f21ed059 100644
--- a/packages/loot-core/typings/window.ts
+++ b/packages/loot-core/typings/window.ts
@@ -1,6 +1,4 @@
 // @ts-strict-ignore
-import { type NavigateFunction } from 'react-router';
-
 export {};
 
 type FileDialogOptions = {
@@ -47,11 +45,6 @@ type Actual = {
 };
 
 declare global {
-  // oxlint-disable-next-line typescript/consistent-type-definitions
-  interface Window {
-    __navigate?: NavigateFunction;
-  }
-
   var Actual: Actual;
 
   var IS_TESTING: boolean;
diff --git a/packages/sync-server/src/app-cors-proxy.test.js b/packages/sync-server/src/app-cors-proxy.test.js
index 58ad75e6b2..dae9cc123a 100644
--- a/packages/sync-server/src/app-cors-proxy.test.js
+++ b/packages/sync-server/src/app-cors-proxy.test.js
@@ -173,9 +173,9 @@ describe('app-cors-proxy', () => {
 
     clearAllowlistCache();
 
-    vi.spyOn(console, 'log').mockImplementation(() => {});
-    vi.spyOn(console, 'warn').mockImplementation(() => {});
-    vi.spyOn(console, 'error').mockImplementation(() => {});
+    vi.spyOn(console, 'log').mockImplementation(vi.fn());
+    vi.spyOn(console, 'warn').mockImplementation(vi.fn());
+    vi.spyOn(console, 'error').mockImplementation(vi.fn());
   });
 
   describe('CORS preflight', () => {
diff --git a/upcoming-release-notes/6457.md b/upcoming-release-notes/6457.md
new file mode 100644
index 0000000000..a654e15679
--- /dev/null
+++ b/upcoming-release-notes/6457.md
@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+lint: fix most eslint/no-empty-function violations