[PR #179] [MERGED] For bias, amend dJ/dw to dJ/db #232

New Issue

GiteaMirror · 2025-11-02T00:10:47-05:00

GiteaMirror commented

2025-11-02 00:10:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/GokuMohandas/Made-With-ML/pull/179
Author: @andrewng88
Created: 7/3/2020
Status: ✅ Merged
Merged: 7/3/2020
Merged by: @GokuMohandas

Base: master ← Head: master

📝 Commits (1)

420f5ed For bias, amend dJ/dw to dJ/db

📊 Changes

2 files changed (+5906 additions, -2 deletions)

View changed files

📝 notebooks/07_Linear_Regression/07_PT_Linear_Regression.ipynb (+2577 -1)
📝 notebooks/07_Linear_Regression/07_TF_Linear_Regression.ipynb (+3329 -1)

📄 Description

Hi Goku, as discussed at Slack please see the revision. I helped to amend both PyTorch and TF notebooks. BTW, it's my first PR :)
Cheers.

Goku Mohandas 1 hour ago
Hey @Andrew N., you just caught a big bug! It’s supposed to say dJ/db for the second one. Common practice on papers seems to be to leave out the bias (b) to simplify the math but it’s assumed, so technically y_hat is WX + b. Hope that helps and feel free to submit a PR correcting this on jupyter if you’d like to we can give you proper credit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GokuMohandas/Made-With-ML/pull/179 **Author:** [@andrewng88](https://github.com/andrewng88) **Created:** 7/3/2020 **Status:** ✅ Merged **Merged:** 7/3/2020 **Merged by:** [@GokuMohandas](https://github.com/GokuMohandas) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`420f5ed`](https://github.com/GokuMohandas/Made-With-ML/commit/420f5ed73217b17a4f23c67d747d3b7e945ef19a) For bias, amend dJ/dw to dJ/db ### 📊 Changes **2 files changed** (+5906 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `notebooks/07_Linear_Regression/07_PT_Linear_Regression.ipynb` (+2577 -1) 📝 `notebooks/07_Linear_Regression/07_TF_Linear_Regression.ipynb` (+3329 -1) </details> ### 📄 Description Hi Goku, as discussed at Slack please see the revision. I helped to amend both PyTorch and TF notebooks. BTW, it's my first PR :) Cheers. >> Goku Mohandas 1 hour ago Hey @Andrew N., you just caught a big bug! It’s supposed to say dJ/db for the second one. Common practice on papers seems to be to leave out the bias (b) to simplify the math but it’s assumed, so technically y_hat is WX + b. Hope that helps and feel free to submit a PR correcting this on jupyter if you’d like to we can give you proper credit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 00:10:47 -05:00

GiteaMirror closed this issue

2025-11-02 00:10:47 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/Made-With-ML#232