[PR #173] [MERGED] APIs PT lesson fixes - use_glove => use-glove, utilities #227

New Issue

GiteaMirror · 2025-11-02T00:10:32-05:00

GiteaMirror commented

2025-11-02 00:10:32 -05:00

📋 Pull Request Information

Original PR: https://github.com/GokuMohandas/Made-With-ML/pull/173
Author: @itsderek23
Created: 3/30/2020
Status: ✅ Merged
Merged: 3/30/2020
Merged by: @GokuMohandas

Base: master ← Head: utils_use_glove

📝 Commits (1)

483c50b APIs lesson fixes - use_glove => use-glove, utilities

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 notebooks/03_APIs/pt-text-classification/README.md (+1 -1)
📝 notebooks/03_APIs/pt-text-classification/text_classification/utils.py (+1 -1)

📄 Description

Noticed two things when following the API README instructions:

python text_classification/utils.py

This fails with:

Traceback (most recent call last):
  File "text_classification/utils.py", line 90, in <module>
    utilities.create_dirs(embeddings_dir)
NameError: name 'utilities' is not defined

Looks like create_dirs() is defined in the same utils.py file.

The training step says:

python text_classification/train.py
--data-url https://raw.githubusercontent.com/madewithml/lessons/master/data/news.csv --lower --shuffle --use_glove

Which fails:

train.py: error: unrecognized arguments: --use_glove

I think --use_glove should be --use-glove.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GokuMohandas/Made-With-ML/pull/173 **Author:** [@itsderek23](https://github.com/itsderek23) **Created:** 3/30/2020 **Status:** ✅ Merged **Merged:** 3/30/2020 **Merged by:** [@GokuMohandas](https://github.com/GokuMohandas) **Base:** `master` ← **Head:** `utils_use_glove` --- ### 📝 Commits (1) - [`483c50b`](https://github.com/GokuMohandas/Made-With-ML/commit/483c50ba24ea1a4de0dec1f1b224c1092955f1fa) APIs lesson fixes - use_glove => use-glove, utilities ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `notebooks/03_APIs/pt-text-classification/README.md` (+1 -1) 📝 `notebooks/03_APIs/pt-text-classification/text_classification/utils.py` (+1 -1) </details> ### 📄 Description Noticed two things when following the [API README](https://github.com/madewithml/lessons/blob/master/notebooks/03_APIs/pt-text-classification/README.md) instructions: > python text_classification/utils.py This fails with: ``` Traceback (most recent call last): File "text_classification/utils.py", line 90, in <module> utilities.create_dirs(embeddings_dir) NameError: name 'utilities' is not defined ``` Looks like `create_dirs()` is defined in the same `utils.py` file. The training step says: > python text_classification/train.py \ --data-url https://raw.githubusercontent.com/madewithml/lessons/master/data/news.csv --lower --shuffle --use_glove Which fails: ``` train.py: error: unrecognized arguments: --use_glove ``` I think `--use_glove` should be `--use-glove`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 00:10:32 -05:00

GiteaMirror closed this issue

2025-11-02 00:10:33 -05:00

GiteaMirror referenced this issue

2025-11-02 00:11:42 -05:00

[PR #227] [CLOSED] Updated 03_NumPy #251

Sign in to join this conversation.