[PR #154] [CLOSED] Dog subclass specifies species for user #213

New Issue

GiteaMirror · 2025-11-02T00:09:50-05:00

GiteaMirror commented

2025-11-02 00:09:50 -05:00

📋 Pull Request Information

Original PR: https://github.com/GokuMohandas/Made-With-ML/pull/154
Author: @KennBot
Created: 10/29/2019
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

1471978 Dog subclass specifies species for user

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 notebooks/01_Python.ipynb (+4 -4)

📄 Description

Since we know the species is "dog" for the Dog subclass of Pet, instead of having the user specify species='dog' in params, we will just have the Dog class fill that in for the user, simplifying the interface. I also moved the 'breed' parameter in front of 'name', to fit a logical heirarchy - species -> breed -> name.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/GokuMohandas/Made-With-ML/pull/154 **Author:** [@KennBot](https://github.com/KennBot) **Created:** 10/29/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`1471978`](https://github.com/GokuMohandas/Made-With-ML/commit/1471978b217c93e2c470560a2ff23f1984351f52) Dog subclass specifies species for user ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `notebooks/01_Python.ipynb` (+4 -4) </details> ### 📄 Description Since we know the species is "dog" for the Dog subclass of Pet, instead of having the user specify species='dog' in params, we will just have the Dog class fill that in for the user, simplifying the interface. I also moved the 'breed' parameter in front of 'name', to fit a logical heirarchy - species -> breed -> name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-02 00:09:50 -05:00

GiteaMirror closed this issue

2025-11-02 00:09:50 -05:00

GiteaMirror referenced this issue

2025-11-02 00:11:31 -05:00

[PR #213] [CLOSED] 02_Python.ipynb #247

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/Made-With-ML#213