From 4556cfb057d46e65b3af68cebc88a78047a42b7a Mon Sep 17 00:00:00 2001 From: kolaente Date: Mon, 4 Nov 2024 12:26:45 +0100 Subject: [PATCH] fix(attachments): return error message when attachment upload is not multipart form request Resolves https://vikunja.sentry.io/issues/6041469388/ --- pkg/routes/api/v1/task_attachment.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/routes/api/v1/task_attachment.go b/pkg/routes/api/v1/task_attachment.go index 3ffefed78..dd72afe5a 100644 --- a/pkg/routes/api/v1/task_attachment.go +++ b/pkg/routes/api/v1/task_attachment.go @@ -17,6 +17,7 @@ package v1 import ( + "errors" "net/http" "strings" @@ -72,6 +73,9 @@ func UploadTaskAttachment(c echo.Context) error { form, err := c.MultipartForm() if err != nil { _ = s.Rollback() + if errors.Is(err, http.ErrNotMultipart) { + return echo.NewHTTPError(http.StatusBadRequest, "No multipart form provided") + } return handler.HandleHTTPError(err) }