shields/.vscode/launch.json at 2.2.0 - shields - Computersurge

ComputerSurge/shields

Files

T

Marcin MielnickiandPaul Melnikow 283601423f Redirect an old png badge with a number as a color; test on [static] (#3412 )

Fixes https://github.com/badges/shields/issues/3260

Problem happens when a value of a color in an old PNG static badge is a number: http://localhost:8080/my-label/my-message.png?color=1. In this case `color` in `queryParams` is a number. 
https://github.com/badges/shields/blob/0a0b5b3f031178851c9d295b9967d81ede052723/core/server/server.js#L203-L212

Surprisingly service test listed below is passing currently on master - value `1` is represented in `queryParams` as a String (only in test). 
`services/static-badge/static-badge.tester.js`
```js
t.create('Old static badge with a number as a color')
  .get('/foo/bar.png?color=1', { followRedirect: false })
  .expectStatus(301)
  .expectHeader('Location', '/badge/foo-bar-1.png')
```

Moreover I added some code + description allowing to debug server.

2019-05-08 12:33:43 -04:00

14 lines

242 B

JSON

Raw Permalink Blame History

 {
   "version": "0.2.0",
   "configurations": [
     {
       "type": "node",
       "request": "attach",
       "name": "Node: Nodemon",
       "processId": "${command:PickProcess}",
       "restart": true,
       "protocol": "inspector"
     }
   ]
 }