Paul Melnikowandrepo-ranger[bot]
b7a29f20ef
* Refactor existing metrics support into MetricHelper This completes the refactor done at https://github.com/badges/shields/pull/3662#issuecomment-509011229 in anticipation of adding more metrics support, such as response size of an upstream service, or response time. * Clean up * Renames * Add response time metrics This adds around 30 new metrics to cover response times at a fairly granular level. We may be able to shrink the number of buckets with time, though I think using 30 metrics is probably okay given that I think may become our most important metric. * Fix
71 lines
1.9 KiB
JavaScript
71 lines
1.9 KiB
JavaScript
'use strict'
|
|
|
|
const makeBadge = require('../../gh-badges/lib/make-badge')
|
|
const BaseService = require('./base')
|
|
const {
|
|
serverHasBeenUpSinceResourceCached,
|
|
setCacheHeadersForStaticResource,
|
|
} = require('./cache-headers')
|
|
const { makeSend } = require('./legacy-result-sender')
|
|
const { MetricHelper } = require('./metric-helper')
|
|
const coalesceBadge = require('./coalesce-badge')
|
|
const { prepareRoute, namedParamsForMatch } = require('./route')
|
|
|
|
module.exports = class BaseStaticService extends BaseService {
|
|
static register({ camp, metricInstance }, serviceConfig) {
|
|
const {
|
|
profiling: { makeBadge: shouldProfileMakeBadge },
|
|
} = serviceConfig
|
|
const { regex, captureNames } = prepareRoute(this.route)
|
|
|
|
const metricHelper = MetricHelper.create({
|
|
metricInstance,
|
|
ServiceClass: this,
|
|
})
|
|
|
|
camp.route(regex, async (queryParams, match, end, ask) => {
|
|
if (serverHasBeenUpSinceResourceCached(ask.req)) {
|
|
// Send Not Modified.
|
|
ask.res.statusCode = 304
|
|
ask.res.end()
|
|
return
|
|
}
|
|
|
|
const metricHandle = metricHelper.startRequest()
|
|
|
|
const namedParams = namedParamsForMatch(captureNames, match, this)
|
|
const serviceData = await this.invoke(
|
|
{},
|
|
serviceConfig,
|
|
namedParams,
|
|
queryParams
|
|
)
|
|
|
|
const badgeData = coalesceBadge(
|
|
queryParams,
|
|
serviceData,
|
|
this.defaultBadgeData,
|
|
this
|
|
)
|
|
|
|
// The final capture group is the extension.
|
|
const format = (match.slice(-1)[0] || '.svg').replace(/^\./, '')
|
|
badgeData.format = format
|
|
|
|
if (shouldProfileMakeBadge) {
|
|
console.time('makeBadge total')
|
|
}
|
|
const svg = makeBadge(badgeData)
|
|
if (shouldProfileMakeBadge) {
|
|
console.timeEnd('makeBadge total')
|
|
}
|
|
|
|
setCacheHeadersForStaticResource(ask.res)
|
|
|
|
makeSend(format, ask.res, end)(svg)
|
|
|
|
metricHandle.noteResponseSent()
|
|
})
|
|
}
|
|
}
|