Paul MelnikowandGitHub
5828223356
- Prefer inline transforms to take place in `handle()` rather than `render()` - Avoid inversion of control by removing `BaseWordpress#handle()`, passing `extensionType` into `fetch()`, and removing one layer of subclassing - Move “not found” checks into `fetch()` - Cache wordpress versions instead of fetching on each request - Start to convert aliases to redirects (there are more of these which could be tackled in a follow-on) - Replace at least one route `format` with a `pattern` (ref #3329) - Partially reorder: name, category, route, examples, defaultBadgeData, render, fetch, handle Some of this is in line with our established patterns or makes it clearly easier to follow; some of it is arguably stylistic.
67 lines
1.4 KiB
JavaScript
67 lines
1.4 KiB
JavaScript
'use strict'
|
|
|
|
const { addv } = require('../text-formatters')
|
|
const { version: versionColor } = require('../color-formatters')
|
|
const BaseWordpress = require('./wordpress-base')
|
|
|
|
function VersionForExtensionType(extensionType) {
|
|
const { capt, exampleSlug } = {
|
|
plugin: {
|
|
capt: 'Plugin',
|
|
exampleSlug: 'bbpress',
|
|
},
|
|
theme: {
|
|
capt: 'Theme',
|
|
exampleSlug: 'twentyseventeen',
|
|
},
|
|
}[extensionType]
|
|
|
|
return class WordpressVersion extends BaseWordpress {
|
|
static get name() {
|
|
return `Wordpress${capt}Version`
|
|
}
|
|
|
|
static get category() {
|
|
return 'version'
|
|
}
|
|
|
|
static get route() {
|
|
return {
|
|
base: `wordpress/${extensionType}/v`,
|
|
pattern: ':slug',
|
|
}
|
|
}
|
|
|
|
static get examples() {
|
|
return [
|
|
{
|
|
title: `Wordpress ${capt} Version`,
|
|
namedParams: { slug: exampleSlug },
|
|
staticPreview: this.render({ version: 2.5 }),
|
|
},
|
|
]
|
|
}
|
|
|
|
static get defaultBadgeData() {
|
|
return { label: extensionType }
|
|
}
|
|
|
|
static render({ version }) {
|
|
return {
|
|
message: addv(version),
|
|
color: versionColor(version),
|
|
}
|
|
}
|
|
|
|
async handle({ slug }) {
|
|
const { version } = await this.fetch({
|
|
extensionType,
|
|
slug,
|
|
})
|
|
return this.constructor.render({ version })
|
|
}
|
|
}
|
|
}
|
|
|
|
module.exports = ['theme', 'plugin'].map(VersionForExtensionType)
|