5828223356
- Prefer inline transforms to take place in `handle()` rather than `render()` - Avoid inversion of control by removing `BaseWordpress#handle()`, passing `extensionType` into `fetch()`, and removing one layer of subclassing - Move “not found” checks into `fetch()` - Cache wordpress versions instead of fetching on each request - Start to convert aliases to redirects (there are more of these which could be tackled in a follow-on) - Replace at least one route `format` with a `pattern` (ref #3329) - Partially reorder: name, category, route, examples, defaultBadgeData, render, fetch, handle Some of this is in line with our established patterns or makes it clearly easier to follow; some of it is arguably stylistic.
54 lines
1.3 KiB
JavaScript
54 lines
1.3 KiB
JavaScript
'use strict'
|
|
|
|
const Joi = require('joi')
|
|
const { BaseJsonService, NotFound } = require('..')
|
|
const { nonNegativeInteger } = require('../validators')
|
|
|
|
const foundSchema = Joi.object()
|
|
.keys({
|
|
version: Joi.string(),
|
|
rating: nonNegativeInteger,
|
|
num_ratings: nonNegativeInteger,
|
|
downloaded: nonNegativeInteger,
|
|
active_installs: nonNegativeInteger,
|
|
requires: Joi.string(), // Plugin Only
|
|
tested: Joi.string(), // Plugin Only
|
|
})
|
|
.required()
|
|
|
|
const notFoundSchema = Joi.string().allow(null, false)
|
|
|
|
const schemas = Joi.alternatives(foundSchema, notFoundSchema)
|
|
|
|
module.exports = class BaseWordpress extends BaseJsonService {
|
|
async fetch({ extensionType, slug }) {
|
|
const url = `https://api.wordpress.org/${extensionType}s/info/1.1/`
|
|
const json = await this._requestJson({
|
|
url,
|
|
schema: schemas,
|
|
options: {
|
|
qs: {
|
|
action: `${extensionType}_information`,
|
|
request: {
|
|
slug,
|
|
fields: {
|
|
active_installs: 1,
|
|
sections: 0,
|
|
homepage: 0,
|
|
tags: 0,
|
|
screenshot_url: 0,
|
|
},
|
|
},
|
|
},
|
|
qsStringifyOptions: {
|
|
encode: false,
|
|
},
|
|
},
|
|
})
|
|
if (!json) {
|
|
throw new NotFound()
|
|
}
|
|
return json
|
|
}
|
|
}
|