ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity
Files
47e8cc3de33f61df490ce986f71109cd8165e049
shields/services
History
Paul Melnikow 47e8cc3de3 Refactor route functions in BaseService (#2860) 
The route helper functions are fairly well isolated from the rest of BaseService, with a few convenient entry points. They are easier to test in isolation.

The way the code was written before, `pathToRegexp` was invoked once for every request, which seems inefficient.

`route` was validated when it was used, though it seems more helpful to validate it up front.

This breaks out `_makeFullUrl`, `_regex`, `_regexFromPath` into new helper functions `makeFullUrl`, `assertValidRoute`, `prepareRoute`, and `namedParamsForMatch`.

It adds validation to route, and updates the services without patterns to include one, in order to pass the new validation rules.
2019-01-26 02:38:12 -05:00
..
amo
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
ansible
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
apm
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
appveyor
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
aur
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
azure-devops
Reorganize BaseService-related modules (#2831)
2019-01-22 23:52:13 -05:00
beerpay
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
bintray
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
bitbucket
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
bithound
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
bitrise
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
bountysource
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
bower
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
bstats
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
bugzilla
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
buildkite
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
bundlephobia
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
cauditor
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
cdnjs
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
chocolatey
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
chrome-web-store
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
cii-best-practices
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
circleci
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
clojars
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
cocoapods
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
codacy
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
codeclimate
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
codecov
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
codeship
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
codetally
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
conda
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
continuousphp
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
cookbook
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
coveralls
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
coverity
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
cpan
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
cran
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
crates
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
ctan
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
date
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
david
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
debug
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
dependabot
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
depfu
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
discord
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
discourse
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
dockbit
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
docker
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
dotnetstatus
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
dub
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
dynamic
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
eclipse-marketplace
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
elm-package
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
endpoint
Delete some of our logos (part 1) (#2857)
2019-01-25 12:51:41 -05:00
f-droid
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
flip
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
gem
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
gemnasium
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
github
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
gitlab
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
gitter
Reorganize BaseService-related modules (#2831)
2019-01-22 23:52:13 -05:00
gratipay
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
hackage
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
hexpm
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
homebrew
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
imagelayers
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
issuestats
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
itunes
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
jenkins
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
jetbrains
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
jira
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
jitpack
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
leanpub
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
lgtm
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
liberapay
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
librariesio
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
libscore
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
luarocks
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
magnumci
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
maintenance
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
matrix
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
maven-central
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
maven-metadata
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
microbadger
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
myget
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
nexus
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
node
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
npm
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
nsp
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
nuget
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
opencollective
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
osslifecycle
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
packagecontrol
Reorganize BaseService-related modules (#2831)
2019-01-22 23:52:13 -05:00
packagist
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
php-eye
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
powershellgallery
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
pub
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
puppetforge
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
pypi
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
readthedocs
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
redmine
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
requires
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
resharper
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
scrutinizer
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
shippable
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
snap-ci
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
snyk
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
sonarqube
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
sourceforge
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
sourcegraph
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
spiget
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
stackexchange
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
static-badge
Reorganize BaseService-related modules (#2831)
2019-01-22 23:52:13 -05:00
steam
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
suggest
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
swagger
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
symfony
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
teamcity
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
travis
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
twitter
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
uptimerobot
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
vaadin-directory
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
versioneye
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
visual-studio-marketplace
Update [VisualStudioMarketplace] download calculation for Azure DevOps Extensions (#2748)
2019-01-23 18:14:26 -06:00
waffle
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
website
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
wercker
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
wheelmap
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
wordpress
Create shortcut for BaseService-related imports (#2809)
2019-01-21 15:41:24 -05:00
categories.js
Split “quality” into “code coverage” and “analysis” (#2723)
2019-01-10 21:18:43 -05:00
check-services.spec.js
Refactor service loader (#2861)
2019-01-24 22:55:10 -05:00
dynamic-common.js
Reorganize BaseService-related modules (#2831)
2019-01-22 23:52:13 -05:00
index.js
Refactor service loader (#2861)
2019-01-24 22:55:10 -05:00
legacy-service.js
Refactor route functions in BaseService (#2860)
2019-01-26 02:38:12 -05:00
nuget-fixtures.js
Rewrite [NuGet] badges including [myget chocolatey resharper powershellgallery] (#2257)
2018-11-14 17:28:15 -05:00
package-json-helpers.js
Reorganize BaseService-related modules (#2831)
2019-01-22 23:52:13 -05:00
response-fixtures.js
Avoid func declarations using function keyword (#2813)
2019-01-21 15:33:43 -05:00
route-builder.js
Rewrite [NuGet] badges including [myget chocolatey resharper powershellgallery] (#2257)
2018-11-14 17:28:15 -05:00
test-validators.js
Made tests use isBuildStatus validator from build-status.js (#2762)
2019-01-14 19:39:06 +00:00
validators.js
Migrates [Nexus] service to new service model (#2520)
2018-12-19 15:45:22 -05:00