shields/lib at 3bb392dfae5a3c9a669cbb8df66ba4da4c8f83d2 - shields - Computersurge

ComputerSurge/shields

Files

History

Paul Melnikow 3bb392dfae Remove some duplicated URL generation code (#2240 )

I went down a rabbit hole while trying to untangle the bug in the dockbit and bitrise examples https://github.com/badges/shields/pull/2234#pullrequestreview-169997546.

The URL generation code is spaghetti-like, with functions, many of which I wrote, with opaque names, doing similar but not identical things, and making slightly incompatible assumptions about the way query strings are handled.

I got a bit lost and need to take a step back.

Meanwhile, this is a small piece of work I did that’s worth keeping. It doesn’t scratch the surface of the tangle, but it does remove a bit of duplication.

It also makes a minor stylistic ES6 change in the handling of default arguments.

Ref: #2027

2018-11-05 16:55:49 -05:00

..

Add list of critical services (#1386 )

2017-12-25 22:21:37 -05:00

service-test-runner

Remove some uses of to-be-deprecated url.format and url.parse APIs (#2265 )

2018-11-05 16:48:04 -05:00

Metrics with Prometheus (#2069 )

2018-11-04 18:54:43 +01:00

all-badge-examples.js

Move more badge examples into services/ (#2247 )

2018-11-01 19:39:28 -04:00

all-badge-examples.spec.js

Fix: keywords missing from prepared examples (#2143 )

2018-10-03 19:08:05 +01:00

analytics.js

Remove some uses of to-be-deprecated url.format and url.parse APIs (#2265 )

2018-11-05 16:48:04 -05:00

badge-cli.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

badge-cli.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

badge-data.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

badge-data.spec.js

[aur packagist php-eye travis vaadin-directory github david jitpack twitter] Enforced lowercase badge labels (#2058 )

2018-09-09 11:41:10 +01:00

color-formatters.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

color-formatters.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

colorscheme.json

Organize local modules in lib

2017-03-26 22:57:55 +02:00

defaults.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

deprecated-services.js

Deprecated libscore (#2105 )

2018-09-22 12:28:54 +01:00

deprecation-helpers.js

Rewrite deprecated services and add tests (#2018 )

2018-08-30 10:03:15 -07:00

deprecation-helpers.spec.js

Rewrite deprecated services and add tests (#2018 )

2018-08-30 10:03:15 -07:00

error-helper.js

Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) (#2037 )

2018-09-03 19:37:37 +01:00

error-helper.spec.js

[GitHub] Error message customisation for all status codes (#1888 )

2018-08-14 18:57:24 +01:00

export-badge-examples-cli.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

export-supported-features-cli.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

fs-token-persistence.js

Optionally persist [Github] tokens in Redis (#1939 )

2018-08-19 10:27:23 -04:00

fs-token-persistence.spec.js

Optionally persist [Github] tokens in Redis (#1939 )

2018-08-19 10:27:23 -04:00

gh-badges.js

Give the NPM package some love (#2200 )

2018-10-30 18:34:04 +00:00

github-auth.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

in-process-server-test-helpers.js

Refactor and test [github] token persistence (#1863 )

2018-08-11 20:13:40 -04:00

licenses.js

use most permissive license color (#2196 )

2018-10-20 15:15:10 +02:00

licenses.spec.js

use most permissive license color (#2196 )

2018-10-20 15:15:10 +02:00

load-logos.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

load-simple-icons.js

Clean up our callback style and enforce no exclusive tests and remove an exclusive test (#1900 )

2018-08-12 20:45:43 -04:00

log.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

log.spec.js

Clean up our callback style and enforce no exclusive tests and remove an exclusive test (#1900 )

2018-08-12 20:45:43 -04:00

logo-helper.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

logo-helper.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

lru-cache.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

lru-cache.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

make-badge-test-helpers.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

make-badge-url.js

Remove some duplicated URL generation code (#2240 )

2018-11-05 16:55:49 -05:00

make-badge-url.spec.js

Remove some duplicated URL generation code (#2240 )

2018-11-05 16:55:49 -05:00

make-badge.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

make-badge.spec.js

Made JSON snapshot test pass on Windows (#2061 )

2018-09-10 19:27:05 +01:00

nodeify-sync.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

nodeify-sync.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

path-helpers.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

php-version.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

php-version.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

redis-token-persistence.integration.js

Optionally persist [Github] tokens in Redis (#1939 )

2018-08-19 10:27:23 -04:00

redis-token-persistence.js

Optionally persist [Github] tokens in Redis (#1939 )

2018-08-19 10:27:23 -04:00

refactoring-cli.js

add refactoring report (#2163 )

2018-10-10 19:22:30 +01:00

register-chai-plugins.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

regular-update.js

Make more consistent use of async/await (#2219 )

2018-10-28 11:34:47 -04:00

request-handler.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

request-handler.spec.js

allow badge maxAge to be set by category; affects [discord] (#2205 )

2018-10-26 20:08:02 +01:00

result-sender.js

Enforce using async-await [f-droid] (#2241 )

2018-11-04 00:33:47 -04:00

server-config.js

Metrics with Prometheus (#2069 )

2018-11-04 18:54:43 +01:00

server-secrets.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

suggest.js

Remove some uses of to-be-deprecated url.format and url.parse APIs (#2265 )

2018-11-05 16:48:04 -05:00

svg-badge-parser.js

Add BaseSvgScrapingService and rewrite [ReadTheDocs]; also affects [codacy vso] (#2229 )

2018-11-01 15:09:00 -04:00

svg-to-img.js

Make more consistent use of async/await (#2219 )

2018-10-28 11:34:47 -04:00

svg-to-img.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

test-config.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

text-formatters.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

text-formatters.spec.js

[AppVeyorTests] compact format and custom labels (#2000 )

2018-09-08 09:27:59 -07:00

text-measurer.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

text-measurer.spec.js

Clean up our callback style and enforce no exclusive tests and remove an exclusive test (#1900 )

2018-08-12 20:45:43 -04:00

token-persistence.js

Optionally persist [Github] tokens in Redis (#1939 )

2018-08-19 10:27:23 -04:00

token-pool.js

Minor tweaks in [github] auth code (#1862 )

2018-08-09 07:22:54 -04:00

token-pool.spec.js

Minor tweaks in [github] auth code (#1862 )

2018-08-09 07:22:54 -04:00

token-provider.js

Minor tweaks in [github] auth code (#1862 )

2018-08-09 07:22:54 -04:00

token-provider.spec.js

Minor tweaks in [github] auth code (#1862 )

2018-08-09 07:22:54 -04:00

unhandled-rejection.spec.js

Run prettier (#1866 )

2018-08-08 17:57:14 -04:00

version.js

Enforce use of template literals (#2242 )

2018-11-02 17:11:44 -04:00

version.spec.js

Rewrite [pypi]; affects [npm] (#1922 )

2018-08-27 07:46:06 -04:00