ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity
2,390 Commits 55 Branches 65 Tags
a614de5fc91da0aba9bd58f0b9097c62f2febb20
Commit Graph
324 Commits
Author SHA1 Message Date
Paul MelnikowandGitHub fa5309400d PaaS, CI, and production-friendly config (#2626) 
This implements the configuration mechanism I described in #2621. The heavy lifting is delegated to [node-config](https://github.com/lorenwest/node-config) with a minor assist from [dotenv](https://github.com/motdotla/dotenv).

`private/secret.json` has been replaced with environment variables and/or `config/local.yml`. See `doc/server-secrets.md`.
 2019-01-06 10:42:09 -05:00
Paul MelnikowandGitHub 2e1ce1a4ca Fix test:services:trace (#2643) 2019-01-06 05:26:56 -05:00
dependabot[bot]andPaul Melnikow 9bc2e512b7 Bump nock from 11.0.0-beta.2 to 11.0.0-beta.3 (#2627) 
Bumps [nock](https://github.com/nock/nock) from 11.0.0-beta.2 to 11.0.0-beta.3.
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/beta/CHANGELOG.md)
- [Commits](https://github.com/nock/nock/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-04 12:06:00 -05:00
dependabot[bot]andPaul Melnikow 67f6e2c490 Bump emojic from 1.1.14 to 1.1.15 (#2628) 
Bumps [emojic](https://github.com/IonicaBizau/emojic) from 1.1.14 to 1.1.15.
- [Release notes](https://github.com/IonicaBizau/emojic/releases)
- [Commits](https://github.com/IonicaBizau/emojic/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-04 11:49:40 -05:00
dependabot[bot]andchris48s 576f30fce5 Bump react from 16.6.3 to 16.7.0 (#2585) 
* Bump react from 16.6.3 to 16.7.0

Bumps [react](https://github.com/facebook/react) from 16.6.3 to 16.7.0.
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/compare/v16.6.3...v16.7.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump react-dom from 16.6.3 to 16.7.0

Bumps [react-dom](https://github.com/facebook/react) from 16.6.3 to 16.7.0.
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/compare/v16.6.3...v16.7.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-03 21:18:08 +00:00
dependabot[bot]andchris48s b93e3ac26f Bump @babel/polyfill from 7.0.0 to 7.2.5 (#2587) 
Bumps [@babel/polyfill](https://github.com/babel/babel) from 7.0.0 to 7.2.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.0.0...v7.2.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-03 20:59:07 +00:00
dependabot[bot]andPaul Melnikow dfe2b1cd0a Bump next from 6.1.2 to 7.0.2 (#2508) 
Bumps [next](https://github.com/zeit/next.js) from 6.1.2 to 7.0.2.
- [Release notes](https://github.com/zeit/next.js/releases)
- [Commits](https://github.com/zeit/next.js/compare/6.1.2...7.0.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-03 09:52:12 -05:00
dependabot[bot]andPaul Melnikow 191f75b634 Bump eslint-plugin-react from 7.12.1 to 7.12.2 (#2624) 
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.12.1 to 7.12.2.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases)
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.12.1...v7.12.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-03 09:06:46 -05:00
dependabot[bot]andPaul Melnikow 1502d1aa5b Bump rimraf from 2.6.2 to 2.6.3 (#2623) 
Bumps [rimraf](https://github.com/isaacs/rimraf) from 2.6.2 to 2.6.3.
- [Release notes](https://github.com/isaacs/rimraf/releases)
- [Commits](https://github.com/isaacs/rimraf/compare/v2.6.2...v2.6.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-03 01:09:14 -05:00
Paul MelnikowandGitHub 7150b37831 Add test of the server entrypoint (#2613) 
The server's entrypoint is an important bit of code which is not covered by our tests. This adds a test which should cover it.
 2019-01-01 22:58:54 -05:00
dependabot[bot]andPaul Melnikow 84183a3fc9 Bump joi from 14.3.0 to 14.3.1 (#2610) 
Bumps [joi](https://github.com/hapijs/joi) from 14.3.0 to 14.3.1.
- [Release notes](https://github.com/hapijs/joi/releases)
- [Changelog](https://github.com/hapijs/joi/blob/master/CHANGELOG.md)
- [Commits](https://github.com/hapijs/joi/compare/v14.3.0...v14.3.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-01 21:54:01 -05:00
dependabot[bot]andPaul Melnikow e09f5ca034 Bump styled-components from 4.1.2 to 4.1.3 (#2556) 
Bumps [styled-components](https://github.com/styled-components/styled-components) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/styled-components/styled-components/releases)
- [Changelog](https://github.com/styled-components/styled-components/blob/master/CHANGELOG.md)
- [Commits](https://github.com/styled-components/styled-components/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-01 21:40:34 -05:00
dependabot[bot]andPaul Melnikow 860c426a0c Bump eslint-plugin-react from 7.11.1 to 7.12.0 (#2609) 
* Bump eslint-plugin-react from 7.11.1 to 7.12.0

Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.11.1 to 7.12.0.
- [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases)
- [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.11.1...v7.12.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Fix lint errors

* Better link

* Re-bump package version and remove lint disable
 2019-01-01 21:22:09 -05:00
dependabot[bot]andMarcin Mielnicki 02151cb700 Bump husky from 1.2.0 to 1.3.1 (#2608) 
Bumps [husky](https://github.com/typicode/husky) from 1.2.0 to 1.3.1.
- [Release notes](https://github.com/typicode/husky/releases)
- [Changelog](https://github.com/typicode/husky/blob/master/CHANGELOG.md)
- [Commits](https://github.com/typicode/husky/compare/v1.2.0...v1.3.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-01-01 15:54:03 +01:00
dependabot[bot]andchris48s 38ede19e84 Bump danger from 6.1.12 to 7.0.1 (#2600) 
Bumps [danger](https://github.com/danger/danger-js) from 6.1.12 to 7.0.1.
- [Release notes](https://github.com/danger/danger-js/releases)
- [Changelog](https://github.com/danger/danger-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/danger/danger-js/compare/6.1.12...7.0.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-30 21:44:02 +00:00
dependabot[bot]andchris48s e024020258 Bump simple-icons from 1.9.16 to 1.9.17 (#2596) 
Bumps [simple-icons](https://github.com/simple-icons/simple-icons) from 1.9.16 to 1.9.17.
- [Release notes](https://github.com/simple-icons/simple-icons/releases)
- [Commits](https://github.com/simple-icons/simple-icons/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-30 21:36:43 +00:00
dependabot[bot]andPaul Melnikow 27da1aa659 Bump eslint from 5.11.0 to 5.11.1 (#2595) 
Bumps [eslint](https://github.com/eslint/eslint) from 5.11.0 to 5.11.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v5.11.0...v5.11.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-28 10:37:37 -05:00
dependabot[bot]andPaul Melnikow 5548027f12 Bump prom-client from 11.2.0 to 11.2.1 (#2583) 
Bumps [prom-client](https://github.com/siimon/prom-client) from 11.2.0 to 11.2.1.
- [Release notes](https://github.com/siimon/prom-client/releases)
- [Changelog](https://github.com/siimon/prom-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/siimon/prom-client/compare/v11.2.0...v11.2.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-26 17:15:56 -05:00
James CahillandPaul Melnikow 74faf163b7 Use cross-env for environment variables (#2589) 
Fix #2580
 2018-12-26 17:01:02 -05:00
dependabot[bot]andchris48s 892a54cfd5 Bump eslint from 5.10.0 to 5.11.0 (#2586) 
Bumps [eslint](https://github.com/eslint/eslint) from 5.10.0 to 5.11.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v5.10.0...v5.11.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-24 19:30:56 +00:00
dependabot[bot]andchris48s c7c82e4fc9 Bump fast-xml-parser from 3.12.10 to 3.12.11 (#2582) 
Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 3.12.10 to 3.12.11.
- [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases)
- [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/NaturalIntelligence/fast-xml-parser/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-24 19:23:54 +00:00
dependabot[bot]andchris48s 35f9d84701 Bump snap-shot-it from 6.2.7 to 6.2.8 (#2584) 
Bumps [snap-shot-it](https://github.com/bahmutov/snap-shot-it) from 6.2.7 to 6.2.8.
- [Release notes](https://github.com/bahmutov/snap-shot-it/releases)
- [Commits](https://github.com/bahmutov/snap-shot-it/compare/v6.2.7...v6.2.8)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-24 19:16:59 +00:00
Paul MelnikowandGitHub ea0d2fb641 Fix frontend coverage in CI, update dev scripts, adopt npm-run-all (#2569) 2018-12-23 22:06:38 -05:00
Paul MelnikowandGitHub 57f826962b Use beta release of nock (#2579) 2018-12-23 21:45:15 -05:00
Paul MelnikowandGitHub 5c665a70da Overhaul initialization pattern for server + server tests (#2519) 
Because `server.js` was long a monolith, there are a bunch of shims in place to facilitate unit testing. A few of the test suites share port 1111 which means if one of them fails to set up, the port won't be freed and other unrelated tests will fail. Some of the tests which trigger server setup include timeouts which were added to give setup code time to run. In one the test suites, we actually modify `process.argv`, which seems completely gross.

This implements a few changes which improve this:

1. Separate the server from the server startup script, splitting out `lib/server.js`.
2. Inject config into the server and validate the config schema.
3. Inject config into the service test runner.
4. Use `portfinder`, a popular utility for grabbing open ports during testing.
5. Switch more of the setup code from callbacks to async-await.

Overall it leaves everything acting more reliably and looking rather cleaner, if in a few places more verbose.

It also fixes the root cause of #1455, a `setTimeout` in `rate-limit`. Off and on during development of this changeset, Mocha would decide not to exit, and that turned out to be the culprit.

Fix #1455
 2018-12-23 11:24:22 -05:00
dependabot[bot]andchris48s ad22dfccc5 Bump @babel/core from 7.1.6 to 7.2.2 (#2543) 
* Bump @babel/core from 7.1.6 to 7.2.2

Bumps [@babel/core](https://github.com/babel/babel) from 7.1.6 to 7.2.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/compare/v7.1.6...v7.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* upgrade the babel plugins
 2018-12-21 20:49:05 +00:00
dependabot[bot]andchris48s 65731f2255 Bump simple-icons from 1.9.15 to 1.9.16 (#2559) 
Bumps [simple-icons](https://github.com/simple-icons/simple-icons) from 1.9.15 to 1.9.16.
- [Release notes](https://github.com/simple-icons/simple-icons/releases)
- [Commits](https://github.com/simple-icons/simple-icons/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-21 19:37:02 +00:00
dependabot[bot]andchris48s a0009aa8b7 Bump react-modal from 3.7.1 to 3.8.1 (#2558) 
Bumps [react-modal](https://github.com/reactjs/react-modal) from 3.7.1 to 3.8.1.
- [Release notes](https://github.com/reactjs/react-modal/releases)
- [Changelog](https://github.com/reactjs/react-modal/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reactjs/react-modal/compare/v3.7.1...v3.8.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-21 19:30:02 +00:00
Paul MelnikowandGitHub ebe4a12acc Convert lodash.uniq to native and remove an unused dev dep (#2564) 2018-12-20 15:15:56 -05:00
Paul MelnikowandGitHub 483aa5a008 Fix frontend coverage and tweak ignores (#2563) 
Since we use Babel for the frontend but not the server, I split the coverage config into two separate files, one for the frontend and the other for the server.

Refs:

- https://github.com/istanbuljs/nyc#nyc
- https://github.com/istanbuljs/babel-plugin-istanbul#mocha-on-nodejs-through-nyc

Close #2552
 2018-12-19 17:46:09 -05:00
dependabot[bot]andPaul Melnikow 63f8b256a7 Bump got from 9.4.0 to 9.5.0 (#2557) 
Bumps [got](https://github.com/sindresorhus/got) from 9.4.0 to 9.5.0.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](https://github.com/sindresorhus/got/compare/v9.4.0...v9.5.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-19 10:56:37 -05:00
Paul MelnikowandGitHub 5c7d07f5be Rework styling using styled-components (#2517) 
The CSS in the project is relatively difficult to change. While it is very DRY, it relies heavily on inheritance. It's difficult to make changes in the markup modal without it also affecting styles elsewhere.
 
[styled-components](https://www.styled-components.com/) is one of the leading CSS-in-JS libraries. By reducing dependency on global state and CSS inheritance, styles become explicit and are easier to inspect and change. It's also convenient that styles can be embedded with the components they modify.

At runtime, the library creates CSS classes, so it's pretty efficient.

We were using a little bit of [styled-jsx](https://github.com/zeit/styled-jsx) before, which ships with Next.js, though styled-components is more widely used and I've had good experiences with it all around.

In a few cases I've duplicated styles where it feels more natural to do that: for example, `text-align: center` is duplicated in `Main` and `MarkupModal`.

Much of this is a refactor, though there are a few visual changes, particularly in the markup modal and the style examples.
 2018-12-18 16:44:47 -05:00
dependabot[bot]andPaul Melnikow b4b29ab0f7 Bump moment from 2.22.2 to 2.23.0 (#2531) 
Bumps [moment](https://github.com/moment/moment) from 2.22.2 to 2.23.0.
- [Release notes](https://github.com/moment/moment/releases)
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/moment/moment/compare/2.22.2...2.23.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-17 12:49:15 -05:00
Paul MelnikowandGitHub 2bf29f97b8 Set up CircleCI test summary [npmcollaborators] (#2526) 
See https://circleci.com/docs/2.0/collect-test-data/

This provides a list of failed tests in the Circle UI and a summary of which tests have failed. It should make interpreting test results easier
 2018-12-16 15:42:28 -05:00
Paul MelnikowandGitHub ec35e8de06 Remove unused wait-promise dep (#2521) 2018-12-13 14:05:10 -05:00
dependabot[bot]andPaul Melnikow 73be33226f Bump sinon from 7.2.0 to 7.2.2 (#2522) 
Bumps [sinon](https://github.com/sinonjs/sinon) from 7.2.0 to 7.2.2.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v7.2.0...v7.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-13 12:37:25 -05:00
dependabot[bot]andPierre-Yves B f6da548dc3 Bump danger from 6.1.11 to 6.1.12 (#2513) 
Bumps [danger](https://github.com/danger/danger-js) from 6.1.11 to 6.1.12.
- [Release notes](https://github.com/danger/danger-js/releases)
- [Changelog](https://github.com/danger/danger-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/danger/danger-js/compare/6.1.11...6.1.12)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-12 19:24:55 +00:00
dependabot[bot]andPaul Melnikow 46064a5f9c Bump react-modal from 3.6.1 to 3.7.1 (#2507) 
Bumps [react-modal](https://github.com/reactjs/react-modal) from 3.6.1 to 3.7.1.
- [Release notes](https://github.com/reactjs/react-modal/releases)
- [Changelog](https://github.com/reactjs/react-modal/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reactjs/react-modal/compare/v3.6.1...v3.7.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-11 16:33:35 -05:00
dependabot[bot]andPaul Melnikow bd930faf24 Bump sinon from 7.1.1 to 7.2.0 (#2506) 
Bumps [sinon](https://github.com/sinonjs/sinon) from 7.1.1 to 7.2.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sinonjs/sinon/compare/v7.1.1...v7.2.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-11 15:58:01 -05:00
dependabot[bot]andPaul Melnikow 965816f363 Bump got from 9.3.2 to 9.4.0 (#2503) 
Bumps [got](https://github.com/sindresorhus/got) from 9.3.2 to 9.4.0.
- [Release notes](https://github.com/sindresorhus/got/releases)
- [Commits](https://github.com/sindresorhus/got/compare/v9.3.2...v9.4.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-11 15:55:43 -05:00
dependabot[bot]andPaul Melnikow 47d56de160 Bump enzyme-adapter-react-16 from 1.7.0 to 1.7.1 (#2504) 
Bumps [enzyme-adapter-react-16](https://github.com/airbnb/enzyme) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/airbnb/enzyme/releases)
- [Changelog](https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbnb/enzyme/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-11 15:52:15 -05:00
dependabot[bot]andPaul Melnikow 40ddc26f9b Bump enzyme from 3.7.0 to 3.8.0 (#2505) 
Bumps [enzyme](https://github.com/airbnb/enzyme) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/airbnb/enzyme/releases)
- [Changelog](https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md)
- [Commits](https://github.com/airbnb/enzyme/compare/enzyme@3.7.0...enzyme@3.8.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-11 10:38:43 -05:00
Paul MelnikowandGitHub a677c5bbef Add some basic frontend tests (#2490) 
The frontend has a few tests in `lib/` but not all of that is covered. The components are not covered at all. It's difficult to make changes to the frontend because you have to manually test that things haven't broken.

This PR uses [Enzyme](https://airbnb.io/enzyme/) to add some [shallow-rendering tests](https://github.com/airbnb/enzyme/blob/master/docs/api/shallow.md), which are essentially unit tests of the components.

This should pave the way for functional tests of the more complex components.
 2018-12-10 17:20:01 -05:00
dependabot[bot]andPierre-Yves B 11e9e75e45 Bump danger from 6.1.9 to 6.1.11 (#2501) 
Bumps [danger](https://github.com/danger/danger-js) from 6.1.9 to 6.1.11.
- [Release notes](https://github.com/danger/danger-js/releases)
- [Changelog](https://github.com/danger/danger-js/blob/master/CHANGELOG.md)
- [Commits](https://github.com/danger/danger-js/compare/6.1.9...6.1.11)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-10 18:55:12 +00:00
Pierre-Yves BandGitHub c89396088d [Wheelmap] service rewrite and tests (#2486) 2018-12-10 18:44:47 +00:00
dependabot[bot]andPaul Melnikow b08a941490 Bump eslint from 5.9.0 to 5.10.0 (#2484) 
Bumps [eslint](https://github.com/eslint/eslint) from 5.9.0 to 5.10.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v5.9.0...v5.10.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-08 17:33:46 -05:00
dependabot[bot]andPierre-Yves B 0e02f8d05e Bump nock from 10.0.3 to 10.0.4 (#2485) 
Bumps [nock](https://github.com/nock/nock) from 10.0.3 to 10.0.4.
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nock/nock/compare/v10.0.3...v10.0.4)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-08 21:55:28 +00:00
dependabot[bot]andPierre-Yves B d0bbd1977f Bump icedfrisby-nock from 1.0.0 to 1.1.0 (#2482) 
Bumps [icedfrisby-nock](https://github.com/paulmelnikow/icedfrisby-nock) from 1.0.0 to 1.1.0.
- [Release notes](https://github.com/paulmelnikow/icedfrisby-nock/releases)
- [Changelog](https://github.com/paulmelnikow/icedfrisby-nock/blob/master/CHANGELOG.md)
- [Commits](https://github.com/paulmelnikow/icedfrisby-nock/compare/1.0.0...1.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-08 21:32:27 +00:00
Paul MelnikowandGitHub 58b276539a Refactor frontend main page and badge-example code (#2441) 
- The goal of this PR is:
    - Consume the new service-definition format. (#2397)
    - Make the frontend more readable.
- Behavior changes:
    - I changed the **Image** field in the markup modal to show only the path.
    - I added another click-to-select field below that shows the complete URL.
    - This made it easier to suppress the live badge preview while it contains placeholders like `:user` or `:gem`, a minor tweak discussed at https://github.com/badges/shields/issues/2427#issuecomment-442972100.
    - The search box now searches all categories, regardless of the current page. (This is an improvement, I would say.)
- I did not deliberately address performance, though I ripped out a bunch of anonymous functions and avoided re-filtering all the examples by category on every render, which I expect will not hurt. I haven't really tested this on a mobile connection and it'd be worth doing that.
- It would be great to have some tests of the components, though getting started with that seemed like a big project and I did not want to make this any larger than it already is.

It's a medium-sized refactor:

1. Replace `BadgeExamples`, `Category` and `Badge` component with a completely rewritten `BadgeExamples` component which renders a table of badges, and `CategoryHeading` and `CategoryHeadings` components.
2. Refactor `ExamplesPage` and `SearchResults` components into a new `Main` component.
3. Rewrite the data flow for `MarkupModal`. Rather than rely on unmounting and remounting the component to copy the badge URL into state, employ the `getDerivedStateFromProps` lifecycle method.
4. Remove `prepareExamples` and `all-badge-examples`.
5. Rewrite the `$suggest` schema to harmonize with the service definition format. It's not backward-compatible which means at deploy time there probably will be 10–20 minutes of downtime on that feature, between the first server deploy and the final gh-pages deploy.  🤷‍♂️ (We could leave the old version in place if it seems worth it.)
6. Added two new functions in `make-badge-url` with tests. I removed _most_ of the uses of the old functions, but there are some in parts of the frontend I didn't touch like the static and dynamic badge generators, and again I didn't want to make this any larger than it already is.
7. Fix a couple bugs in the service-definition export.
 2018-12-08 15:26:13 -05:00
dependabot[bot]andPierre-Yves B d0c9da03c8 Bump simple-icons from 1.9.14 to 1.9.15 (#2464) 
Bumps [simple-icons](https://github.com/simple-icons/simple-icons) from 1.9.14 to 1.9.15.
- [Release notes](https://github.com/simple-icons/simple-icons/releases)
- [Commits](https://github.com/simple-icons/simple-icons/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2018-12-06 22:16:19 +00:00