Commit Graph

30 Commits

Author SHA1 Message Date
Thaddee Tyl
95ef1da7a5 Change BASE_URL to img.shields.io
It seems like a mistake from #870. Indeed, the code in that patch
defaults to shields.io for BASE_URL, but the author mentions they
think it defaults to img.shields.io: https://github.com/badges/shields/pull/870#discussion_r115143960
The correct value to maintain the behavior that was present prior
to the patch in question was indeed img.shields.io.
2017-10-03 00:21:17 +02:00
Thaddee Tyl
39a084d7c6 Log GitHub OAuth authentication failure 2017-10-02 23:50:16 +02:00
Paul Melnikow
f271b82670 Nudge forward style checks a la eslint-config-standard (#1082)
Because I despise nitpicking stuff like indentation and spacing in pull request comments, I'd like to nudge forward our automated style checking, at least for new files being added.

I don't want to totally rewrite server.js just to get automated style checking… the blame tracking is just too useful. So let's it's just take care of that when we start splitting it out.

More discussion in #948.
2017-10-01 21:09:43 -04:00
Adriaan Groenenboom
15f24fbcce Improve Docker run (envsubst, Alpine, documented env file) (#870)
* Add template for secret.json

- Move to faster and lighter Alpine base image

* Update documentation

* Update documentation

* Fix Github token config for secret.json

* Extend env file for Docker runtime configuration

- Update documentation
- Add gh_token for GH personal access token to secret template

* Change http to https in infoSite

* Update .dockerignore

* Update .gitignore

* Update dockerignore

* Remove ENV directive from Dockerfile

- Environment is needed at runtime, not at buildtime

* Docker: contain secret.json in private/

- Incorporates fix from 7c8b0e3d

* Use localhost in example env

* Use baseUrl in GitHub redirect

* Move GH personal token retrieval up

- To remove duplicate Promise.then()

* Typo in shields.example.env
2017-05-07 11:13:02 -07:00
Frode Knutsen
2133ff9d1f fix default value for githubUserTokens 2017-03-27 16:56:58 -04:00
Paul Melnikow
47a8bf51dc First pass for linting on PRs 2017-03-20 16:54:27 -04:00
Thaddee Tyl
076cb14b3b Perform constant equal comparison for shared Shields secret
This should prevent timing attacks.
2017-02-25 18:20:07 +01:00
Thaddee Tyl
7c8b0e3d32 Contain all private files in private/ 2017-02-05 16:24:35 +01:00
Thaddee Tyl
0684c25b94 Remove todo for GitHub auth documentation
It was accidentally done by 56746d4a38.
2016-07-02 12:14:34 +02:00
Thaddee Tyl
71bb291f40 Remove verbose logs for GitHub auth 2016-07-02 10:39:57 +02:00
Thaddee Tyl
a7cfac6e93 GitHub auth: use token with the most remaining requests
Part of #529.
2016-06-27 20:07:15 +02:00
Thaddee Tyl
bfc6e7d863 GitHub auth: use up to 3/4 of the user's rate limit 2016-06-27 19:38:01 +02:00
Thaddee Tyl
56746d4a38 GitHub auth: rely on cache if no tokens remain 2016-06-27 19:37:19 +02:00
Thaddee Tyl
12b0ded4a3 GitHub auth: use UTC epoch seconds instead of milliseconds 2016-06-26 18:41:32 +02:00
Thaddee Tyl
63e25b29eb GitHub auth: no longer rely on buggy rate limit cache 2016-06-26 18:30:27 +02:00
Thaddee Tyl
a3ba53a0d8 GitHub auth: user token selection supports remaining requests 2016-06-26 18:01:48 +02:00
Thaddee Tyl
2b849b2b7f GitHub auth: log token requests 2016-06-26 17:21:00 +02:00
Thaddee Tyl
014753a736 GitHub auth: better messages 2016-06-26 16:45:44 +02:00
Thaddee Tyl
14d436084b GitHub auth: log token rate limits and unauthorization 2016-06-25 20:32:30 +02:00
Thaddee Tyl
997e6a6f43 GitHub auth: maintain rate limit reset information, track token with highest remaining requests 2016-06-23 19:28:56 +02:00
Thaddee Tyl
fe279e4a75 GitHub auth: removal of unauthorized user tokens 2016-06-22 10:12:07 +02:00
Thaddee Tyl
a54a247f16 GitHub auth: only use user tokens if over rate limit 2016-06-21 09:26:52 +02:00
Thaddee Tyl
58cbb18c1d GitHub auth: query parameter, don't shadow request() 2016-06-20 22:30:51 +02:00
Thaddee Tyl
3564e4474b GitHub auth: set up lowest available rate limit 2016-06-19 23:30:21 +02:00
Thaddee Tyl
b3e8ab9556 Custom GitHub requests 2016-06-18 23:28:43 +02:00
Thaddee Tyl
ec2a35266b Hide GitHub user tokens 2016-06-15 23:57:59 +02:00
Thaddee Tyl
fc223c9f86 Put GitHub user token synchronization in the background
Issue #529.
2016-06-01 23:55:17 +02:00
Thaddee Tyl
c403e367f7 Synchronize saved GitHub user tokens
Issue #529.

Having a server down breaks the process currently. That will be addressed in a
later commit.
2016-06-01 00:15:45 +02:00
Thaddee Tyl
419483f24e Transmit and save GitHub user tokens
Issue #529.
2016-05-28 22:33:34 +02:00
Thaddee Tyl
ccaacfc408 Support GitHub OAuth user authentication
Issue #529.
2016-05-21 21:34:35 +02:00