* Make the osslifecycle badge company-agnostic
Removes references to Netflix in the example titles of the osslifecycle badge
To make the badge more generic and easier to use by companies besides Netflix, the examples should remove Netflix from the title.
* Adding Netflix back in as a keyword, to make the badge easily searchable for people who remember it with the old title.
* Updated GPL, LGPL, and AGPL licence IDs to the SPEX 3.5 specification.
* Add GPL, LGPL, and AGPL aliases in the format in which they are used in Python classifiers.
This is a reworking of #3410 based on some feedback @calebcartwright left on that PR.
The goals of injecting the secrets are threefold:
1. Simplify testing
2. Be consistent with all of the other config (which is injected)
3. Encapsulate the sensitive auth-related code in one place so it can be studied and tested thoroughly
- Rather than add more code to BaseService to handle authorization logic, it delegates that to an AuthHelper class.
- When the server starts, it fetches the credentials from `config` and injects them into `BaseService.register()` which passes them to `invoke()`.
- In `invoke()` the service's auth configuration is checked (`static get auth()`, much like `static get route()`).
- If the auth config is present, an AuthHelper instance is created and attached to the new instance.
- Then within the service, the password, basic auth config, or bearer authentication can be accessed via e.g. `this.authHelper.basicAuth` and passed to `this._requestJson()` and friends.
- Everything is being done very explicitly, so it should be very clear where and how the configured secrets are being used.
- Testing different configurations of services can now be done by injecting the config into `invoke()` in `.spec` files instead of mocking global state in the service tests as was done before. See the new Jira spec files for a good example of this.
Ref #3393
* Ensure Joi is imported as @hapi/joi [cirrus]
I noticed this import failed in #3675. Maybe we've finally dropped the last copy of the old joi?
* Ignore dangerfile
Now that these s0.server.shields.io entries are set up through the main DNS on Cloudflare, we don't need the shields-server.com domain anymore. One less thing to maintain.
This encapsulates the fetch methods slightly better. Cherry-picked from #3410, which needs to be reworked. This change should simplify dropping in the new auth method when that happens.
Add support for the Spack package manager (https://spack.io).
Spack is a modern multi-language, multi-variant software package
manager in high-performance computing (HPC).
The example we were previously using
(Az.Storage) now renders
platform | not specified
This replaces the example with a
package that gives us a valid result
* which --> variant
* which --> alias
* which --> format
* improve param names in codeclimate
* improve param names in github-issue-detail
* update github-issue-detail unit tests
* Add subreddit subscribers service file.
* Fix small detail in service and add the tests files.
* Apply suggested changes by the reviewer.
* Trying to make tests work.
* Update services/reddit/subreddit-subscribers.tester.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* Update services/reddit/subreddit-subscribers.tester.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* Apply suggested changes.
* Add different handler for non existing and invalid subreddits.
* Update services/reddit/subreddit-subscribers.service.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* switch [circleci] service to scrape SVG badge
* reorganise [circleci] routes
Default URL is now
circleci/build/gh/badges/shields/master?token=abc123
There are redirects on the legacy routes to provide
backwards compatibility for existing users
Fixes https://github.com/badges/shields/issues/3260
Problem happens when a value of a color in an old PNG static badge is a number: http://localhost:8080/my-label/my-message.png?color=1. In this case `color` in `queryParams` is a number.
0a0b5b3f03/core/server/server.js (L203-L212)
Surprisingly service test listed below is passing currently on master - value `1` is represented in `queryParams` as a String (only in test).
`services/static-badge/static-badge.tester.js`
```js
t.create('Old static badge with a number as a color')
.get('/foo/bar.png?color=1', { followRedirect: false })
.expectStatus(301)
.expectHeader('Location', '/badge/foo-bar-1.png')
```
Moreover I added some code + description allowing to debug server.
* Fix LGTM badges for non-GitHub projects.
* Allow using full repository host names in LGTM badge URLs.
* Add an LGTM redirector service to redirect old LGTM badge URLs to new LGTM badge URLs.
* Add LGTM redirector tester.
* Remove unneeded check in LGTM base file.
Co-Authored-By: chrisgavin <chris@chrisgavin.me>
