ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

perf: faster resetIconPosition avoiding to parse path twice (#10497)

Browse Source
This commit is contained in:
Álvaro Mondéjar Rubio
2024-09-04 18:32:01 +02:00
committed by GitHub
parent 026b45e07d
commit f776f817bd
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/svg-helpers.js
View File

@@ -19,9 +19,10 @@ function getIconSize(iconKey) {
return { width: x1 - x0, height: y1 - y0 }
}
function resetIconPosition(path) {
function resetIconPosition(d) {
const path = svgpath(d)
const [offsetX, offsetY] = svgPathBbox(path)
const pathReset = svgpath(path).translate(-offsetX, -offsetY).toString()
const pathReset = path.translate(-offsetX, -offsetY).toString()
return pathReset
}

9
package-lock.json generated
View File

@@ -53,7 +53,7 @@
"semver": "~7.6.3",
"simple-icons": "13.7.0",
"smol-toml": "1.3.0",
"svg-path-bbox": "^2.0.0",
"svg-path-bbox": "^2.1.0",
"svgpath": "^2.6.0",
"webextension-store-meta": "^1.2.3",
"xpath": "~0.0.34"
@@ -28166,10 +28166,9 @@
"dev": true
},
"node_modules/svg-path-bbox": {
"version": "2.0.0",
"resolved": "https://registry.npmjs.org/svg-path-bbox/-/svg-path-bbox-2.0.0.tgz",
"integrity": "sha512-DP/dcKuwjfJ2GXiM1RsIKcWv+aGazBXTYPuAH9pWYZVm5+pZ6ho70BeLB0inqUGDCCHDmcUlQ2OcLlGuwhmkKQ==",
"license": "BSD-3-Clause",
"version": "2.1.0",
"resolved": "https://registry.npmjs.org/svg-path-bbox/-/svg-path-bbox-2.1.0.tgz",
"integrity": "sha512-PEoSQFbBvL7FOCE4cN8Knej6L7bXdNkjPcUYsfMMpq0HpnqiO0sE2mcXTd7LX160aOyh5HbaeN/SoY8thMk5Kg==",
"dependencies": {
"svgpath": "^2.6.0"
},

2
package.json
View File

@@ -65,7 +65,7 @@
"semver": "~7.6.3",
"simple-icons": "13.7.0",
"smol-toml": "1.3.0",
"svg-path-bbox": "^2.0.0",
"svg-path-bbox": "^2.1.0",
"svgpath": "^2.6.0",
"webextension-store-meta": "^1.2.3",
"xpath": "~0.0.34"