migrate examples to openApi part 34; affects [github] (#9865)

* fix github service tests

* migrate some services from examples to openApi

* document latest variant with separate examples

making seperate routes for the /{version} and /latest variants
allows us to only show the docs for
- include_prereleases
- sort and
- filter
in the situation where they are relevant
This commit is contained in:
chris48s
2024-01-04 20:02:03 +00:00
committed by GitHub
parent b1f5aecf36
commit e8a148eed3
9 changed files with 215 additions and 338 deletions

View File

@@ -1,15 +1,20 @@
import Joi from 'joi'
import { pathParam } from '../index.js'
import { metric } from '../text-formatters.js'
import { nonNegativeInteger } from '../validators.js'
import { GithubAuthV3Service } from './github-auth-service.js'
import {
fetchLatestRelease,
queryParamSchema,
openApiQueryParams,
} from './github-common-release.js'
import { documentation, httpErrorsFor } from './github-helpers.js'
const schema = Joi.object({ ahead_by: nonNegativeInteger }).required()
const latestDocs =
'<p>The <code>include_prereleases</code>, <code>sort</code> and <code>filter</code> params can be used to configure how we determine the latest version.</p>'
export default class GithubCommitsSince extends GithubAuthV3Service {
static category = 'activity'
static route = {
@@ -18,110 +23,60 @@ export default class GithubCommitsSince extends GithubAuthV3Service {
queryParamSchema,
}
static examples = [
{
title: 'GitHub commits since tagged version',
namedParams: {
user: 'SubtitleEdit',
repo: 'subtitleedit',
version: '3.4.7',
static openApi = {
'/github/commits-since/{user}/{repo}/{version}': {
get: {
summary: 'GitHub commits since tagged version',
description: documentation,
parameters: [
pathParam({ name: 'user', example: 'SubtitleEdit' }),
pathParam({ name: 'repo', example: 'subtitleedit' }),
pathParam({
name: 'version',
example: '3.4.7',
}),
],
},
staticPreview: this.render({
version: '3.4.7',
commitCount: 4225,
}),
documentation,
},
{
title: 'GitHub commits since tagged version (branch)',
namedParams: {
user: 'SubtitleEdit',
repo: 'subtitleedit',
version: '3.4.7',
branch: 'master',
'/github/commits-since/{user}/{repo}/{version}/{branch}': {
get: {
summary: 'GitHub commits since tagged version (branch)',
description: documentation,
parameters: [
pathParam({ name: 'user', example: 'SubtitleEdit' }),
pathParam({ name: 'repo', example: 'subtitleedit' }),
pathParam({
name: 'version',
example: '3.4.7',
}),
pathParam({ name: 'branch', example: 'main' }),
],
},
staticPreview: this.render({
version: '3.4.7',
commitCount: 4225,
}),
documentation,
},
{
title: 'GitHub commits since latest release (by date)',
namedParams: {
user: 'SubtitleEdit',
repo: 'subtitleedit',
version: 'latest',
'/github/commits-since/{user}/{repo}/latest': {
get: {
summary: 'GitHub commits since latest release',
description: documentation + latestDocs,
parameters: [
pathParam({ name: 'user', example: 'SubtitleEdit' }),
pathParam({ name: 'repo', example: 'subtitleedit' }),
...openApiQueryParams,
],
},
staticPreview: this.render({
version: '3.5.7',
commitCount: 157,
}),
documentation,
},
{
title: 'GitHub commits since latest release (by date) for a branch',
namedParams: {
user: 'SubtitleEdit',
repo: 'subtitleedit',
version: 'latest',
branch: 'master',
'/github/commits-since/{user}/{repo}/latest/{branch}': {
get: {
summary: 'GitHub commits since latest release (branch)',
description: documentation + latestDocs,
parameters: [
pathParam({ name: 'user', example: 'SubtitleEdit' }),
pathParam({ name: 'repo', example: 'subtitleedit' }),
pathParam({ name: 'branch', example: 'main' }),
...openApiQueryParams,
],
},
staticPreview: this.render({
version: '3.5.7',
commitCount: 157,
}),
documentation,
},
{
title:
'GitHub commits since latest release (by date including pre-releases)',
namedParams: {
user: 'SubtitleEdit',
repo: 'subtitleedit',
version: 'latest',
},
queryParams: { include_prereleases: null },
staticPreview: this.render({
version: 'v3.5.8-alpha.1',
isPrerelease: true,
commitCount: 158,
}),
documentation,
},
{
title: 'GitHub commits since latest release (by SemVer)',
namedParams: {
user: 'SubtitleEdit',
repo: 'subtitleedit',
version: 'latest',
},
queryParams: { sort: 'semver' },
staticPreview: this.render({
version: 'v4.0.1',
sort: 'semver',
commitCount: 200,
}),
documentation,
},
{
title:
'GitHub commits since latest release (by SemVer including pre-releases)',
namedParams: {
user: 'SubtitleEdit',
repo: 'subtitleedit',
version: 'latest',
},
queryParams: { sort: 'semver', include_prereleases: null },
staticPreview: this.render({
version: 'v4.0.2-alpha.1',
sort: 'semver',
isPrerelease: true,
commitCount: 201,
}),
documentation,
},
]
}
static defaultBadgeData = { label: 'github', namedLogo: 'github' }