ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

Split BaseService and BaseJsonService into separate modules (#1889)

Browse Source 
There’s a lot of behavior here, and going to be even more, so I think it makes sense to split these up as I’ve done with the tests.
This commit is contained in:
Paul Melnikow
2018-08-11 10:43:05 -04:00
committed by GitHub
parent ed81dcbb36
commit db4bffb300
15 changed files with 76 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/gem/gem-downloads.service.js
View File

@@ -3,7 +3,7 @@
const semver = require('semver')
const Joi = require('joi')
const { BaseJsonService } = require('../base')
const BaseJsonService = require('../base-json')
const { InvalidResponse } = require('../errors')
const {
downloadCount: downloadCountColor,

2
services/gem/gem-owner.service.js
View File

@@ -2,7 +2,7 @@
const Joi = require('joi')
const { BaseJsonService } = require('../base')
const BaseJsonService = require('../base-json')
const { floorCount: floorCountColor } = require('../../lib/color-formatters')
const ownerSchema = Joi.array().required()

2
services/gem/gem-rank.service.js
View File

@@ -2,7 +2,7 @@
const Joi = require('joi')
const { BaseJsonService } = require('../base')
const BaseJsonService = require('../base-json')
const { floorCount: floorCountColor } = require('../../lib/color-formatters')
const { ordinalNumber } = require('../../lib/text-formatters')
const { nonNegativeInteger } = require('../validators.js')

2
services/gem/gem-version.service.js
View File

@@ -2,7 +2,7 @@
const Joi = require('joi')
const { BaseJsonService } = require('../base')
const BaseJsonService = require('../base-json')
const { addv: versionText } = require('../../lib/text-formatters')
const { version: versionColor } = require('../../lib/color-formatters')