From c770a43dd865bf986fe7a0f61d71430e5e11dbd7 Mon Sep 17 00:00:00 2001
From: Paul Melnikow <github@paulmelnikow.com>
Date: Wed, 20 Feb 2019 18:43:27 -0500
Subject: [PATCH] Move flip cache debug service into [debug] (#3057)

Close #2636
---
 services/debug/debug.service.js | 19 ++++++++++++++++++-
 services/debug/debug.tester.js  |  8 ++++++++
 services/flip/flip.service.js   | 33 ---------------------------------
 services/flip/flip.tester.js    | 11 -----------
 4 files changed, 26 insertions(+), 45 deletions(-)
 delete mode 100644 services/flip/flip.service.js
 delete mode 100644 services/flip/flip.tester.js

diff --git a/services/debug/debug.service.js b/services/debug/debug.service.js
index ea7390f5b8..221bc565a9 100644
--- a/services/debug/debug.service.js
+++ b/services/debug/debug.service.js
@@ -3,6 +3,7 @@
 const { NonMemoryCachingBaseService } = require('..')
 
 const serverStartTime = new Date(new Date().toGMTString())
+let bitFlip = false
 
 module.exports = class Debug extends NonMemoryCachingBaseService {
   static get category() {
@@ -19,7 +20,7 @@ module.exports = class Debug extends NonMemoryCachingBaseService {
   static get route() {
     return {
       base: 'debug',
-      pattern: ':which(time|starttime)',
+      pattern: ':which(time|starttime|flip)',
     }
   }
 
@@ -35,6 +36,22 @@ module.exports = class Debug extends NonMemoryCachingBaseService {
           label: 'start time',
           message: new Date(serverStartTime).toUTCString(),
         }
+      // For production cache debugging.
+      case 'flip':
+        bitFlip = !bitFlip
+        if (bitFlip) {
+          return {
+            label: 'flip',
+            message: 'on',
+            color: 'brightgreen',
+          }
+        } else {
+          return {
+            label: 'flip',
+            message: 'off',
+            color: 'red',
+          }
+        }
     }
   }
 }
diff --git a/services/debug/debug.tester.js b/services/debug/debug.tester.js
index db7f1d218c..6c1aad39d1 100644
--- a/services/debug/debug.tester.js
+++ b/services/debug/debug.tester.js
@@ -7,3 +7,11 @@ const t = (module.exports = require('../tester').createServiceTester())
 t.create('start time')
   .get('/starttime.json')
   .expectJSONTypes({ name: 'start time', value: Joi.date().required() })
+
+t.create('Flip: first request')
+  .get('/flip.json')
+  .expectJSON({ name: 'flip', value: 'on' })
+
+t.create('Flip: second request')
+  .get('/flip.json')
+  .expectJSON({ name: 'flip', value: 'off' })
diff --git a/services/flip/flip.service.js b/services/flip/flip.service.js
deleted file mode 100644
index 6c0dc06c23..0000000000
--- a/services/flip/flip.service.js
+++ /dev/null
@@ -1,33 +0,0 @@
-'use strict'
-
-const { NonMemoryCachingBaseService } = require('..')
-
-let bitFlip = false
-
-// Production cache debugging.
-module.exports = class Flip extends NonMemoryCachingBaseService {
-  static get category() {
-    return 'debug'
-  }
-
-  static get route() {
-    return { base: 'flip', pattern: '' }
-  }
-
-  static get defaultBadgeData() {
-    return { label: 'flip' }
-  }
-
-  static render({ bit }) {
-    if (bit) {
-      return { message: 'on', color: 'brightgreen' }
-    } else {
-      return { message: 'off', color: 'red' }
-    }
-  }
-
-  handle() {
-    bitFlip = !bitFlip
-    return this.constructor.render({ bit: bitFlip })
-  }
-}
diff --git a/services/flip/flip.tester.js b/services/flip/flip.tester.js
deleted file mode 100644
index c52365b4f1..0000000000
--- a/services/flip/flip.tester.js
+++ /dev/null
@@ -1,11 +0,0 @@
-'use strict'
-
-const t = (module.exports = require('../tester').createServiceTester())
-
-t.create('First request')
-  .get('.json')
-  .expectJSON({ name: 'flip', value: 'on' })
-
-t.create('Second request')
-  .get('.json')
-  .expectJSON({ name: 'flip', value: 'off' })