Disallow redundant example patterns (#2787)

services/bitbucket/bitbucket-pull-request.service.js

@@ -106,7 +106,6 @@ function pullRequestClassGenerator(raw) {
       return [
         {
           title: 'Bitbucket open pull requests',
-          pattern: ':user/:repo',
           namedParams: {
             user: 'atlassian',
             repo: 'python-bitbucket',
@@ -120,7 +119,6 @@ function pullRequestClassGenerator(raw) {
             repo: 'bar',
           },
           queryParams: { server: 'https://bitbucket.mydomain.net' },
-          pattern: ':user/:repo',
           staticPreview: this.render({ prs: 42 }),
         },
       ]

services/codetally/codetally.service.js

@@ -41,7 +41,6 @@ module.exports = class Codetally extends BaseJsonService {
     return [
       {
         title: 'Codetally',
-        pattern: ':owner/:repo',
         namedParams: {
           owner: 'triggerman722',
           repo: 'colorstrap',

services/gitter/gitter.service.js

@@ -18,7 +18,6 @@ module.exports = class Gitter extends BaseStaticService {
     return [
       {
         title: 'Gitter',
-        pattern: ':user/:repo',
         namedParams: {
           user: 'nwjs',
           repo: 'nw.js',

services/matrix/matrix.service.js

@@ -201,7 +201,6 @@ module.exports = class Matrix extends BaseJsonService {
       {
         title: 'Matrix',
         namedParams: { roomAlias: 'twim:matrix.org' },
-        pattern: ':roomAlias',
         staticPreview: this.render({ members: 42 }),
         documentation,
       },
@@ -209,7 +208,6 @@ module.exports = class Matrix extends BaseJsonService {
         title: 'Matrix',
         namedParams: { roomAlias: 'twim:matrix.org' },
         queryParams: { server_fqdn: 'matrix.org' },
-        pattern: ':roomAlias',
         staticPreview: this.render({ members: 42 }),
         documentation,
       },

services/transform-example.js

@@ -66,6 +66,13 @@ function validateExample(example, index, ServiceClass) {
         } at index ${index} also declares a dynamic previewUrl, which is not allowed`
       )
     }
+    if (pattern === ServiceClass.route.pattern) {
+      throw new Error(
+        `Example for ${
+          ServiceClass.name
+        } at index ${index} declares a redundant pattern which should be removed`
+      )
+    }
 
     // Make sure we can build the full URL using these patterns.
     try {

services/wordpress/wordpress-platform.service.js

@@ -122,7 +122,6 @@ class WordpressPluginTestedVersion extends BaseWordpressPlatform {
     return [
       {
         title: 'Wordpress Plugin: Tested WP Version',
-        pattern: ':slug',
         namedParams: { slug: 'bbpress' },
         staticPreview: this.render({ version: '4.9.8', color: 'brightgreen' }),
         documentation: `<p>There is an alias for this badge. <code>wordpress/v/:slug.svg</code></p>`,