From bb5614df7097cfa09eb13d7624e050edad94e2fa Mon Sep 17 00:00:00 2001 From: chris48s Date: Wed, 29 Dec 2021 18:26:44 +0000 Subject: [PATCH] minor [reddit] improvements (#7436) * apply colour scheme to reddit karma badge * accept negative metric in reddit karma tests Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com> --- services/reddit/user-karma.service.js | 4 ++-- services/reddit/user-karma.tester.js | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/services/reddit/user-karma.service.js b/services/reddit/user-karma.service.js index 76eeb7769b..b53edfc68a 100644 --- a/services/reddit/user-karma.service.js +++ b/services/reddit/user-karma.service.js @@ -25,7 +25,7 @@ export default class RedditUserKarma extends BaseJsonService { staticPreview: { label: 'combined karma', message: 56, - color: 'red', + color: 'brightgreen', style: 'social', }, }, @@ -44,7 +44,7 @@ export default class RedditUserKarma extends BaseJsonService { return { label, message: metric(karma), - color: 'red', + color: karma > 0 ? 'brightgreen' : karma === 0 ? 'orange' : 'red', link: [`https://www.reddit.com/u/${user}`], } } diff --git a/services/reddit/user-karma.tester.js b/services/reddit/user-karma.tester.js index 9023023dbb..a7eb8d83c0 100644 --- a/services/reddit/user-karma.tester.js +++ b/services/reddit/user-karma.tester.js @@ -1,4 +1,4 @@ -import { isMetric } from '../test-validators.js' +import { isMetricAllowNegative } from '../test-validators.js' import { createServiceTester } from '../tester.js' export const t = await createServiceTester() @@ -6,21 +6,21 @@ t.create('user-karma (valid - link)') .get('/link/user_simulator.json') .expectBadge({ label: 'u/user_simulator karma (link)', - message: isMetric, + message: isMetricAllowNegative, }) t.create('user-karma (valid - comment') .get('/comment/user_simulator.json') .expectBadge({ label: 'u/user_simulator karma (comment)', - message: isMetric, + message: isMetricAllowNegative, }) t.create('user-karma (valid - combined)') .get('/combined/user_simulator.json') .expectBadge({ label: 'u/user_simulator karma', - message: isMetric, + message: isMetricAllowNegative, }) t.create('user-karma (non-existing user)')