convert some service classes to static fields, run [GitHubLernaJson GithubLicense GithubManifest GithubMilestoneDetail GithubMilestone GithubPackageJson] (#5595)

* refactor(githublernajson): convert to static fields

* refactor(githublicense): convert to static fields

* refactor(githubmanifest): convert to static fields

* refactor(githubmilestonedetail): convert to static fields

* refactor(githubmilestone): convert to static fields

* refactor(githubpackagejson): convert to static fields

services/github/github-package-json.service.js

@@ -22,41 +22,34 @@ const versionSchema = Joi.object({
 }).required()
 
 class GithubPackageJsonVersion extends ConditionalGithubAuthV3Service {
-  static get category() {
-    return 'version'
+  static category = 'version'
+  static route = {
+    base: 'github/package-json/v',
+    pattern: ':user/:repo/:branch*',
   }
 
-  static get route() {
-    return {
-      base: 'github/package-json/v',
-      pattern: ':user/:repo/:branch*',
-    }
-  }
-
-  static get examples() {
-    return [
-      {
-        title: 'GitHub package.json version',
-        pattern: ':user/:repo',
-        namedParams: { user: 'IcedFrisby', repo: 'IcedFrisby' },
-        staticPreview: this.render({ version: '2.0.0-alpha.2' }),
-        documentation,
-        keywords,
+  static examples = [
+    {
+      title: 'GitHub package.json version',
+      pattern: ':user/:repo',
+      namedParams: { user: 'IcedFrisby', repo: 'IcedFrisby' },
+      staticPreview: this.render({ version: '2.0.0-alpha.2' }),
+      documentation,
+      keywords,
+    },
+    {
+      title: 'GitHub package.json version (branch)',
+      pattern: ':user/:repo/:branch',
+      namedParams: {
+        user: 'IcedFrisby',
+        repo: 'IcedFrisby',
+        branch: 'master',
       },
-      {
-        title: 'GitHub package.json version (branch)',
-        pattern: ':user/:repo/:branch',
-        namedParams: {
-          user: 'IcedFrisby',
-          repo: 'IcedFrisby',
-          branch: 'master',
-        },
-        staticPreview: this.render({ version: '2.0.0-alpha.2' }),
-        documentation,
-        keywords,
-      },
-    ]
-  }
+      staticPreview: this.render({ version: '2.0.0-alpha.2' }),
+      documentation,
+      keywords,
+    },
+  ]
 
   static render({ version, branch }) {
     return renderVersionBadge({
@@ -83,79 +76,68 @@ const dependencyQueryParamSchema = Joi.object({
 }).required()
 
 class GithubPackageJsonDependencyVersion extends ConditionalGithubAuthV3Service {
-  static get category() {
-    return 'platform-support'
+  static category = 'platform-support'
+  static route = {
+    base: 'github/package-json/dependency-version',
+    pattern:
+      ':user/:repo/:kind(dev|peer)?/:scope(@[^/]+)?/:packageName/:branch*',
+    queryParamSchema: dependencyQueryParamSchema,
   }
 
-  static get route() {
-    return {
-      base: 'github/package-json/dependency-version',
-      pattern:
-        ':user/:repo/:kind(dev|peer)?/:scope(@[^/]+)?/:packageName/:branch*',
-      queryParamSchema: dependencyQueryParamSchema,
-    }
-  }
+  static examples = [
+    {
+      title: 'GitHub package.json dependency version (prod)',
+      pattern: ':user/:repo/:packageName',
+      namedParams: {
+        user: 'developit',
+        repo: 'microbundle',
+        packageName: 'rollup',
+      },
+      staticPreview: this.render({
+        dependency: 'rollup',
+        range: '^0.67.3',
+      }),
+      documentation,
+      keywords,
+    },
+    {
+      title: 'GitHub package.json dependency version (dev dep on branch)',
+      pattern: ':user/:repo/dev/:scope?/:packageName/:branch*',
+      namedParams: {
+        user: 'zeit',
+        repo: 'next.js',
+        branch: 'canary',
+        scope: '@babel',
+        packageName: 'preset-react',
+      },
+      staticPreview: this.render({
+        dependency: '@babel/preset-react',
+        range: '7.0.0',
+      }),
+      documentation,
+      keywords,
+    },
+    {
+      title: 'GitHub package.json dependency version (subfolder of monorepo)',
+      pattern: ':user/:repo/:packageName',
+      namedParams: {
+        user: 'metabolize',
+        repo: 'anafanafo',
+        packageName: 'puppeteer',
+      },
+      queryParams: {
+        filename: 'packages/char-width-table-builder/package.json',
+      },
+      staticPreview: this.render({
+        dependency: 'puppeteer',
+        range: '^1.14.0',
+      }),
+      documentation,
+      keywords,
+    },
+  ]
 
-  static get examples() {
-    return [
-      {
-        title: 'GitHub package.json dependency version (prod)',
-        pattern: ':user/:repo/:packageName',
-        namedParams: {
-          user: 'developit',
-          repo: 'microbundle',
-          packageName: 'rollup',
-        },
-        staticPreview: this.render({
-          dependency: 'rollup',
-          range: '^0.67.3',
-        }),
-        documentation,
-        keywords,
-      },
-      {
-        title: 'GitHub package.json dependency version (dev dep on branch)',
-        pattern: ':user/:repo/dev/:scope?/:packageName/:branch*',
-        namedParams: {
-          user: 'zeit',
-          repo: 'next.js',
-          branch: 'canary',
-          scope: '@babel',
-          packageName: 'preset-react',
-        },
-        staticPreview: this.render({
-          dependency: '@babel/preset-react',
-          range: '7.0.0',
-        }),
-        documentation,
-        keywords,
-      },
-      {
-        title: 'GitHub package.json dependency version (subfolder of monorepo)',
-        pattern: ':user/:repo/:packageName',
-        namedParams: {
-          user: 'metabolize',
-          repo: 'anafanafo',
-          packageName: 'puppeteer',
-        },
-        queryParams: {
-          filename: 'packages/char-width-table-builder/package.json',
-        },
-        staticPreview: this.render({
-          dependency: 'puppeteer',
-          range: '^1.14.0',
-        }),
-        documentation,
-        keywords,
-      },
-    ]
-  }
-
-  static get defaultBadgeData() {
-    return {
-      label: 'dependency',
-    }
-  }
+  static defaultBadgeData = { label: 'dependency' }
 
   static render({ dependency, range }) {
     return {
@@ -200,59 +182,48 @@ class GithubPackageJsonDependencyVersion extends ConditionalGithubAuthV3Service
 // This must be exported after GithubPackageJsonVersion in order for the
 // former to work correctly.
 class DynamicGithubPackageJson extends ConditionalGithubAuthV3Service {
-  static get category() {
-    return 'other'
+  static category = 'other'
+  static route = {
+    base: 'github/package-json',
+    pattern: ':key/:user/:repo/:branch*',
   }
 
-  static get route() {
-    return {
-      base: 'github/package-json',
-      pattern: ':key/:user/:repo/:branch*',
-    }
-  }
-
-  static get examples() {
-    return [
-      {
-        title: 'GitHub package.json dynamic',
-        pattern: ':key/:user/:repo',
-        namedParams: {
-          key: 'keywords',
-          user: 'developit',
-          repo: 'microbundle',
-        },
-        staticPreview: this.render({
-          key: 'keywords',
-          value: ['bundle', 'rollup', 'micro library'],
-        }),
-        documentation,
-        keywords,
+  static examples = [
+    {
+      title: 'GitHub package.json dynamic',
+      pattern: ':key/:user/:repo',
+      namedParams: {
+        key: 'keywords',
+        user: 'developit',
+        repo: 'microbundle',
       },
-      {
-        title: 'GitHub package.json dynamic',
-        pattern: ':key/:user/:repo/:branch',
-        namedParams: {
-          key: 'keywords',
-          user: 'developit',
-          repo: 'microbundle',
-          branch: 'master',
-        },
-        staticPreview: this.render({
-          key: 'keywords',
-          value: ['bundle', 'rollup', 'micro library'],
-          branch: 'master',
-        }),
-        documentation,
-        keywords,
+      staticPreview: this.render({
+        key: 'keywords',
+        value: ['bundle', 'rollup', 'micro library'],
+      }),
+      documentation,
+      keywords,
+    },
+    {
+      title: 'GitHub package.json dynamic',
+      pattern: ':key/:user/:repo/:branch',
+      namedParams: {
+        key: 'keywords',
+        user: 'developit',
+        repo: 'microbundle',
+        branch: 'master',
       },
-    ]
-  }
+      staticPreview: this.render({
+        key: 'keywords',
+        value: ['bundle', 'rollup', 'micro library'],
+        branch: 'master',
+      }),
+      documentation,
+      keywords,
+    },
+  ]
 
-  static get defaultBadgeData() {
-    return {
-      label: 'package.json',
-    }
-  }
+  static defaultBadgeData = { label: 'package.json' }
 
   static render({ key, value, branch }) {
     return renderDynamicBadge({