ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

checkErrorResponse documented in service tests (#1670)

Browse Source 
* Travis integration uses checkErrorResponse

* checkErrorResponse added to service tests doc
This commit is contained in:
Marcin Mielnicki
2018-05-02 16:06:09 +02:00
committed by GitHub
parent 714df8fac5
commit b126b4ebdc
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
doc/service-tests.md
View File

@@ -48,14 +48,15 @@ cache(function(data, match, sendBadge, request) {
uri: 'https://api.travis-ci.org/' + userRepo + '.svg',
};
if (branch != null) {
options.uri += '?branch=' + branch; // (3)
options.uri += '?branch=' + branch; // 3
}
var badgeData = getBadgeData('build', data);
request(options, function(err, res) {
if (err != null) {
console.error('Travis error: ' + err.stack); // 5
if (res) { console.error(''+res); }
badgeData.text[1] = 'inaccessible';
log.error('Travis error: ' + err.stack);
if (res) { log.error(''+res); }
}
if (checkErrorResponse(badgeData, err, res)) { // 5
sendBadge(format, badgeData);
return;
}
@@ -264,8 +265,8 @@ npm run coverage:report:open
```
After searching `server.js` for the Travis code, we see that we've missed a
big block: the error branch in the request callback. To test that, we simulate
network connection errors on any unmocked requests.
big block which is executed when `checkErrorResponse` returns `true`. To test
that, we simulate network connection errors on any unmocked requests.
```js
t.create('connection error')