convert some service classes to static props, run [archlinux aur azuredevops] (#5500)

* refactor(archlinux): convert to static props * refactor(aur): convert to static props * refactor(azuredevops): convert to static props * tests: fix AzDO Coverage service test Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
2020-09-08 17:13:31 -05:00
parent e9b3a0a921
commit 7e68644587
7 changed files with 250 additions and 336 deletions
--- a/services/azure-devops/azure-devops-build.service.js
+++ b/services/azure-devops/azure-devops-build.service.js
@@ -34,76 +34,70 @@ const documentation = `
 `

 module.exports = class AzureDevOpsBuild extends BaseSvgScrapingService {
-  static get category() {
-    return 'build'
+  static category = 'build'
+
+  static route = {
+    base: 'azure-devops/build',
+    pattern: ':organization/:projectId/:definitionId/:branch*',
+    queryParamSchema,
  }

-  static get route() {
-    return {
-      base: 'azure-devops/build',
-      pattern: ':organization/:projectId/:definitionId/:branch*',
-      queryParamSchema,
-    }
-  }
-
-  static get examples() {
-    return [
-      {
-        title: 'Azure DevOps builds',
-        pattern: ':organization/:projectId/:definitionId',
-        namedParams: {
-          organization: 'totodem',
-          projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
-          definitionId: '2',
-        },
-        staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
-        keywords,
-        documentation,
+  static examples = [
+    {
+      title: 'Azure DevOps builds',
+      pattern: ':organization/:projectId/:definitionId',
+      namedParams: {
+        organization: 'totodem',
+        projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
+        definitionId: '2',
      },
-      {
-        title: 'Azure DevOps builds (branch)',
-        pattern: ':organization/:projectId/:definitionId/:branch',
-        namedParams: {
-          organization: 'totodem',
-          projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
-          definitionId: '2',
-          branch: 'master',
-        },
-        staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
-        keywords,
-        documentation,
+      staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
+      keywords,
+      documentation,
+    },
+    {
+      title: 'Azure DevOps builds (branch)',
+      pattern: ':organization/:projectId/:definitionId/:branch',
+      namedParams: {
+        organization: 'totodem',
+        projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
+        definitionId: '2',
+        branch: 'master',
      },
-      {
-        title: 'Azure DevOps builds (stage)',
-        namedParams: {
-          organization: 'totodem',
-          projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
-          definitionId: '5',
-        },
-        queryParams: {
-          stage: 'Successful Stage',
-        },
-        staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
-        keywords,
-        documentation,
+      staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
+      keywords,
+      documentation,
+    },
+    {
+      title: 'Azure DevOps builds (stage)',
+      namedParams: {
+        organization: 'totodem',
+        projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
+        definitionId: '5',
      },
-      {
-        title: 'Azure DevOps builds (job)',
-        namedParams: {
-          organization: 'totodem',
-          projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
-          definitionId: '5',
-        },
-        queryParams: {
-          stage: 'Successful Stage',
-          job: 'Successful Job',
-        },
-        staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
-        keywords,
-        documentation,
+      queryParams: {
+        stage: 'Successful Stage',
      },
-    ]
-  }
+      staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
+      keywords,
+      documentation,
+    },
+    {
+      title: 'Azure DevOps builds (job)',
+      namedParams: {
+        organization: 'totodem',
+        projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
+        definitionId: '5',
+      },
+      queryParams: {
+        stage: 'Successful Stage',
+        job: 'Successful Job',
+      },
+      staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
+      keywords,
+      documentation,
+    },
+  ]

  async handle(
    { organization, projectId, definitionId, branch },
--- a/services/azure-devops/azure-devops-coverage.service.js
+++ b/services/azure-devops/azure-devops-coverage.service.js
@@ -47,50 +47,42 @@ const buildCodeCoverageSchema = Joi.object({
 }).required()

 module.exports = class AzureDevOpsCoverage extends AzureDevOpsBase {
-  static get category() {
-    return 'coverage'
+  static category = 'coverage'
+
+  static route = {
+    base: 'azure-devops/coverage',
+    pattern: ':organization/:project/:definitionId/:branch*',
  }

-  static get route() {
-    return {
-      base: 'azure-devops/coverage',
-      pattern: ':organization/:project/:definitionId/:branch*',
-    }
-  }
-
-  static get examples() {
-    return [
-      {
-        title: 'Azure DevOps coverage',
-        pattern: ':organization/:project/:definitionId',
-        namedParams: {
-          organization: 'swellaby',
-          project: 'opensource',
-          definitionId: '25',
-        },
-        staticPreview: this.render({ coverage: 100 }),
-        keywords,
-        documentation,
+  static examples = [
+    {
+      title: 'Azure DevOps coverage',
+      pattern: ':organization/:project/:definitionId',
+      namedParams: {
+        organization: 'swellaby',
+        project: 'opensource',
+        definitionId: '25',
      },
-      {
-        title: 'Azure DevOps coverage (branch)',
-        pattern: ':organization/:project/:definitionId/:branch',
-        namedParams: {
-          organization: 'swellaby',
-          project: 'opensource',
-          definitionId: '25',
-          branch: 'master',
-        },
-        staticPreview: this.render({ coverage: 100 }),
-        keywords,
-        documentation,
+      staticPreview: this.render({ coverage: 100 }),
+      keywords,
+      documentation,
+    },
+    {
+      title: 'Azure DevOps coverage (branch)',
+      pattern: ':organization/:project/:definitionId/:branch',
+      namedParams: {
+        organization: 'swellaby',
+        project: 'opensource',
+        definitionId: '25',
+        branch: 'master',
      },
-    ]
-  }
+      staticPreview: this.render({ coverage: 100 }),
+      keywords,
+      documentation,
+    },
+  ]

-  static get defaultBadgeData() {
-    return { label: 'coverage' }
-  }
+  static defaultBadgeData = { label: 'coverage' }

  static render({ coverage }) {
    return {
--- a/services/azure-devops/azure-devops-coverage.tester.js
+++ b/services/azure-devops/azure-devops-coverage.tester.js
@@ -5,7 +5,7 @@ const t = (module.exports = require('../tester').createServiceTester())

 const org = 'swellaby'
 const project = 'opensource'
-const linuxDefinitionId = 21
+const linuxDefinitionId = 25
 const macDefinitionId = 26
 const windowsDefinitionId = 24
 const nonExistentDefinitionId = 234421
--- a/services/azure-devops/azure-devops-release.service.js
+++ b/services/azure-devops/azure-devops-release.service.js
@@ -23,39 +23,29 @@ const documentation = `
 `

 module.exports = class AzureDevOpsRelease extends BaseSvgScrapingService {
-  static get category() {
-    return 'build'
+  static category = 'build'
+
+  static route = {
+    base: 'azure-devops/release',
+    pattern: ':organization/:projectId/:definitionId/:environmentId',
  }

-  static get route() {
-    return {
-      base: 'azure-devops/release',
-      pattern: ':organization/:projectId/:definitionId/:environmentId',
-    }
-  }
-
-  static get examples() {
-    return [
-      {
-        title: 'Azure DevOps releases',
-        namedParams: {
-          organization: 'totodem',
-          projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
-          definitionId: '1',
-          environmentId: '1',
-        },
-        staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
-        keywords,
-        documentation,
+  static examples = [
+    {
+      title: 'Azure DevOps releases',
+      namedParams: {
+        organization: 'totodem',
+        projectId: '8cf3ec0e-d0c2-4fcd-8206-ad204f254a96',
+        definitionId: '1',
+        environmentId: '1',
      },
-    ]
-  }
+      staticPreview: renderBuildStatusBadge({ status: 'succeeded' }),
+      keywords,
+      documentation,
+    },
+  ]

-  static get defaultBadgeData() {
-    return {
-      label: 'deployment',
-    }
-  }
+  static defaultBadgeData = { label: 'deployment' }

  async handle({ organization, projectId, definitionId, environmentId }) {
    // Microsoft documentation: ?
--- a/services/azure-devops/azure-devops-tests.service.js
+++ b/services/azure-devops/azure-devops-tests.service.js
@@ -62,103 +62,95 @@ const buildTestResultSummarySchema = Joi.object({
 }).required()

 module.exports = class AzureDevOpsTests extends AzureDevOpsBase {
-  static get category() {
-    return 'build'
+  static category = 'build'
+
+  static route = {
+    base: 'azure-devops/tests',
+    pattern: ':organization/:project/:definitionId/:branch*',
+    queryParamSchema: testResultQueryParamSchema,
  }

-  static get route() {
-    return {
-      base: 'azure-devops/tests',
-      pattern: ':organization/:project/:definitionId/:branch*',
-      queryParamSchema: testResultQueryParamSchema,
-    }
-  }
+  static examples = [
+    {
+      title: 'Azure DevOps tests',
+      pattern: ':organization/:project/:definitionId',
+      namedParams: {
+        organization: 'azuredevops-powershell',
+        project: 'azuredevops-powershell',
+        definitionId: '1',
+      },
+      staticPreview: this.render({
+        passed: 20,
+        failed: 1,
+        skipped: 1,
+        total: 22,
+      }),
+      ...commonAttrs,
+    },
+    {
+      title: 'Azure DevOps tests (branch)',
+      pattern: ':organization/:project/:definitionId/:branch',
+      namedParams: {
+        organization: 'azuredevops-powershell',
+        project: 'azuredevops-powershell',
+        definitionId: '1',
+        branch: 'master',
+      },
+      staticPreview: this.render({
+        passed: 20,
+        failed: 1,
+        skipped: 1,
+        total: 22,
+      }),
+      ...commonAttrs,
+    },
+    {
+      title: 'Azure DevOps tests (compact)',
+      pattern: ':organization/:project/:definitionId',
+      namedParams: {
+        organization: 'azuredevops-powershell',
+        project: 'azuredevops-powershell',
+        definitionId: '1',
+      },
+      queryParams: {
+        compact_message: null,
+      },
+      staticPreview: this.render({
+        passed: 20,
+        failed: 1,
+        skipped: 1,
+        total: 22,
+        isCompact: true,
+      }),
+      ...commonAttrs,
+    },
+    {
+      title: 'Azure DevOps tests with custom labels',
+      pattern: ':organization/:project/:definitionId',
+      namedParams: {
+        organization: 'azuredevops-powershell',
+        project: 'azuredevops-powershell',
+        definitionId: '1',
+      },
+      queryParams: {
+        passed_label: 'good',
+        failed_label: 'bad',
+        skipped_label: 'n/a',
+      },
+      staticPreview: this.render({
+        passed: 20,
+        failed: 1,
+        skipped: 1,
+        total: 22,
+        passedLabel: 'good',
+        failedLabel: 'bad',
+        skippedLabel: 'n/a',
+      }),
+      ...commonAttrs,
+    },
+  ]

-  static get examples() {
-    return [
-      {
-        title: 'Azure DevOps tests',
-        pattern: ':organization/:project/:definitionId',
-        namedParams: {
-          organization: 'azuredevops-powershell',
-          project: 'azuredevops-powershell',
-          definitionId: '1',
-        },
-        staticPreview: this.render({
-          passed: 20,
-          failed: 1,
-          skipped: 1,
-          total: 22,
-        }),
-        ...commonAttrs,
-      },
-      {
-        title: 'Azure DevOps tests (branch)',
-        pattern: ':organization/:project/:definitionId/:branch',
-        namedParams: {
-          organization: 'azuredevops-powershell',
-          project: 'azuredevops-powershell',
-          definitionId: '1',
-          branch: 'master',
-        },
-        staticPreview: this.render({
-          passed: 20,
-          failed: 1,
-          skipped: 1,
-          total: 22,
-        }),
-        ...commonAttrs,
-      },
-      {
-        title: 'Azure DevOps tests (compact)',
-        pattern: ':organization/:project/:definitionId',
-        namedParams: {
-          organization: 'azuredevops-powershell',
-          project: 'azuredevops-powershell',
-          definitionId: '1',
-        },
-        queryParams: {
-          compact_message: null,
-        },
-        staticPreview: this.render({
-          passed: 20,
-          failed: 1,
-          skipped: 1,
-          total: 22,
-          isCompact: true,
-        }),
-        ...commonAttrs,
-      },
-      {
-        title: 'Azure DevOps tests with custom labels',
-        pattern: ':organization/:project/:definitionId',
-        namedParams: {
-          organization: 'azuredevops-powershell',
-          project: 'azuredevops-powershell',
-          definitionId: '1',
-        },
-        queryParams: {
-          passed_label: 'good',
-          failed_label: 'bad',
-          skipped_label: 'n/a',
-        },
-        staticPreview: this.render({
-          passed: 20,
-          failed: 1,
-          skipped: 1,
-          total: 22,
-          passedLabel: 'good',
-          failedLabel: 'bad',
-          skippedLabel: 'n/a',
-        }),
-        ...commonAttrs,
-      },
-    ]
-  }
-
-  static get defaultBadgeData() {
-    return { label: 'tests' }
-  }
+  static defaultBadgeData = { label: 'tests' }

  static render({
    passed,