From 7d90391b05ca0f7f1092389247c64b0c4618afcd Mon Sep 17 00:00:00 2001 From: Paul Melnikow Date: Sun, 18 Mar 2018 13:34:15 -0400 Subject: [PATCH] Housekeeping after upgrade to Node 8 (#1564) --- README.md | 4 +--- doc/self-hosting.md | 4 ++-- package.json | 9 ++++----- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 1a0dba19f6..fa887f207e 100644 --- a/README.md +++ b/README.md @@ -117,9 +117,7 @@ Development ----------- 1. Install Node 8 or later. You can use the [package manager][] of your choice. - Node 8 is required for building or developing the front end. Node 6 or 8 will - work to run the server, and we'll transition to Node 8 everywhere once the - production server is upgraded. Server tests need to pass in both. + Tests need to pass in Node 8 and 9. 2. Clone this repository. 3. Run `npm install` to install the dependencies. 4. Run `npm run build` to build the frontend. diff --git a/doc/self-hosting.md b/doc/self-hosting.md index c910e4bae0..b277aa863c 100644 --- a/doc/self-hosting.md +++ b/doc/self-hosting.md @@ -4,13 +4,13 @@ Hosting your own Shields server Installation ------------ -You will need version 6 of Node.js, which you can install using a +You will need Node 8 or later, which you can install using a [package manager][]. On Ubuntu / Debian: ```sh -curl -sL https://deb.nodesource.com/setup_6.x | sudo -E bash -; sudo apt-get install -y nodejs +curl -sL https://deb.nodesource.com/setup_8.x | sudo -E bash -; sudo apt-get install -y nodejs ``` ```sh diff --git a/package.json b/package.json index 108a04a245..ee489d4f7b 100644 --- a/package.json +++ b/package.json @@ -63,16 +63,15 @@ "test": "npm run lint && npm run test:js:frontend && npm run test:js:server", "circle-images:build": "docker build -t shieldsio/shields-ci-node-8:${IMAGE_TAG} -f .circleci/images/node-8/Dockerfile . && docker build -t shieldsio/shields-ci-node-9:${IMAGE_TAG} -f .circleci/images/node-9/Dockerfile .", "circle-images:push": "docker push shieldsio/shields-ci-node-8:${IMAGE_TAG} && docker push shieldsio/shields-ci-node-9:${IMAGE_TAG}", - "frontend-depcheck": "check-node-version --node \">= 8.0\"", - "server-depcheck": "check-node-version --node \">= 6.0 < 9.0\"", - "postinstall": "npm run server-depcheck", - "prebuild": "npm run frontend-depcheck", + "depcheck": "check-node-version --node \">= 8.0\"", + "postinstall": "npm run depcheck", + "prebuild": "npm run depcheck", "build": "next build && next export -o build/", "heroku-postbuild": "npm run build", "analyze": "ANALYZE=true LONG_CACHE=false BASE_URL=https://img.shields.io npm run build", "start:server": "RATE_LIMIT=false node server 8080 ::", "now-start": "node server", - "prestart": "npm run frontend-depcheck", + "prestart": "npm run depcheck", "start": "concurrently --names server,frontend \"ALLOWED_ORIGIN=http://localhost:3000 npm run start:server\" \"BASE_URL=http://[::]:8080 next dev\"" }, "bin": {