Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) (#2037)

lib/error-helper.js

@@ -50,18 +50,6 @@ checkErrorResponse.asPromise = function(errorMessages = {}) {
   }
 }
 
-async function asJson({ buffer, res }) {
-  try {
-    return JSON.parse(buffer)
-  } catch (err) {
-    throw new InvalidResponse({
-      prettyMessage: 'unparseable json response',
-      underlyingError: err,
-    })
-  }
-}
-
 module.exports = {
   checkErrorResponse,
-  asJson,
 }