ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

Clean up our callback style and enforce no exclusive tests and remove an exclusive test (#1900)

Browse Source 
We use arrow functions in most places; this enforces it.

Passing arrow functions to Mocha is discouraged: https://mochajs.org/#arrow-functions

This was a mix of autofixes and hand adjustments.
This commit is contained in:
Paul Melnikow
2018-08-12 20:45:43 -04:00
committed by GitHub
parent 0a7c833452
commit 66d444aa40
35 changed files with 185 additions and 192 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
services/gem/gem-downloads.service.js
View File

@@ -77,22 +77,14 @@ module.exports = class GemDownloads extends BaseJsonService {
let versionData
if (version !== null && version === 'stable') {
const versions = json
.filter(function(ver) {
return ver.prerelease === false
})
.map(function(ver) {
return ver.number
})
.filter(ver => ver.prerelease === false)
.map(ver => ver.number)
// Found latest stable version.
const stableVersion = latestVersion(versions)
versionData = json.filter(function(ver) {
return ver.number === stableVersion
})[0]
versionData = json.filter(ver => ver.number === stableVersion)[0]
downloads = versionData.downloads_count
} else if (version !== null) {
versionData = json.filter(function(ver) {
return ver.number === version
})[0]
versionData = json.filter(ver => ver.number === version)[0]
downloads = versionData.downloads_count
} else {