Stop calling variables "which"; affects [chocolatey codeclimate conda crates debug gem github mozillaobservatory nuget powershellgallery pub resharper vaadindirectory] (#3495)

* which --> variant

* which --> alias

* which --> format

* improve param names in codeclimate

* improve param names in github-issue-detail

* update github-issue-detail unit tests
This commit is contained in:
chris48s
2019-05-28 23:00:12 +01:00
committed by GitHub
parent 52e90af310
commit 65dba94fa8
25 changed files with 175 additions and 175 deletions

View File

@@ -18,7 +18,7 @@ module.exports = class PubVersion extends BaseJsonService {
static get route() {
return {
base: 'pub',
pattern: ':which(v|vpre)/:packageName',
pattern: ':variant(v|vpre)/:packageName',
}
}
@@ -52,9 +52,9 @@ module.exports = class PubVersion extends BaseJsonService {
})
}
async handle({ which, packageName }) {
async handle({ variant, packageName }) {
const data = await this.fetch({ packageName })
const includePre = which === 'vpre'
const includePre = variant === 'vpre'
const versions = data.versions
const version = latest(versions, { pre: includePre })
return renderVersionBadge({ version })