From 4f411755da21f84ab0cb2dd1a7c40709654a135d Mon Sep 17 00:00:00 2001 From: Paul Melnikow Date: Tue, 5 Mar 2019 22:23:20 -0500 Subject: [PATCH] Add a stats category for static badges (#3168) Right now they're showing up in "other," though I expect they make up most of that category. https://github.com/badges/shields/issues/966#issuecomment-469851361 --- core/base-service/categories.js | 2 +- services/static-badge/query-string-static.service.js | 2 +- services/static-badge/static-badge.service.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/base-service/categories.js b/core/base-service/categories.js index 36caaa6c91..760590ced4 100644 --- a/core/base-service/categories.js +++ b/core/base-service/categories.js @@ -6,7 +6,7 @@ const categories = require('../../services/categories') const isRealCategory = Joi.equal(categories.map(({ id }) => id)).required() const isValidCategory = Joi.alternatives() - .try(isRealCategory, Joi.equal('debug', 'dynamic').required()) + .try(isRealCategory, Joi.equal('debug', 'dynamic', 'static').required()) .required() function assertValidCategory(category, message = undefined) { diff --git a/services/static-badge/query-string-static.service.js b/services/static-badge/query-string-static.service.js index 635fb59f3f..a17eaf915d 100644 --- a/services/static-badge/query-string-static.service.js +++ b/services/static-badge/query-string-static.service.js @@ -9,7 +9,7 @@ const queryParamSchema = Joi.object({ module.exports = class QueryStringStaticBadge extends BaseStaticService { static get category() { - return 'other' + return 'static' } static get route() { diff --git a/services/static-badge/static-badge.service.js b/services/static-badge/static-badge.service.js index 1a86808d38..85f2710328 100644 --- a/services/static-badge/static-badge.service.js +++ b/services/static-badge/static-badge.service.js @@ -5,7 +5,7 @@ const { escapeFormat } = require('../../core/badge-urls/path-helpers') module.exports = class StaticBadge extends BaseStaticService { static get category() { - return 'other' + return 'static' } static get route() {