Made tests use isBuildStatus validator from build-status.js (#2762)

services/appveyor/appveyor-ci.tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const Joi = require('joi')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = require('../create-service-tester')())
 

services/azure-devops/azure-devops-build.tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const Joi = require('joi')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 // https://dev.azure.com/totodem/Shields.io is a public Azure DevOps project
 // solely created for Shields.io testing.

services/azure-devops/azure-devops-release.tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const Joi = require('joi')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 // https://dev.azure.com/totodem/Shields.io is a public Azure DevOps project
 // solely created for Shields.io testing.

services/bitbucket/bitbucket.tester.js

@@ -9,11 +9,8 @@ const {
   user,
   pass,
 } = require('./bitbucket-test-helpers')
-const {
+const { isMetric, isMetricOpenIssues } = require('../test-validators')
-  isBuildStatus,
+const { isBuildStatus } = require('../../lib/build-status')
-  isMetric,
-  isMetricOpenIssues,
-} = require('../test-validators')
 
 const t = (module.exports = new ServiceTester({
   id: 'bitbucket',

services/buildkite/buildkite.tester.js

@@ -3,7 +3,7 @@
 const Joi = require('joi')
 const ServiceTester = require('../service-tester')
 const { invalidJSON } = require('../response-fixtures')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = new ServiceTester({
   id: 'buildkite',

services/circleci/circleci.tester.js

@@ -2,7 +2,7 @@
 
 const Joi = require('joi')
 const ServiceTester = require('../service-tester')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = new ServiceTester({
   id: 'circleci',

services/codeship/codeship.tester.js

@@ -2,7 +2,7 @@
 
 const Joi = require('joi')
 const ServiceTester = require('../service-tester')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = new ServiceTester({
   id: 'codeship',

services/continuousphp/continuousphp.tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const Joi = require('joi')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = require('../create-service-tester')())
 

services/docker/docker-build.tester.js

@@ -3,7 +3,7 @@
 const Joi = require('joi')
 const { colorScheme: colorsB } = require('../test-helpers')
 const { dockerBlue } = require('./docker-helpers')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = require('../create-service-tester')())
 

services/readthedocs/readthedocs.tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const Joi = require('joi')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = require('../create-service-tester')())
 

services/scrutinizer/scrutinizer.tester.js

@@ -2,7 +2,8 @@
 
 const Joi = require('joi')
 const ServiceTester = require('../service-tester')
-const { isBuildStatus, isIntegerPercentage } = require('../test-validators')
+const { isIntegerPercentage } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 const { colorScheme } = require('../test-helpers')
 
 const t = new ServiceTester({ id: 'scrutinizer', title: 'Scrutinizer' })

services/shippable/shippable.tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const Joi = require('joi')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = require('../create-service-tester')())
 

services/test-validators.js

@@ -91,31 +91,6 @@ const isDependencyState = withRegex(
   /^(\d+ out of date|\d+ deprecated|up to date)$/
 )
 
-const isBuildStatus = Joi.equal(
-  'building',
-  'cancelled',
-  'error',
-  'expired',
-  'failed',
-  'failing',
-  'no tests',
-  'not built',
-  'not run',
-  'passed',
-  'passing',
-  'pending',
-  'processing',
-  'queued',
-  'running',
-  'scheduled',
-  'skipped',
-  'stopped',
-  'success',
-  'timeout',
-  'unstable',
-  'waiting'
-)
-
 module.exports = {
   isSemver,
   isVPlusTripleDottedVersion,
@@ -135,6 +110,5 @@ module.exports = {
   isFormattedDate,
   isRelativeFormattedDate,
   isDependencyState,
-  isBuildStatus,
   withRegex,
 }

services/travis/travis-build.tester.js

@@ -2,7 +2,7 @@
 
 const Joi = require('joi')
 const ServiceTester = require('../service-tester')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 
 const t = (module.exports = new ServiceTester({
   id: 'travis-build',

services/wercker/wercker.tester.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const Joi = require('joi')
-const { isBuildStatus } = require('../test-validators')
+const { isBuildStatus } = require('../../lib/build-status')
 const { colorScheme } = require('../test-helpers')
 
 const t = (module.exports = require('../create-service-tester')())