From 1f928281f2eff311dbbb72072a13432c34419f33 Mon Sep 17 00:00:00 2001
From: chris48s <chris48s@users.noreply.github.com>
Date: Wed, 13 Jun 2018 21:03:42 +0100
Subject: [PATCH] allow 0 in all [cocoapods] download tests (#1728)

It appears this does not only
happen on the weekly stats.
refs https://github.com/badges/shields/pull/1713
---
 services/cocoapods/cocoapods.tester.js | 25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)

diff --git a/services/cocoapods/cocoapods.tester.js b/services/cocoapods/cocoapods.tester.js
index 92477c8b33..c09676c8a7 100644
--- a/services/cocoapods/cocoapods.tester.js
+++ b/services/cocoapods/cocoapods.tester.js
@@ -4,14 +4,21 @@ const Joi = require('joi');
 const ServiceTester = require('../service-tester');
 
 const {
-    isMetric,
-    isMetricOverTimePeriod,
     isIntegerPercentage,
     isVPlusDottedVersionAtLeastOne,
 } = require('../test-validators');
 
 const isPlatform = Joi.string().regex(/^(osx|ios|tvos|watchos)( \| (osx|ios|tvos|watchos))*$/);
 
+// these are deliberately not isMetricOverTimePeriod due to
+// https://github.com/CocoaPods/cocoapods.org/issues/348
+const isMetricOverTimePeriodAllowZero = Joi
+  .string()
+  .regex(/^(0|[1-9][0-9]*)[kMGTPEZY]?\/(year|month|4 weeks|week|day)$/);
+const isMetricAllowZero = Joi
+  .string()
+  .regex(/^(0|[1-9][0-9]*)[kMGTPEZY]?$/);
+
 const t = new ServiceTester({ id: 'cocoapods', title: 'Cocoa Pods' });
 module.exports = t;
 
@@ -135,23 +142,21 @@ t.create('downloads (valid, monthly)')
   .get('/dm/AFNetworking.json')
   .expectJSONTypes(Joi.object().keys({
     name: 'downloads',
-    value: isMetricOverTimePeriod
+    value: isMetricOverTimePeriodAllowZero
   }));
 
 t.create('downloads (valid, weekly)')
   .get('/dw/AFNetworking.json')
   .expectJSONTypes(Joi.object().keys({
     name: 'downloads',
-    // this is deliberately not isMetricOverTimePeriod due to
-    // https://github.com/CocoaPods/cocoapods.org/issues/348
-    value: Joi.string().regex(/^(0|[1-9][0-9]*)[kMGTPEZY]?\/week$/)
+    value: isMetricOverTimePeriodAllowZero
   }));
 
 t.create('downloads (valid, total)')
   .get('/dt/AFNetworking.json')
   .expectJSONTypes(Joi.object().keys({
     name: 'downloads',
-    value: isMetric
+    value: isMetricAllowZero
   }));
 
 t.create('downloads (not found)')
@@ -178,16 +183,14 @@ t.create('apps (valid, weekly)')
   .get('/aw/AFNetworking.json')
   .expectJSONTypes(Joi.object().keys({
     name: 'apps',
-    // this is deliberately not isMetricOverTimePeriod due to
-    // https://github.com/CocoaPods/cocoapods.org/issues/348
-    value: Joi.string().regex(/^(0|[1-9][0-9]*)[kMGTPEZY]?\/week$/)
+    value: isMetricOverTimePeriodAllowZero
   }));
 
 t.create('apps (valid, total)')
   .get('/at/AFNetworking.json')
   .expectJSONTypes(Joi.object().keys({
     name: 'apps',
-    value: isMetric
+    value: isMetricAllowZero
   }));
 
 t.create('apps (not found)')