Migrated most service tests to use new expectBadge (#3122)

services/github/github-commit-activity.tester.js

@@ -1,48 +1,39 @@
 'use strict'
 
-const Joi = require('joi')
 const { isMetricOverTimePeriod } = require('../test-validators')
 const t = (module.exports = require('../tester').createServiceTester())
 
 t.create('commit activity (1 year)')
   .get('/y/eslint/eslint.json')
-  .expectJSONTypes(
-    Joi.object().keys({
-      name: 'commit activity',
-      value: isMetricOverTimePeriod,
-    })
-  )
+  .expectBadge({
+    label: 'commit activity',
+    message: isMetricOverTimePeriod,
+  })
 
 t.create('commit activity (1 month)')
   .get('/m/eslint/eslint.json')
-  .expectJSONTypes(
-    Joi.object().keys({
-      name: 'commit activity',
-      value: isMetricOverTimePeriod,
-    })
-  )
+  .expectBadge({
+    label: 'commit activity',
+    message: isMetricOverTimePeriod,
+  })
 
 t.create('commit activity (4 weeks)')
   .get('/4w/eslint/eslint.json')
-  .expectJSONTypes(
-    Joi.object().keys({
-      name: 'commit activity',
-      value: isMetricOverTimePeriod,
-    })
-  )
+  .expectBadge({
+    label: 'commit activity',
+    message: isMetricOverTimePeriod,
+  })
 
 t.create('commit activity (1 week)')
   .get('/w/eslint/eslint.json')
-  .expectJSONTypes(
-    Joi.object().keys({
-      name: 'commit activity',
-      value: isMetricOverTimePeriod,
-    })
-  )
+  .expectBadge({
+    label: 'commit activity',
+    message: isMetricOverTimePeriod,
+  })
 
 t.create('commit activity (repo not found)')
   .get('/w/badges/helmets.json')
-  .expectJSON({
-    name: 'commit activity',
-    value: 'repo not found',
+  .expectBadge({
+    label: 'commit activity',
+    message: 'repo not found',
   })