ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

Update uri -> url in the front end + examples (#2006)

Browse Source 
This continues a consistency update we’ve been making to standardize on URL based on a recommendation from WHATWG: https://url.spec.whatwg.org/#goals

This also helps with copying and pasting between all-badge-examples and new-style services, where it’s otherwise easy to make a mistake.

Ref: #1322 #1341
This commit is contained in:
Paul Melnikow
2018-08-29 14:27:50 -07:00
committed by GitHub
parent 33fbfb374f
commit 1deeb365a5
17 changed files with 424 additions and 423 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
frontend/lib/generate-image-markup.js
View File

@@ -1,5 +1,5 @@
export function markdown(badgeUri, link, title) {
const withoutLink = `![${title || ''}](${badgeUri})`
export function markdown(badgeUrl, link, title) {
const withoutLink = `![${title || ''}](${badgeUrl})`
if (link) {
return `[${withoutLink}](${link})`
} else {
@@ -7,8 +7,8 @@ export function markdown(badgeUri, link, title) {
}
}
export function reStructuredText(badgeUri, link, title) {
let result = `.. image:: ${badgeUri}`
export function reStructuredText(badgeUrl, link, title) {
let result = `.. image:: ${badgeUrl}`
if (title) {
result += ` :alt: ${title}`
}
@@ -59,17 +59,17 @@ export function renderAsciiDocAttributes(positional, named) {
}
}
export function asciiDoc(badgeUri, link, title) {
export function asciiDoc(badgeUrl, link, title) {
const positional = title ? [title] : []
const named = link ? { link } : {}
const attrs = renderAsciiDocAttributes(positional, named)
return `image:${badgeUri}${attrs}`
return `image:${badgeUrl}${attrs}`
}
export default function generateAllMarkup(badgeUri, link, title) {
export default function generateAllMarkup(badgeUrl, link, title) {
// This is a wee bit "clever". It runs each of the three functions on the
// parameters provided, and returns the result in an object.
return mapValues({ markdown, reStructuredText, asciiDoc }, fn =>
fn(badgeUri, link, title)
fn(badgeUrl, link, title)
)
}