From 1027c296ee3433d8ef4c83563360bcb56167368c Mon Sep 17 00:00:00 2001
From: Caleb Cartwright <calebcartwright@users.noreply.github.com>
Date: Tue, 8 Sep 2020 16:45:46 -0500
Subject: [PATCH] convert some service classes to static props, run [bower
 bstats]  (#5503)

* refactor(bower): convert to static props

* refactor(bstats): convert to static props

Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
---
 services/bower/bower-license.service.js   | 32 +++++-----------
 services/bower/bower-version.service.js   | 45 ++++++++---------------
 services/bstats/bstats-players.service.js | 37 ++++++-------------
 services/bstats/bstats-servers.service.js | 37 ++++++-------------
 4 files changed, 48 insertions(+), 103 deletions(-)

diff --git a/services/bower/bower-license.service.js b/services/bower/bower-license.service.js
index e82e388704..2c454ba11f 100644
--- a/services/bower/bower-license.service.js
+++ b/services/bower/bower-license.service.js
@@ -4,30 +4,18 @@ const { renderLicenseBadge } = require('../licenses')
 const BaseBowerService = require('./bower-base')
 
 module.exports = class BowerLicense extends BaseBowerService {
-  static get category() {
-    return 'license'
-  }
+  static category = 'license'
+  static route = { base: 'bower/l', pattern: ':packageName' }
 
-  static get route() {
-    return {
-      base: 'bower/l',
-      pattern: ':packageName',
-    }
-  }
+  static examples = [
+    {
+      title: 'Bower',
+      namedParams: { packageName: 'bootstrap' },
+      staticPreview: renderLicenseBadge({ licenses: ['MIT'] }),
+    },
+  ]
 
-  static get examples() {
-    return [
-      {
-        title: 'Bower',
-        namedParams: { packageName: 'bootstrap' },
-        staticPreview: renderLicenseBadge({ licenses: ['MIT'] }),
-      },
-    ]
-  }
-
-  static get defaultBadgeData() {
-    return { label: 'license' }
-  }
+  static defaultBadgeData = { label: 'license' }
 
   async handle({ packageName }) {
     const data = await this.fetch({ packageName })
diff --git a/services/bower/bower-version.service.js b/services/bower/bower-version.service.js
index 77b304b481..d4c8672a4f 100644
--- a/services/bower/bower-version.service.js
+++ b/services/bower/bower-version.service.js
@@ -10,37 +10,24 @@ const queryParamSchema = Joi.object({
 }).required()
 
 class BowerVersion extends BaseBowerService {
-  static get category() {
-    return 'version'
-  }
+  static category = 'version'
+  static route = { base: 'bower/v', pattern: ':packageName', queryParamSchema }
 
-  static get route() {
-    return {
-      base: 'bower/v',
-      pattern: ':packageName',
-      queryParamSchema,
-    }
-  }
+  static examples = [
+    {
+      title: 'Bower Version',
+      namedParams: { packageName: 'bootstrap' },
+      staticPreview: renderVersionBadge({ version: '4.2.1' }),
+    },
+    {
+      title: 'Bower Version (including pre-releases)',
+      namedParams: { packageName: 'bootstrap' },
+      queryParams: { include_prereleases: null },
+      staticPreview: renderVersionBadge({ version: '4.2.1' }),
+    },
+  ]
 
-  static get examples() {
-    return [
-      {
-        title: 'Bower Version',
-        namedParams: { packageName: 'bootstrap' },
-        staticPreview: renderVersionBadge({ version: '4.2.1' }),
-      },
-      {
-        title: 'Bower Version (including pre-releases)',
-        namedParams: { packageName: 'bootstrap' },
-        queryParams: { include_prereleases: null },
-        staticPreview: renderVersionBadge({ version: '4.2.1' }),
-      },
-    ]
-  }
-
-  static get defaultBadgeData() {
-    return { label: 'bower' }
-  }
+  static defaultBadgeData = { label: 'bower' }
 
   async handle({ packageName }, queryParams) {
     const data = await this.fetch({ packageName })
diff --git a/services/bstats/bstats-players.service.js b/services/bstats/bstats-players.service.js
index 0caf2ab2b2..462159e4b3 100644
--- a/services/bstats/bstats-players.service.js
+++ b/services/bstats/bstats-players.service.js
@@ -9,35 +9,20 @@ const schema = Joi.array()
   .required()
 
 module.exports = class BStatsPlayers extends BaseJsonService {
-  static get category() {
-    return 'other'
-  }
+  static category = 'other'
+  static route = { base: 'bstats/players', pattern: ':pluginid' }
 
-  static get route() {
-    return {
-      base: 'bstats/players',
-      pattern: ':pluginid',
-    }
-  }
-
-  static get examples() {
-    return [
-      {
-        title: 'bStats Players',
-        namedParams: {
-          pluginid: '1',
-        },
-        staticPreview: this.render({ players: 74299 }),
+  static examples = [
+    {
+      title: 'bStats Players',
+      namedParams: {
+        pluginid: '1',
       },
-    ]
-  }
+      staticPreview: this.render({ players: 74299 }),
+    },
+  ]
 
-  static get defaultBadgeData() {
-    return {
-      label: 'players',
-      color: 'blue',
-    }
-  }
+  static defaultBadgeData = { label: 'players', color: 'blue' }
 
   static render({ players }) {
     return {
diff --git a/services/bstats/bstats-servers.service.js b/services/bstats/bstats-servers.service.js
index a3ae2f3e30..2ddbb794fe 100644
--- a/services/bstats/bstats-servers.service.js
+++ b/services/bstats/bstats-servers.service.js
@@ -9,35 +9,20 @@ const schema = Joi.array()
   .required()
 
 module.exports = class BStatsServers extends BaseJsonService {
-  static get category() {
-    return 'other'
-  }
+  static category = 'other'
+  static route = { base: 'bstats/servers', pattern: ':pluginid' }
 
-  static get route() {
-    return {
-      base: 'bstats/servers',
-      pattern: ':pluginid',
-    }
-  }
-
-  static get examples() {
-    return [
-      {
-        title: 'bStats Servers',
-        namedParams: {
-          pluginid: '1',
-        },
-        staticPreview: this.render({ servers: 57479 }),
+  static examples = [
+    {
+      title: 'bStats Servers',
+      namedParams: {
+        pluginid: '1',
       },
-    ]
-  }
+      staticPreview: this.render({ servers: 57479 }),
+    },
+  ]
 
-  static get defaultBadgeData() {
-    return {
-      label: 'servers',
-      color: 'blue',
-    }
-  }
+  static defaultBadgeData = { label: 'servers', color: 'blue' }
 
   static render({ servers }) {
     return {