ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

Bump nock from 11.0.0.beta-14 to 11.0.0.beta-20 (#3616)

Browse Source 
* Bump icedfrisby and icedfrisby-nock

* Bump nock from 11.0.0.beta-14 to 11.0.0.beta-20

Hoping the changes from #3615 will fix the issues that appeared at https://github.com/badges/shields/pull/3552#issuecomment-504610847

* Fix apm tests

* Fix githubcommitstatus
This commit is contained in:
Paul Melnikow
2019-06-28 15:50:17 -04:00
committed by GitHub
parent 6c21d86194
commit 0f19806c58
6 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
services/github/github-commit-status.service.js
View File

@@ -74,7 +74,7 @@ module.exports = class GithubCommitStatus extends GithubAuthService {
} catch (e) {
if (e instanceof NotFound) {
const { message } = this._parseJson(e.buffer)
if (message.startsWith('No common ancestor between')) {
if (message && message.startsWith('No common ancestor between')) {
throw new InvalidParameter({ prettyMessage: 'no common ancestor' })
}
}