From 0d463b42e5c57da006e6f17c62439945e59d706f Mon Sep 17 00:00:00 2001 From: danielle <185722+danielle@users.noreply.github.com> Date: Tue, 26 Jan 2021 22:08:08 -0600 Subject: [PATCH] =?UTF-8?q?[Bitbucket]=20Server=20Adding=20Auth=20Tokens?= =?UTF-8?q?=20and=20Resolving=20Pull=20Request=20api=20=E2=80=A6=20(#6076)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [Bitbucket Server] Adding Auth Tokens and Resolving Pull Request api issue. Added the bitbucket_server_username & bitbucket_server_password variables to the /core/server/server.js file. Also changed the user variable in the /services/bitbucket/bitbucket/bitbucket-pull-request.service.js the api documentation (https://docs.atlassian.com/bitbucket-server/rest/5.16.0/bitbucket-rest.html#idm8287391664) defines the parameter as requiring the project name that the repository is contained in not the user name. * [Bitbucket Server] Adding Auth Tokens and Resolving Pull Request api issue. Added the bitbucket_server_username & bitbucket_server_password variables to the /core/server/server.js file. Also changed the user variable in the /services/bitbucket/bitbucket/bitbucket-pull-request.service.js the api documentation (https://docs.atlassian.com/bitbucket-server/rest/5.16.0/bitbucket-rest.html#idm8287391664) defines the parameter as requiring the project name that the repository is contained in not the user name. * Update bitbucket-pull-request.service.js Updating the label as Bitbucket and Bitbucket Server have different parameters in the Api call. Changing to compound name per @calebcartwright recomendation. * Update server.js Removing code that was refactored and caught in my Pull Request * Reversing commit back on bitbucket-pull-request.service.js to its previous state. Co-authored-by: danielle <185722+danielle@users.noreply.github.com> Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com> --- core/server/server.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/core/server/server.js b/core/server/server.js index 09a48fb5ed..9737e16ed3 100644 --- a/core/server/server.js +++ b/core/server/server.js @@ -162,6 +162,8 @@ const privateConfigSchema = Joi.object({ jenkins_pass: Joi.string(), jira_user: Joi.string(), jira_pass: Joi.string(), + bitbucket_server_username: Joi.string(), + bitbucket_server_password: Joi.string(), nexus_user: Joi.string(), nexus_pass: Joi.string(), npm_token: Joi.string(),