Unify remaining service order and enforce (#3359)

Ref #3353

services/bstats/bstats-players.service.js

@@ -9,6 +9,10 @@ const schema = Joi.array()
   .required()
 
 module.exports = class BStatsPlayers extends BaseJsonService {
+  static get category() {
+    return 'other'
+  }
+
   static get route() {
     return {
       base: 'bstats/players',
@@ -16,6 +20,18 @@ module.exports = class BStatsPlayers extends BaseJsonService {
     }
   }
 
+  static get examples() {
+    return [
+      {
+        title: 'bStats Players',
+        namedParams: {
+          pluginid: '1',
+        },
+        staticPreview: this.render({ players: 74299 }),
+      },
+    ]
+  }
+
   static get defaultBadgeData() {
     return {
       label: 'players',
@@ -23,15 +39,10 @@ module.exports = class BStatsPlayers extends BaseJsonService {
     }
   }
 
-  async handle({ pluginid }) {
-    const json = await this.fetch({ pluginid })
-    const { players } = this.transform({ json })
-    return this.constructor.render({ players })
-  }
-
-  transform({ json }) {
-    const players = json[0][1]
-    return { players }
+  static render({ players }) {
+    return {
+      message: metric(players),
+    }
   }
 
   async fetch({ pluginid }) {
@@ -48,24 +59,14 @@ module.exports = class BStatsPlayers extends BaseJsonService {
     })
   }
 
-  static render({ players }) {
-    return {
-      message: metric(players),
-    }
+  transform({ json }) {
+    const players = json[0][1]
+    return { players }
   }
 
-  static get category() {
-    return 'other'
-  }
-  static get examples() {
-    return [
-      {
-        title: 'bStats Players',
-        namedParams: {
-          pluginid: '1',
-        },
-        staticPreview: this.render({ players: 74299 }),
-      },
-    ]
+  async handle({ pluginid }) {
+    const json = await this.fetch({ pluginid })
+    const { players } = this.transform({ json })
+    return this.constructor.render({ players })
   }
 }

services/bstats/bstats-servers.service.js

@@ -9,6 +9,10 @@ const schema = Joi.array()
   .required()
 
 module.exports = class BStatsServers extends BaseJsonService {
+  static get category() {
+    return 'other'
+  }
+
   static get route() {
     return {
       base: 'bstats/servers',
@@ -16,6 +20,18 @@ module.exports = class BStatsServers extends BaseJsonService {
     }
   }
 
+  static get examples() {
+    return [
+      {
+        title: 'bStats Servers',
+        namedParams: {
+          pluginid: '1',
+        },
+        staticPreview: this.render({ servers: 57479 }),
+      },
+    ]
+  }
+
   static get defaultBadgeData() {
     return {
       label: 'servers',
@@ -23,15 +39,10 @@ module.exports = class BStatsServers extends BaseJsonService {
     }
   }
 
-  async handle({ pluginid }) {
-    const json = await this.fetch({ pluginid })
-    const { servers } = this.transform({ json })
-    return this.constructor.render({ servers })
-  }
-
-  transform({ json }) {
-    const servers = json[0][1]
-    return { servers }
+  static render({ servers }) {
+    return {
+      message: metric(servers),
+    }
   }
 
   async fetch({ pluginid }) {
@@ -48,24 +59,14 @@ module.exports = class BStatsServers extends BaseJsonService {
     })
   }
 
-  static render({ servers }) {
-    return {
-      message: metric(servers),
-    }
+  transform({ json }) {
+    const servers = json[0][1]
+    return { servers }
   }
 
-  static get category() {
-    return 'other'
-  }
-  static get examples() {
-    return [
-      {
-        title: 'bStats Servers',
-        namedParams: {
-          pluginid: '1',
-        },
-        staticPreview: this.render({ servers: 57479 }),
-      },
-    ]
+  async handle({ pluginid }) {
+    const json = await this.fetch({ pluginid })
+    const { servers } = this.transform({ json })
+    return this.constructor.render({ servers })
   }
 }