ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
Files
f326d45135c79545cf9dcca89fdb504887ba42f8
bind9/lib/dns
History
Ondřej Surý f326d45135 Lock view while accessing its zone table 
Commit 308bc46a59 introduced a change to
the view_flushanddetach() function which makes the latter access
view->zonetable without holding view->lock.  As confirmed by TSAN, this
enables races between threads for view->zonetable accesses.

Swap the view->zonetable pointer under view lock and then detach the
local swapped dns_zt_t later when the view lock is already unlocked.

This commit also changes the dns_zt interfaces, so the setting the
zonetable "flush" flag is separate operation to dns_zt_detach,
e.g. instead of doing:

    if (view->flush) {
        dns_zt_flushanddetach(&zt);
    } else {
        dns_zt_detach(&zt);
    }

the code is now:

    if (view->flush) {
        dns_zt_flush(zt);
    }
    dns_zt_detach(&zt);

making the code more consistent with how we handle flushing and
detaching dns_zone_t pointers from the view.
2022-01-05 16:56:16 +01:00
..
include
Lock view while accessing its zone table
2022-01-05 16:56:16 +01:00
rdata
Drop cppcheck workarounds
2021-12-14 15:03:56 +01:00
tests
Add comparekeys to release tarball
2021-11-01 15:17:31 +01:00
.gitignore
…
acl.c
Integrate extended ACLs syntax featuring 'port' and 'transport' opts
2021-11-30 12:20:22 +02:00
adb.c
Fix the data race when shutting down dns_adb
2021-11-22 11:09:21 +01:00
badcache.c
The isc/platform.h header has been completely removed
2021-07-06 05:33:48 +00:00
byaddr.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
cache.c
Record how often DNS_R_COVERINGNSEC is returned from the cache
2021-12-02 14:18:41 +01:00
callbacks.c
…
catz.c
Prevent existing catalog zone entries being incorrectly deleted
2021-10-15 04:31:37 +00:00
client.c
remove all references to isc_socket and related types
2021-10-15 01:01:25 -07:00
clientinfo.c
…
compress.c
Stop providing branch prediction information
2021-10-14 10:33:24 +02:00
db.c
Extend dns_db_nodecount to access auxilary rbt node counts
2021-12-02 14:18:41 +01:00
dbiterator.c
…
diff.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
dispatch.c
incidental cleanups
2021-12-08 10:22:03 -08:00
dlz.c
dns/ssu.c: Return void when ISC_R_SUCCESS is only returned value
2021-10-13 05:47:48 +02:00
dns64.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
dnsrps.c
dns/rbt.c: Implement incremental hash table resizing
2021-10-12 15:01:53 +02:00
dnssec.c
Fix cleanup of signature buffer in dns_dnssec_signmessage
2021-10-12 09:56:44 +11:00
dnstap.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
dnstap.proto
…
ds.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
dst_api.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
dst_internal.h
Remove native PKCS#11 support
2021-09-09 15:35:39 +02:00
dst_openssl.h
The OpenSSL engine API is deprecated in OpenSSL 3.0.0
2021-10-28 07:39:37 +00:00
dst_parse.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
dst_parse.h
Use #pragma once as header guards
2021-10-13 00:49:15 -07:00
dyndb.c
…
ecs.c
…
fixedname.c
…
forward.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
gen.c
Error out if gen finds a type or class that is greater than 65535
2021-10-25 21:33:35 +00:00
gen.h
Use #pragma once as header guards
2021-10-13 00:49:15 -07:00
geoip2.c
Completely remove BIND 9 Windows support
2021-06-09 14:35:14 +02:00
gssapi_link.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
gssapictx.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
hmac_link.c
Pass the digest buffer length to EVP_DigestSignFinal
2021-12-17 20:28:01 +11:00
ipkeylist.c
…
iptable.c
…
journal.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
kasp.c
…
key.c
…
keydata.c
…
keymgr.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
keytable.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
log.c
Remove LIB<*>_EXTERNAL_DATA defines
2021-07-06 05:33:48 +00:00
lookup.c
dns/lookup.c: Return void when ISC_R_SUCCESS is only returned value
2021-10-13 05:47:48 +02:00
Makefile.am
Use ERR_get_error_all() instead of deprecated ERR_get_error_line_data()
2021-10-28 07:38:56 +00:00
master.c
Replace "master/slave" terms in code
2021-10-12 13:11:13 -07:00
masterdump.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
message.c
Reduce freemax values for dns_message mempools
2021-12-15 21:25:00 +01:00
name.c
Stop providing branch prediction information
2021-10-14 10:33:24 +02:00
ncache.c
…
nsec3.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
nsec.c
Ignore NSEC records without RRSIG and NSEC present
2021-12-02 14:18:42 +01:00
nta.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
openssl_link.c
The OpenSSL engine API is deprecated in OpenSSL 3.0.0
2021-10-28 07:39:37 +00:00
openssl_shim.c
Use the special shims file for DH shims
2021-10-28 07:39:37 +00:00
openssl_shim.h
Use the special shims file for DH shims
2021-10-28 07:39:37 +00:00
openssldh_link.c
Address potential memory leak in openssldh_parse()
2021-11-01 21:50:47 +00:00
opensslecdsa_link.c
Reject too long ECDSA public keys
2021-11-23 08:44:47 +11:00
openssleddsa_link.c
The OpenSSL engine API is deprecated in OpenSSL 3.0.0
2021-10-28 07:39:37 +00:00
opensslrsa_link.c
Silence Coverity false positive
2021-11-03 20:10:34 +11:00
order.c
…
peer.c
remove broken-nsec and reject-000-label options
2021-12-23 15:13:46 +11:00
private.c
…
rbt.c
Drop cppcheck workarounds
2021-12-14 15:03:56 +01:00
rbtdb.c
Look for covering NSEC under two more conditions
2021-12-02 14:24:37 +01:00
rbtdb.h
Use #pragma once as header guards
2021-10-13 00:49:15 -07:00
rcode.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
rdata.c
dns/rdata.c: Return void when ISC_R_SUCCESS is only returned value
2021-10-13 05:47:48 +02:00
rdatalist_p.h
Use #pragma once as header guards
2021-10-13 00:49:15 -07:00
rdatalist.c
…
rdataset.c
Stop providing branch prediction information
2021-10-14 10:33:24 +02:00
rdatasetiter.c
…
rdataslab.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
request.c
remove all references to isc_socket and related types
2021-10-15 01:01:25 -07:00
resolver.c
remove broken-nsec and reject-000-label options
2021-12-23 15:13:46 +11:00
result.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
rootns.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
rpz.c
Extend dns_db_nodecount to access auxilary rbt node counts
2021-12-02 14:18:41 +01:00
rriterator.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
rrl.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
sdb.c
Extend dns_db_nodecount to access auxilary rbt node counts
2021-12-02 14:18:41 +01:00
sdlz.c
Extend dns_db_nodecount to access auxilary rbt node counts
2021-12-02 14:18:41 +01:00
soa.c
…
ssu_external.c
Completely remove BIND 9 Windows support
2021-06-09 14:35:14 +02:00
ssu.c
Add {krb5,ms}-subdomain-self-rhs update policy rules
2021-10-15 11:18:41 +11:00
stats.c
Clear dnssec-sign stats for removed keys
2021-08-24 09:07:15 +02:00
time.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
timer.c
…
tkey.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
transport.c
Use the TLS context cache for client-side contexts (XoT)
2021-12-29 10:25:15 +02:00
tsec.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
tsig_p.h
Use #pragma once as header guards
2021-10-13 00:49:15 -07:00
tsig.c
Drop cppcheck workarounds
2021-12-14 15:03:56 +01:00
ttl.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
update.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
validator.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
view.c
Lock view while accessing its zone table
2022-01-05 16:56:16 +01:00
xfrin.c
Use the TLS context cache for client-side contexts (XoT)
2021-12-29 10:25:15 +02:00
zone_p.h
Use #pragma once as header guards
2021-10-13 00:49:15 -07:00
zone.c
Ensure the correct ordering zone_shutdown() vs zone_gotwritehandle()
2022-01-05 10:27:55 +01:00
zonekey.c
…
zoneverify.c
Make isc_result a static enum
2021-10-06 11:22:20 +02:00
zt.c
Lock view while accessing its zone table
2022-01-05 16:56:16 +01:00