ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
Files
edd0fe1dcaeccc8265fe1600653776a9acfb29a0
bind9/lib/dns
History
Mark Andrews edd0fe1dca Address race between zone_settimer and set_key_expiry_warning by 
adding missing lock.

    WARNING: ThreadSanitizer: data race
    Read of size 4 at 0x000000000001 by thread T1 (mutexes: read M1, write M2):
    #0 isc_time_isepoch lib/isc/unix/time.c:110
    #1 zone_settimer lib/dns/zone.c:14649
    #2 dns_zone_maintenance lib/dns/zone.c:6281
    #3 dns_zonemgr_forcemaint lib/dns/zone.c:18190
    #4 view_loaded server.c:9654
    #5 call_loaddone lib/dns/zt.c:301
    #6 doneloading lib/dns/zt.c:575
    #7 zone_asyncload lib/dns/zone.c:2259
    #8 task_run lib/isc/task.c:845
    #9 isc_task_run lib/isc/task.c:938
    #10 isc__nm_async_task lib/isc/netmgr/netmgr.c:855
    #11 process_netievent lib/isc/netmgr/netmgr.c:934
    #12 process_queue lib/isc/netmgr/netmgr.c:1003
    #13 process_all_queues lib/isc/netmgr/netmgr.c:775
    #14 async_cb lib/isc/netmgr/netmgr.c:804
    #15 <null> <null>
    #16 isc__trampoline_run lib/isc/trampoline.c:191
    #17 <null> <null>

    Previous write of size 4 at 0x000000000001 by thread T2:
    #0 isc_time_set lib/isc/unix/time.c:93
    #1 set_key_expiry_warning lib/dns/zone.c:6430
    #2 del_sigs lib/dns/zone.c:6711
    #3 zone_resigninc lib/dns/zone.c:7113
    #4 zone_maintenance lib/dns/zone.c:11111
    #5 zone_timer lib/dns/zone.c:14588
    #6 task_run lib/isc/task.c:845
    #7 isc_task_run lib/isc/task.c:938
    #8 isc__nm_async_task lib/isc/netmgr/netmgr.c:855
    #9 process_netievent lib/isc/netmgr/netmgr.c:934
    #10 process_queue lib/isc/netmgr/netmgr.c:1003
    #11 process_all_queues lib/isc/netmgr/netmgr.c:775
    #12 async_cb lib/isc/netmgr/netmgr.c:804
    #13 <null> <null>
    #14 isc__trampoline_run lib/isc/trampoline.c:191
    #15 <null> <null>

    SUMMARY: ThreadSanitizer: data race lib/isc/unix/time.c:110 in isc_time_isepoch

(cherry picked from commit 3d66e97a28)
2021-06-09 23:56:47 +10:00
..
include
Refactor zone dumping code to use netmgr async threadpools
2021-05-31 16:57:19 +02:00
rdata
Use isdigit instead of checking character range
2021-05-05 18:23:53 +02:00
tests
Adjust returned method from dns_updatemethod_date
2021-05-18 22:55:35 +10:00
win32
Refactor zone dumping code to use netmgr async threadpools
2021-05-31 16:57:19 +02:00
.gitignore
…
acl.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
adb.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
badcache.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
byaddr.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
cache.c
Check 'stale-refresh-time' when sharing cache between views
2020-11-11 16:06:23 -03:00
callbacks.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
catz.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
client.c
properly initialise resarg->lock
2021-04-19 14:32:53 +02:00
clientinfo.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
compress.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
db.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
dbiterator.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dbtable.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
diff.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dispatch.c
Silence cppcheck 2.2 false positive in udp_recv()
2020-11-25 13:21:58 +01:00
dlz.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
dns64.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dnsrps.c
Add stale-refresh-time option
2020-11-11 15:59:56 -03:00
dnssec.c
Use isdigit instead of checking character range
2021-05-05 18:23:53 +02:00
dnstap.c
Address theoretical resource leak in dns_dt_open()
2021-02-23 09:41:15 +11:00
dnstap.proto
…
ds.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_api.c
Address potential resource leak in dst_key_fromnamedfile
2021-05-18 11:42:48 +10:00
dst_internal.h
Fix handling undefined GSS_SPNEGO_MECHANISM macro
2021-04-16 14:40:06 +02:00
dst_openssl.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_parse.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_parse.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_pkcs11.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_result.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dyndb.c
hacks to get dyndb working without libtool
2021-05-14 12:52:48 +02:00
ecdb.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ecs.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
fixedname.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
forward.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
gen-unix.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
gen-win32.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
gen.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
geoip2.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
gssapi_link.c
Stop including <gssapi.h> from <dst/gssapi.h> header
2021-02-16 12:08:21 +11:00
gssapictx.c
Free resources when gss_accept_sec_context() fails
2021-04-08 10:41:08 +02:00
hmac_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ipkeylist.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
iptable.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
journal.c
Consolidate xhdr fixups
2021-05-26 08:49:30 +10:00
kasp.c
Add purge-keys config option
2021-02-23 09:18:55 +01:00
key.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
keydata.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
keymgr.c
Fix coverity issue 331478
2021-05-19 09:05:35 +02:00
keytable.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
Kyuafile
…
lib.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
log.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
lookup.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
Makefile.in
Remove custom ISC SPNEGO implementation
2021-04-01 10:42:32 +02:00
mapapi
…
master.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
masterdump.c
Pause the dbiterator when dumping the zone to the disk
2021-06-04 11:32:31 +02:00
message.c
use a fixedname buffer in dns_message_gettempname()
2021-05-22 07:13:57 +02:00
name.c
Use dns_name_copynf() with dns_message_gettempname() when needed
2021-05-22 07:17:01 +02:00
ncache.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
nsec3.c
Mark DNSSEC responses with NSEC3 records that exceed 150 as insecure
2021-04-30 11:16:45 +02:00
nsec.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
nta.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
openssl_link.c
Remove TLSDNS, TLS and HTTP protocols from netmgr
2021-05-14 12:52:48 +02:00
openssldh_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
opensslecdsa_link.c
Make opensslecdsa_parse use fromlabel
2021-01-26 15:04:59 +01:00
openssleddsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
opensslrsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
order.c
Allow "order none" in "rrset-order" rules
2020-10-02 08:50:51 +02:00
peer.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11ecdsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11eddsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11rsa_link.c
Fix misplaced declaration
2020-12-01 23:19:20 +11:00
portlist.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
private.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rbt.c
Reformat sources using clang-format-11
2020-12-08 19:34:05 +01:00
rbtdb.c
Reuse rdatset->ttl when dumping ancient RRsets
2021-05-30 12:30:36 -07:00
rbtdb.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rcode.c
Use isdigit instead of checking character range
2021-05-05 18:23:53 +02:00
rdata.c
Make calling generic rdata methods consistent
2021-04-13 01:54:29 +00:00
rdatalist_p.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdatalist.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdataset.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdatasetiter.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdataslab.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
request.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
resolver.c
use a fixedname buffer in dns_message_gettempname()
2021-05-22 07:13:57 +02:00
result.c
Add NSEC3PARAM unit test, refactor zone.c
2020-11-26 14:15:05 +00:00
rootns.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rpz.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
rriterator.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rrl.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
sdb.c
Add stale-refresh-time option
2020-11-11 15:59:56 -03:00
sdlz.c
Add stale-refresh-time option
2020-11-11 15:59:56 -03:00
soa.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ssu_external.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ssu.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
stats.c
Update comments to have binary notation
2020-09-29 10:40:56 +10:00
tcpmsg.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
time.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
timer.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
tkey.c
Use dns_name_copynf() with dns_message_gettempname() when needed
2021-05-22 07:17:01 +02:00
tsec.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
tsig_p.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
tsig.c
Use dns_name_copynf() with dns_message_gettempname() when needed
2021-05-22 07:17:01 +02:00
ttl.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
update.c
Lock kasp when looking for zone keys
2021-05-20 09:52:53 +02:00
validator.c
Mark DNSSEC responses with NSEC3 records that exceed 150 as insecure
2021-04-30 11:16:45 +02:00
version.c
Use -release instead of -version-info for internal library SONAMEs
2021-01-25 15:28:09 +01:00
view.c
Initialize checknames field in dns_view_create()
2021-02-23 16:45:36 +01:00
xfrin.c
use a fixedname buffer in dns_message_gettempname()
2021-05-22 07:13:57 +02:00
zone_p.h
Add NSEC3PARAM unit test, refactor zone.c
2020-11-26 14:15:05 +00:00
zone.c
Address race between zone_settimer and set_key_expiry_warning by
2021-06-09 23:56:47 +10:00
zonekey.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
zoneverify.c
Optimise dnssec-verify
2021-01-28 12:18:31 +11:00
zt.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00