Mark Andrews
b0d32302b2
Remove unnecessary operations
...
Decrementing optlen immediately before calling continue is unneccesary
and inconsistent with the rest of dns_message_pseudosectiontoyaml
and dns_message_pseudosectiontotext. Coverity was also reporting
an impossible false positive overflow of optlen (CID 499061).
4176 } else if (optcode == DNS_OPT_CLIENT_TAG) {
4177 uint16_t id;
4178 ADD_STRING(target, "; CLIENT-TAG:");
4179 if (optlen == 2U) {
4180 id = isc_buffer_getuint16(&optbuf);
4181 snprintf(buf, sizeof(buf), " %u\n", id);
4182 ADD_STRING(target, buf);
CID 499061: (#1 of 1): Overflowed constant (INTEGER_OVERFLOW)
overflow_const: Expression optlen, which is equal to 65534, underflows
the type that receives it, an unsigned integer 16 bits wide.
4183 optlen -= 2;
4184 POST(optlen);
4185 continue;
4186 }
4187 } else if (optcode == DNS_OPT_SERVER_TAG) {
(cherry picked from commit 47338c2c87 )
2024-08-02 06:43:03 +00:00
..
2024-06-10 18:50:06 +02:00
2024-05-07 02:08:27 +00:00
2022-04-26 14:21:57 +02:00
2024-07-31 05:52:18 +00:00
2022-11-29 09:14:07 +01:00
2022-11-29 09:14:07 +01:00
2024-06-10 18:50:06 +02:00
2022-01-11 09:05:02 +01:00
2024-05-14 08:46:00 +10:00
2022-12-07 23:59:36 +00:00
2023-02-08 00:13:12 -08:00
2022-11-29 09:14:07 +01:00
2024-06-10 18:50:06 +02:00
2022-01-11 09:05:02 +01:00
2023-12-20 02:47:42 +11:00
2023-05-26 02:07:02 -07:00
2022-03-25 08:42:18 +01:00
2022-04-26 14:21:57 +02:00
2024-06-10 18:50:06 +02:00
2024-01-17 10:05:20 +01:00
2022-08-31 15:24:00 -07:00
2022-01-11 09:05:02 +01:00
2022-03-25 08:42:16 +01:00
2024-02-01 21:47:29 +01:00
2023-03-31 16:47:15 +02:00
2022-03-02 10:49:47 +00:00
2023-03-31 16:47:15 +02:00
2022-01-11 09:05:02 +01:00
2023-02-09 10:07:39 -08:00
2022-11-29 09:14:07 +01:00
2022-01-11 09:05:02 +01:00
2023-01-11 13:42:09 +00:00
2022-11-29 09:14:07 +01:00
2022-01-11 09:05:02 +01:00
2022-03-18 16:05:56 +00:00
2022-03-25 08:42:18 +01:00
2023-06-29 10:52:48 +10:00
2023-01-09 14:23:26 -08:00
2022-01-11 09:05:02 +01:00
2022-12-07 23:59:36 +00:00
2024-04-18 15:00:07 +00:00
2022-11-29 09:14:07 +01:00
2022-01-11 09:05:02 +01:00
2024-07-30 13:38:04 +02:00
2023-04-03 17:46:13 +02:00
2022-01-11 09:05:02 +01:00
2022-03-25 08:42:18 +01:00
2022-07-13 10:46:37 +10:00
2024-05-07 01:06:14 +00:00
2024-08-01 03:48:12 +00:00
2024-08-02 06:43:03 +00:00
2024-01-05 11:50:23 +01:00
2023-09-18 15:51:44 +10:00
2023-12-21 22:07:53 +11:00
2022-12-07 23:59:36 +00:00
2023-01-18 22:39:26 +01:00
2023-09-01 13:43:20 +10:00
2022-01-11 09:05:02 +01:00
2022-01-11 09:05:02 +01:00
2022-11-29 09:14:07 +01:00
2023-09-01 14:06:27 +10:00
2023-09-01 13:45:34 +10:00
2023-10-27 10:49:38 +11:00
2022-11-29 09:14:07 +01:00
2023-01-09 14:23:26 -08:00
2023-10-18 09:02:57 +02:00
2024-02-29 12:39:26 +01:00
2024-07-01 15:04:43 +02:00
2022-01-11 09:05:02 +01:00
2022-11-29 09:14:07 +01:00
2024-08-01 01:10:53 +00:00
2022-01-11 09:05:02 +01:00
2022-11-29 09:14:07 +01:00
2023-02-09 08:58:15 +11:00
2022-01-11 09:05:02 +01:00
2024-06-10 18:50:03 +02:00
2024-05-15 21:24:24 +02:00
2024-08-01 15:58:16 +10:00
2023-06-15 16:27:17 +02:00
2023-11-03 03:43:49 +11:00
2023-07-06 10:44:03 +00:00
2022-12-07 23:59:36 +00:00
2024-04-23 12:48:56 +00:00
2024-06-10 18:50:06 +02:00
2024-06-10 18:50:06 +02:00
2022-03-25 08:42:18 +01:00
2022-01-11 09:05:02 +01:00
2024-08-02 00:09:17 +00:00
2023-12-06 09:01:05 +11:00
2022-05-31 12:06:00 +02:00
2022-01-11 09:05:02 +01:00
2023-07-29 05:46:32 +10:00
2022-05-03 17:42:43 +03:00
2022-03-25 08:42:16 +01:00
2022-01-11 09:05:02 +01:00
2024-01-05 11:19:58 +01:00
2022-01-11 09:05:02 +01:00
2024-04-18 15:00:07 +00:00
2024-04-30 17:47:49 +02:00
2024-06-10 18:50:06 +02:00
2024-05-29 08:56:38 +02:00
2022-01-11 09:05:02 +01:00
2024-06-10 18:51:28 +02:00
2022-11-29 09:14:07 +01:00
2024-05-16 01:53:39 +00:00
2022-11-29 09:14:07 +01:00