Mark Andrews
59bf6e71e2
Address theoretical buffer overrun in recent change
...
The strlcat() call was wrong.
*** CID 316608: Memory - corruptions (OVERRUN)
/lib/dns/resolver.c: 5017 in fctx_create()
5011 * Make fctx->info point to a copy of a formatted string
5012 * "name/type".
5013 */
5014 dns_name_format(name, buf, sizeof(buf));
5015 dns_rdatatype_format(type, typebuf, sizeof(typebuf));
5016 p = strlcat(buf, "/", sizeof(buf));
>>> CID 316608: Memory - corruptions (OVERRUN)
>>> Calling "strlcat" with "buf + p" and "1036UL" is suspicious because "buf" points into a buffer of 1036 bytes and the function call may access "(char *)(buf + p) + 1035UL". [Note: The source code implementation of the function has been overridden by a builtin model.]
5017 strlcat(buf + p, typebuf, sizeof(buf));
5018 fctx->info = isc_mem_strdup(mctx, buf);
5019
5020 FCTXTRACE("create");
5021 dns_name_init(&fctx->name, NULL);
5022 dns_name_dup(name, mctx, &fctx->name);
2021-02-14 22:41:46 +00:00
..
2021-01-29 12:07:38 +01:00
2021-02-12 10:19:27 +11:00
2020-12-11 10:48:28 +01:00
2021-01-29 12:07:38 +01:00
2020-09-14 16:20:40 -07:00
2020-10-05 16:21:21 +02:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-01-19 10:12:40 +01:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-29 08:22:08 +02:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-02-03 12:22:33 +11:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-11-25 12:45:47 +01:00
2021-02-03 12:22:33 +11:00
2020-11-25 08:25:29 +11:00
2020-11-11 12:53:23 -03:00
2020-12-23 09:02:11 +01:00
2020-09-29 08:22:08 +02:00
2020-09-14 16:20:40 -07:00
2020-12-23 09:02:11 +01:00
2020-12-23 09:02:11 +01:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-10-28 15:48:58 +01:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-02-03 12:22:33 +11:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-01-29 12:07:38 +01:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-01-12 10:54:48 +00:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-02-03 15:35:06 +01:00
2021-02-03 12:22:33 +11:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-01-29 12:07:38 +01:00
2020-09-14 16:20:40 -07:00
2020-09-23 16:09:26 +02:00
2020-09-30 13:24:29 +00:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-11-26 10:43:59 +01:00
2020-09-14 16:20:40 -07:00
2021-02-03 12:22:33 +11:00
2021-01-25 09:19:22 +01:00
2020-09-14 16:20:40 -07:00
2021-01-26 15:01:26 +01:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-10-02 08:41:43 +02:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-12-01 10:46:58 +11:00
2020-09-14 16:20:40 -07:00
2020-12-08 18:36:23 +01:00
2021-02-03 13:06:27 +01:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-02-14 22:41:46 +00:00
2020-11-26 10:43:59 +01:00
2020-09-14 16:20:40 -07:00
2021-02-03 12:22:33 +11:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-11-11 12:53:23 -03:00
2020-11-11 12:53:23 -03:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-29 10:36:07 +10:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-01-29 12:07:38 +01:00
2020-09-14 16:20:40 -07:00
2020-09-14 16:20:40 -07:00
2021-02-03 12:22:33 +11:00
2020-09-14 16:20:40 -07:00
2020-12-23 09:02:11 +01:00
2020-10-30 00:17:24 +11:00
2021-01-29 12:07:38 +01:00
2021-01-29 12:07:38 +01:00
2020-11-26 10:43:59 +01:00
2021-02-03 12:22:33 +11:00
2020-09-14 16:20:40 -07:00
2021-01-28 11:07:03 +11:00
2021-02-03 12:22:33 +11:00