ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
Files
4e36debc738d015929685298d15bcd51caa7b95c
bind9/lib/dns
History
Ondřej Surý 4bae6d8d73 Fix lock-order-inversion (potential deadlock) in dns_resolver_createfetch 
There's a lock-order-inversion when running `zone_maintenance()` from
the timer while shutting down the server `shutdown_server()`.  This only
happens when the taskmgr scheduling is more relaxed and paralellized,
but the issue is real nevertheless.

The associated ThreadSanitizer warning:

    WARNING: ThreadSanitizer: lock-order-inversion (potential deadlock)
      Cycle in lock order graph: M1 (0x000000000001) => M2 (0x000000000000) => M1

      Mutex M2 acquired here while holding mutex M1 in thread T1:
	#0 pthread_mutex_lock <null>
	#1 dns_view_findzonecut lib/dns/view.c:1326:2
	#2 fctx_create lib/dns/resolver.c:5144:13
	#3 dns_resolver_createfetch lib/dns/resolver.c:10977:12
	#4 zone_refreshkeys lib/dns/zone.c:10830:13
	#5 zone_maintenance lib/dns/zone.c:11065:5
	#6 zone_timer lib/dns/zone.c:14652:2
	#7 task_run lib/isc/task.c:857:5
	#8 isc_task_run lib/isc/task.c:944:10
	#9 isc__nm_async_task lib/isc/netmgr/netmgr.c:730:24
	#10 process_netievent lib/isc/netmgr/netmgr.c
	#11 process_queue lib/isc/netmgr/netmgr.c:885:8
	#12 process_tasks_queue lib/isc/netmgr/netmgr.c:756:10
	#13 process_queues lib/isc/netmgr/netmgr.c:772:7
	#14 async_cb lib/isc/netmgr/netmgr.c:671:2
	#15 uv__async_io /home/ondrej/Projects/tsan/libuv/src/unix/async.c:163:5
	#16 uv__io_poll /home/ondrej/Projects/tsan/libuv/src/unix/linux-core.c:462:11
	#17 uv_run /home/ondrej/Projects/tsan/libuv/src/unix/core.c:392:5
	#18 nm_thread lib/isc/netmgr/netmgr.c:597:11
	#19 isc__trampoline_run lib/isc/trampoline.c:184:11

      Mutex M1 previously acquired by the same thread here:
	#0 pthread_mutex_lock <null>
	#1 zone_refreshkeys lib/dns/zone.c:10717:2
	#2 zone_maintenance lib/dns/zone.c:11065:5
	#3 zone_timer lib/dns/zone.c:14652:2
	#4 task_run lib/isc/task.c:857:5
	#5 isc_task_run lib/isc/task.c:944:10
	#6 isc__nm_async_task lib/isc/netmgr/netmgr.c:730:24
	#7 process_netievent lib/isc/netmgr/netmgr.c
	#8 process_queue lib/isc/netmgr/netmgr.c:885:8
	#9 process_tasks_queue lib/isc/netmgr/netmgr.c:756:10
	#10 process_queues lib/isc/netmgr/netmgr.c:772:7
	#11 async_cb lib/isc/netmgr/netmgr.c:671:2
	#12 uv__async_io /home/ondrej/Projects/tsan/libuv/src/unix/async.c:163:5
	#13 uv__io_poll /home/ondrej/Projects/tsan/libuv/src/unix/linux-core.c:462:11
	#14 uv_run /home/ondrej/Projects/tsan/libuv/src/unix/core.c:392:5
	#15 nm_thread lib/isc/netmgr/netmgr.c:597:11
	#16 isc__trampoline_run lib/isc/trampoline.c:184:11

      Mutex M1 acquired here while holding mutex M2 in thread T2:
	#0 pthread_mutex_lock <null>
	#1 dns_zone_flush lib/dns/zone.c:11443:2
	#2 view_flushanddetach lib/dns/view.c:657:5
	#3 dns_view_flushanddetach lib/dns/view.c:690:2
	#4 shutdown_server bin/named/server.c:10056:4
	#5 task_run lib/isc/task.c:857:5
	#6 isc_task_run lib/isc/task.c:944:10
	#7 isc__nm_async_task lib/isc/netmgr/netmgr.c:730:24
	#8 process_netievent lib/isc/netmgr/netmgr.c
	#9 process_queue lib/isc/netmgr/netmgr.c:885:8
	#10 process_tasks_queue lib/isc/netmgr/netmgr.c:756:10
	#11 process_queues lib/isc/netmgr/netmgr.c:772:7
	#12 async_cb lib/isc/netmgr/netmgr.c:671:2
	#13 uv__async_io /home/ondrej/Projects/tsan/libuv/src/unix/async.c:163:5
	#14 uv__io_poll /home/ondrej/Projects/tsan/libuv/src/unix/linux-core.c:462:11
	#15 uv_run /home/ondrej/Projects/tsan/libuv/src/unix/core.c:392:5
	#16 nm_thread lib/isc/netmgr/netmgr.c:597:11
	#17 isc__trampoline_run lib/isc/trampoline.c:184:11

      Mutex M2 previously acquired by the same thread here:
	#0 pthread_mutex_lock <null>
	#1 view_flushanddetach lib/dns/view.c:645:3
	#2 dns_view_flushanddetach lib/dns/view.c:690:2
	#3 shutdown_server bin/named/server.c:10056:4
	#4 task_run lib/isc/task.c:857:5
	#5 isc_task_run lib/isc/task.c:944:10
	#6 isc__nm_async_task lib/isc/netmgr/netmgr.c:730:24
	#7 process_netievent lib/isc/netmgr/netmgr.c
	#8 process_queue lib/isc/netmgr/netmgr.c:885:8
	#9 process_tasks_queue lib/isc/netmgr/netmgr.c:756:10
	#10 process_queues lib/isc/netmgr/netmgr.c:772:7
	#11 async_cb lib/isc/netmgr/netmgr.c:671:2
	#12 uv__async_io /home/ondrej/Projects/tsan/libuv/src/unix/async.c:163:5
	#13 uv__io_poll /home/ondrej/Projects/tsan/libuv/src/unix/linux-core.c:462:11
	#14 uv_run /home/ondrej/Projects/tsan/libuv/src/unix/core.c:392:5
	#15 nm_thread lib/isc/netmgr/netmgr.c:597:11
	#16 isc__trampoline_run lib/isc/trampoline.c:184:11

      Thread T2 (running) created by main thread at:
	#0 pthread_create <null>
	#1 isc_thread_create lib/isc/pthreads/thread.c:79:8
	#2 isc_nm_start lib/isc/netmgr/netmgr.c:303:3
	#3 create_managers bin/named/main.c:957:15
	#4 setup bin/named/main.c:1267:11
	#5 main bin/named/main.c:1558:2

      Thread T2 (running) created by main thread at:
	#0 pthread_create <null>
	#1 isc_thread_create lib/isc/pthreads/thread.c:79:8
	#2 isc_nm_start lib/isc/netmgr/netmgr.c:303:3
	#3 create_managers bin/named/main.c:957:15
	#4 setup bin/named/main.c:1267:11
	#5 main bin/named/main.c:1558:2

    SUMMARY: ThreadSanitizer: lock-order-inversion (potential deadlock) in __interceptor_pthread_mutex_lock

(cherry picked from commit 25d27851d8)
2021-04-19 22:31:37 +02:00
..
include
rename dns_client_createx() to dns_client_create()
2021-04-19 13:25:48 +02:00
rdata
Make calling generic rdata methods consistent
2021-04-13 01:54:29 +00:00
tests
Use stale TTL as RRset TTL in dumpdb
2021-04-13 10:59:17 +02:00
win32
rename dns_client_createx() to dns_client_create()
2021-04-19 13:25:48 +02:00
.gitignore
…
acl.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
adb.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
badcache.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
byaddr.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
cache.c
Check 'stale-refresh-time' when sharing cache between views
2020-11-11 16:06:23 -03:00
callbacks.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
catz.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
client.c
properly initialise resarg->lock
2021-04-19 14:32:53 +02:00
clientinfo.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
compress.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
db.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
dbiterator.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dbtable.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
diff.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dispatch.c
Silence cppcheck 2.2 false positive in udp_recv()
2020-11-25 13:21:58 +01:00
dlz.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
dns64.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dnsrps.c
Add stale-refresh-time option
2020-11-11 15:59:56 -03:00
dnssec.c
Purge keys implementation
2021-02-23 09:19:03 +01:00
dnstap.c
Address theoretical resource leak in dns_dt_open()
2021-02-23 09:41:15 +11:00
dnstap.proto
fix spelling errors reported by Fossies.
2020-02-21 07:05:31 +00:00
ds.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_api.c
Move most of the OpenSSL initialization to isc_tls
2021-02-26 17:07:01 +01:00
dst_internal.h
Fix handling undefined GSS_SPNEGO_MECHANISM macro
2021-04-16 14:40:06 +02:00
dst_openssl.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_parse.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_parse.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_pkcs11.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dst_result.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
dyndb.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ecdb.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ecs.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
fixedname.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
forward.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
gen-unix.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
gen-win32.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
gen.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
geoip2.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
gssapi_link.c
Stop including <gssapi.h> from <dst/gssapi.h> header
2021-02-16 12:08:21 +11:00
gssapictx.c
Free resources when gss_accept_sec_context() fails
2021-04-08 10:41:08 +02:00
hmac_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ipkeylist.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
iptable.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
journal.c
Refactor dns_journal_rollforward() to work over opened journal
2021-04-16 13:50:20 +02:00
kasp.c
Add purge-keys config option
2021-02-23 09:18:55 +01:00
key.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
keydata.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
keymgr.c
Fix keymgr key init bug
2021-03-22 11:24:55 +01:00
keytable.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
Kyuafile
…
lib.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
log.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
lookup.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
Makefile.in
Remove custom ISC SPNEGO implementation
2021-04-01 10:42:32 +02:00
mapapi
improve calculation of database size
2020-03-12 00:38:37 -07:00
master.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
masterdump.c
Use stale TTL as RRset TTL in dumpdb
2021-04-13 10:59:17 +02:00
message.c
The dns_message_create() cannot fail, change the return to void
2020-09-30 14:26:26 +02:00
name.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ncache.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
nsec3.c
Detect NSEC3 salt collisions
2020-11-26 14:15:05 +00:00
nsec.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
nta.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
openssl_link.c
Use library constructor/destructor to initialize OpenSSL
2021-02-26 17:18:06 +01:00
openssldh_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
opensslecdsa_link.c
Make opensslecdsa_parse use fromlabel
2021-01-26 15:04:59 +01:00
openssleddsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
opensslrsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
order.c
Allow "order none" in "rrset-order" rules
2020-10-02 08:50:51 +02:00
peer.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11ecdsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11eddsa_link.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
pkcs11rsa_link.c
Fix misplaced declaration
2020-12-01 23:19:20 +11:00
portlist.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
private.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rbt.c
Reformat sources using clang-format-11
2020-12-08 19:34:05 +01:00
rbtdb.c
Use stale TTL as RRset TTL in dumpdb
2021-04-13 10:59:17 +02:00
rbtdb.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rcode.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdata.c
Make calling generic rdata methods consistent
2021-04-13 01:54:29 +00:00
rdatalist_p.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdatalist.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdataset.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdatasetiter.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rdataslab.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
request.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
resolver.c
Address theoretical buffer overrun in recent change
2021-03-03 10:55:38 +01:00
result.c
Add NSEC3PARAM unit test, refactor zone.c
2020-11-26 14:15:05 +00:00
rootns.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rpz.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
rriterator.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
rrl.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
sdb.c
Add stale-refresh-time option
2020-11-11 15:59:56 -03:00
sdlz.c
Add stale-refresh-time option
2020-11-11 15:59:56 -03:00
soa.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ssu_external.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
ssu.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
stats.c
Update comments to have binary notation
2020-09-29 10:40:56 +10:00
tcpmsg.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
time.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
timer.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
tkey.c
Stop including <gssapi.h> from <dst/gssapi.h> header
2021-02-16 12:08:21 +11:00
tsec.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
tsig_p.h
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
tsig.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00
ttl.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
update.c
Implement draft-vandijk-dnsop-nsec-ttl
2021-04-13 14:18:33 +02:00
validator.c
Handle DNS_R_NCACHENXRRSET in fetch_callback_{dnskey,validator}()
2020-10-30 08:21:43 +11:00
version.c
Use -release instead of -version-info for internal library SONAMEs
2021-01-25 15:28:09 +01:00
view.c
Initialize checknames field in dns_view_create()
2021-02-23 16:45:36 +01:00
xfrin.c
add serial number to "transfer ended" log messages
2021-01-26 12:38:32 +01:00
zone_p.h
Add NSEC3PARAM unit test, refactor zone.c
2020-11-26 14:15:05 +00:00
zone.c
Fix lock-order-inversion (potential deadlock) in dns_resolver_createfetch
2021-04-19 22:31:37 +02:00
zonekey.c
update all copyright headers to eliminate the typo
2020-09-14 16:50:58 -07:00
zoneverify.c
Optimise dnssec-verify
2021-01-28 12:18:31 +11:00
zt.c
Cleanup redundant isc_rwlock_init() result checks
2021-02-08 15:13:49 +11:00