ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
Files
49dad2c12e38b7523b690af129e069bb9706e044
bind9/lib/dns
T
History
Matthijs MekkingandEvan Hunt 3cd62b71e6 Fix race condition crash 
When running resolver benchmark pipeline, a crash occurred:

https://gitlab.isc.org/isc-projects/bind9-shotgun-ci/-/pipelines/163946

In the code we are doing a lookup, it fails (meaning there is no node
with lookup name), we create the node and insert it and it fails.
But dns_qp_insert can only return ISC_R_SUCCESS or ISC_R_EXISTS.
So it must have been inserted in between. This is a race condition bug.

The first lookup only requires a write lock and if the lookup failed
the lock gets upgraded to a write lock and we insert the missing data.

To fix the race condition bug, we need to do a lookup again after we
have upgraded the lock to make sure it wasn't inserted in the mean
time.
2024-03-05 16:57:03 -08:00
..
include
add dns_db_nodefullname()
2024-03-05 16:53:22 -08:00
rdata
Add RESINFO record type
2024-02-26 12:02:40 +11:00
.gitignore
…
acl.c
Convert rwlock in dns_acl to RCU
2023-10-13 14:44:40 +02:00
adb.c
Refactor the handling of isc_mem overmem condition
2023-11-29 14:16:20 +01:00
badcache.c
…
byaddr.c
…
cache.c
switch database defaults from "rbt" to "qp"
2024-03-05 16:48:12 -08:00
callbacks.c
…
catz.c
Fix catz db update callback registration logic error (take two)
2023-11-14 08:59:48 +00:00
client.c
switch database defaults from "rbt" to "qp"
2024-03-05 16:48:12 -08:00
clientinfo.c
…
compress.c
Cleanup the dns_name macros
2023-09-12 16:14:10 +02:00
db_p.h
Merge tag 'v9.19.21'
2024-02-14 13:24:56 +01:00
db.c
add dns_db_nodefullname()
2024-03-05 16:53:22 -08:00
dbiterator.c
…
diff.c
Log what change generated a 'not exact' error
2023-12-20 01:56:38 +11:00
dispatch.c
Always call the TCP dispatch connected callbacks asynchronously
2024-03-04 16:34:14 +01:00
dlz.c
…
dns64.c
Add the ability to use DNS64 internally
2023-09-13 14:31:43 +10:00
dnsrps.c
…
dnssec.c
Refactor dns_keystore_directory()
2024-01-25 15:37:40 +01:00
dnstap.c
Change dns_message_create() function to accept memory pools
2023-09-24 18:07:40 +02:00
dnstap.proto
…
ds.c
…
dst_api.c
Merge tag 'v9.19.21'
2024-02-14 13:24:56 +01:00
dst_internal.h
Create keys with PKCS#11 URI instead of object
2024-01-25 14:48:07 +01:00
dst_openssl.h
…
dst_parse.c
…
dst_parse.h
…
dyndb.c
…
ecs.c
…
fixedname.c
…
forward.c
rename dns_qp_findname_ancestor() to dns_qp_lookup()
2023-09-28 00:32:44 -07:00
gen.c
Use EXIT_SUCCESS and EXIT_FAILURE
2024-02-08 08:01:58 +01:00
geoip2.c
…
gssapi_link.c
…
gssapictx.c
…
hmac_link.c
…
ipkeylist.c
Remove ISC_MEM_ZERO and isc_mem_*x() API
2023-08-31 22:08:35 +02:00
iptable.c
Convert manual dns_iptable_{attach,detach} to ISC_REFCOUNT_IMPL
2023-10-13 14:44:40 +02:00
journal.c
Remove ISC_MEM_ZERO and isc_mem_*x() API
2023-08-31 22:08:35 +02:00
kasp.c
Store key store reference instead of name
2024-01-25 14:41:25 +01:00
key.c
Use dst_key's directory when writing key files
2024-01-25 14:47:43 +01:00
keydata.c
…
keymgr.c
Refactor dns_keystore_directory()
2024-01-25 15:37:40 +01:00
keystore.c
Replace keystore attach/detach with ISC_REFCOUNT_IMPL/ISC_REFCOUNT_DECL
2024-01-25 15:37:40 +01:00
keytable.c
rename dns_qp_findname_ancestor() to dns_qp_lookup()
2023-09-28 00:32:44 -07:00
log.c
…
Makefile.am
Begin replacement of rbt with qp in rbtdb
2024-03-05 15:47:59 -08:00
master.c
Update the source code formatting using clang-format-17
2023-10-17 17:47:46 +02:00
masterdump.c
remove unused functions in dns_master
2023-12-06 17:31:38 -08:00
message.c
Merge tag 'v9.19.21'
2024-02-14 13:24:56 +01:00
name.c
Cleanup the dns_name macros
2023-09-12 16:14:10 +02:00
nametree.c
rename dns_qp_findname_ancestor() to dns_qp_lookup()
2023-09-28 00:32:44 -07:00
ncache.c
Correctly set the value of covered in dns_ncache_current
2023-09-18 13:38:27 +10:00
nsec3.c
Don't delete the NSEC3PARAM immediately
2023-12-21 20:12:09 +11:00
nsec.c
…
nta.c
Fix undefined behaviour occurrences
2023-10-13 09:57:28 +00:00
openssl_link.c
Use EXIT_SUCCESS and EXIT_FAILURE
2024-02-08 08:01:58 +01:00
openssl_shim.c
…
openssl_shim.h
…
opensslecdsa_link.c
Specify key usage to be digital signature
2024-01-25 14:48:07 +01:00
openssleddsa_link.c
Clear OpenSSL errors on context creation failures
2023-09-01 12:01:20 +10:00
opensslrsa_link.c
Specify key usage to be digital signature
2024-01-25 14:48:07 +01:00
order.c
…
peer.c
…
private.c
Update the source code formatting using clang-format-17
2023-10-17 17:47:46 +02:00
probes.d
Do not destroy IXFR journal in xfrin_end()
2023-12-20 17:21:14 +01:00
qp_p.h
rename QP-related types to use standard BIND nomenclature
2023-09-28 00:32:39 -07:00
qp-cachedb.c
add dns_db_nodefullname()
2024-03-05 16:53:22 -08:00
qp-zonedb.c
add dns_db_nodefullname()
2024-03-05 16:53:22 -08:00
qp.c
prevent an infinite loop in fix_iterator()
2023-12-21 09:18:30 -08:00
qpdb_p.h
Remove pruning tree code
2024-03-05 16:54:11 -08:00
qpdb.c
Fix race condition crash
2024-03-05 16:57:03 -08:00
rbt-cachedb.c
Do not use header_prev in expire_lru_headers
2024-02-23 12:00:12 +01:00
rbt-zonedb.c
move DNS_RBT_NSEC_* to db.h
2024-02-14 01:13:44 -08:00
rbt.c
Reduce lock contention during RBTDB tree pruning
2024-02-29 11:23:03 +01:00
rbtdb_p.h
rename dns_rbtdb to dns_qpdb
2024-03-05 16:47:50 -08:00
rbtdb.c
rename dns_rbtdb to dns_qpdb
2024-03-05 16:47:50 -08:00
rcode.c
…
rdata.c
Clear OpenSSL errors on d2i_ASN1_OBJECT failures
2023-09-01 12:01:19 +10:00
rdatalist.c
…
rdataset.c
Apply the isc_mem_cget semantic patch
2023-08-31 22:08:35 +02:00
rdatasetiter.c
…
rdataslab.c
separate generic DB helpers into db_p.h
2024-02-14 09:00:27 +01:00
remote.c
Apply the isc_mem_cget semantic patch
2023-08-31 22:08:35 +02:00
request.c
Restore dns_requestmgr_shutdown re-entrancy
2024-02-07 09:52:32 +11:00
resconf.c
Address CID 486326: Memory - corruptions (OVERRUN)
2024-02-13 09:21:49 +11:00
resolver.c
DoT: do not crash resolver on TLS context creation failure
2024-02-21 21:05:21 +02:00
result.c
…
rootns.c
switch database defaults from "rbt" to "qp"
2024-03-05 16:48:12 -08:00
rpz.c
reduce search_lock coverage
2023-10-09 13:29:02 -07:00
rriterator.c
…
rrl.c
Remove ISC_MEM_ZERO and isc_mem_*x() API
2023-08-31 22:08:35 +02:00
sdlz.c
…
soa.c
…
ssu_external.c
…
ssu.c
Convert rwlock in dns_acl to RCU
2023-10-13 14:44:40 +02:00
stats.c
Ineffective DbC protections
2023-11-21 14:48:43 +11:00
tests
…
time.c
…
tkey.c
…
transport.c
Integrate TLS cipher suites support into BIND
2024-01-12 13:27:59 +02:00
tsig_p.h
…
tsig.c
Address races in dns_tsigkey_find()
2024-01-05 11:16:12 +01:00
ttl.c
…
update.c
Refactor findmatchingkeys and keylistfromrdataset
2024-01-25 14:41:25 +01:00
validator.c
Disallow stale-answer-client-timeout non-zero values
2024-02-16 08:41:52 +00:00
view.c
BIND: Add 'allow-proxy' and 'allow-proxy-on' options
2023-12-06 15:15:25 +02:00
xfrin.c
switch database defaults from "rbt" to "qp"
2024-03-05 16:48:12 -08:00
zone_p.h
Refactor findzonekeys
2024-01-25 14:48:07 +01:00
zone.c
switch database defaults from "rbt" to "qp"
2024-03-05 16:48:12 -08:00
zonekey.c
…
zoneverify.c
Remove ISC_MEM_ZERO and isc_mem_*x() API
2023-08-31 22:08:35 +02:00
zt.c
rename dns_qp_findname_ancestor() to dns_qp_lookup()
2023-09-28 00:32:44 -07:00