ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
Files
0487d508138f0567b322bf4c1583cfcc69d8bb00
bind9/lib/dns
History
Ondřej Surý 40659b5978 Restore the IS_STUB() condition in zone_zonecut_callback 
After the refactoring the condition whether to use DNAME or NS for the
zonecut was incorrectly simplified and the !IS_STUB() condition was
removed.  This was flagged by Coverity as:

	/lib/dns/rbt-zonedb.c: 192 in zone_zonecut_callback()
	186     		found = ns_header;
	187     		search->zonecut_sigheader = NULL;
	188     	} else if (dname_header != NULL) {
	189     		found = dname_header;
	190     		search->zonecut_sigheader = sigdname_header;
	191     	} else if (ns_header != NULL) {
	>>>     CID 462773:  Control flow issues  (DEADCODE)
	>>>     Execution cannot reach this statement: "found = ns_header;".
	192     		found = ns_header;
	193     		search->zonecut_sigheader = NULL;
	194     	}
	195
	196     	if (found != NULL) {
	197     		/*

Instead of removing the extra block, restore the !IS_STUB() condition
for the first if block.
2023-07-20 17:59:44 +02:00
..
include
Obsolete dnssec-update-mode
2023-07-20 12:44:19 +02:00
rdata
Replace DE_CONST(k, v) with v = UNCONST(k) macro
2023-04-03 10:25:56 +00:00
.gitignore
…
acl.c
Add the reader-writer synchronization with modified C-RW-WP
2023-02-15 09:30:04 +01:00
adb.c
clean up numbering of FETCHOPT and ADDRINFO flags
2023-07-04 18:23:57 +00:00
badcache.c
Refactor isc_time_now() to return time, and not result
2023-03-31 15:02:06 +02:00
byaddr.c
remove isc_task completely
2023-02-16 18:35:32 +01:00
cache.c
move prototypes for common functions to rbtdb_p.h
2023-07-17 14:50:25 +02:00
callbacks.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
catz.c
Add shutdown checks in dns_catz_dbupdate_callback()
2023-07-06 10:46:46 +00:00
client.c
The zone table no longer depends on the loop manager
2023-05-12 20:48:31 +01:00
clientinfo.c
refactor dns_clientinfo_init(); use separate function to set ECS
2023-02-07 23:48:22 -08:00
compress.c
…
db.c
move slab rdataset implementation to rdataslab.c
2023-07-17 14:50:25 +02:00
dbiterator.c
Implement dns_db node tracing
2023-02-28 11:44:15 +01:00
diff.c
Implement dns_db node tracing
2023-02-28 11:44:15 +01:00
dispatch.c
use isc_loop_now() for dispentry timeouts
2023-07-19 15:32:21 +02:00
dlz.c
Extend dns_view_findzone to take an options argument
2023-06-01 16:51:38 +02:00
dns64.c
…
dnsrps.c
Give the rdataset->privateN fields more helpful names
2023-07-17 14:50:25 +02:00
dnssec.c
Update findzonekeys function name in log message
2023-06-14 09:08:56 +02:00
dnstap.c
Replace DE_CONST(k, v) with v = UNCONST(k) macro
2023-04-03 10:25:56 +00:00
dnstap.proto
…
ds.c
…
dst_api.c
get_key_struct() can no longer fail
2023-06-14 08:14:38 +00:00
dst_internal.h
Probe if ED448 and ED25519 are supported
2023-04-03 12:06:04 +10:00
dst_openssl.h
Report file and line when converting OpenSSL errors
2023-04-03 12:06:04 +10:00
dst_parse.c
Replace isc_fsaccess API with more secure file creation
2023-03-31 12:52:59 +00:00
dst_parse.h
Remove TKEY Mode 2 (Diffie-Hellman)
2023-03-08 08:36:25 +01:00
dyndb.c
switch to using isc_loopmgr_pause() instead of task exclusive
2023-02-16 17:51:55 +01:00
ecs.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
fixedname.c
…
forward.c
Add the reader-writer synchronization with modified C-RW-WP
2023-02-15 09:30:04 +01:00
gen.c
Remove unused support for fromwire(DNS_NAME_DOWNCASE)
2023-02-06 13:26:36 +00:00
geoip2.c
…
gssapi_link.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
gssapictx.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
hmac_link.c
Emit deprecated warning for K* file pairs
2023-06-29 08:28:48 +10:00
ipkeylist.c
remove nonfunctional DSCP implementation
2023-01-09 12:15:21 -08:00
iptable.c
…
journal.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
kasp.c
Add functions to set CDNSKEY publication
2023-05-11 17:07:51 +02:00
key.c
Refactor KSK processing
2023-07-20 12:40:52 +02:00
keydata.c
…
keymgr.c
Add key state init debugging
2023-04-17 10:56:08 +02:00
keytable.c
Give the rdataset->privateN fields more helpful names
2023-07-17 14:50:25 +02:00
log.c
remove {root-}delegation-only
2023-03-23 12:57:01 -07:00
Makefile.am
split out cache-specific functions
2023-07-17 14:50:25 +02:00
master.c
Apply the semantic patch to remove isc_stdtime_get()
2023-03-31 13:32:56 +02:00
masterdump.c
Apply the semantic patch to remove isc_stdtime_get()
2023-03-31 13:32:56 +02:00
message.c
convert TSIG keyring storage from RBT to hash table
2023-06-14 08:14:38 +00:00
name.c
Correct value of DNS_NAME_MAXLABELS
2023-04-05 14:46:39 +00:00
ncache.c
Give the rdataset->privateN fields more helpful names
2023-07-17 14:50:25 +02:00
nsec3.c
Cleanup orphaned empty-non-terminal NSEC3
2023-04-25 05:03:12 +01:00
nsec.c
Remove TKEY Mode 2 (Diffie-Hellman)
2023-03-08 08:36:25 +01:00
nta.c
Apply the semantic patch to remove isc_stdtime_get()
2023-03-31 13:32:56 +02:00
openssl_link.c
Report file and line when converting OpenSSL errors
2023-04-03 12:06:04 +10:00
openssl_shim.c
Remove TKEY Mode 2 (Diffie-Hellman)
2023-03-08 08:36:25 +01:00
openssl_shim.h
Remove TKEY Mode 2 (Diffie-Hellman)
2023-03-08 08:36:25 +01:00
opensslecdsa_link.c
Introduce dst__openssl_keypair_{compare,isprivate,destroy}
2023-03-08 13:50:46 +01:00
openssleddsa_link.c
INSIST that openssleddsa_alg_info() is successful
2023-04-05 08:03:43 +00:00
opensslrsa_link.c
Remove redundant NULL checks in OpenSSL RSA glue
2023-03-08 13:50:46 +01:00
order.c
…
peer.c
remove nonfunctional DSCP implementation
2023-01-09 12:15:21 -08:00
private.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
qp_p.h
Fixes for liburcu-qsbr
2023-05-15 20:49:42 +00:00
qp.c
Acquire qpmulti->mutex during destruction
2023-05-20 07:26:21 +00:00
rbt-cachedb.c
split out cache-specific functions
2023-07-17 14:50:25 +02:00
rbt-zonedb.c
Restore the IS_STUB() condition in zone_zonecut_callback
2023-07-20 17:59:44 +02:00
rbt.c
Squash dns_name_fullhash() and dns_name_hash()
2023-03-31 12:43:30 +00:00
rbtdb_p.h
split out cache-specific functions
2023-07-17 14:50:25 +02:00
rbtdb.c
split out cache-specific functions
2023-07-17 14:50:25 +02:00
rcode.c
Remove TKEY Mode 2 (Diffie-Hellman)
2023-03-08 08:36:25 +01:00
rdata.c
Add new dns_rdatatype_iskeymaterial() function
2023-05-23 08:53:23 +02:00
rdatalist.c
Give the rdataset->privateN fields more helpful names
2023-07-17 14:50:25 +02:00
rdataset.c
move slab rdataset implementation to rdataslab.c
2023-07-17 14:50:25 +02:00
rdatasetiter.c
Implement dns_db node tracing
2023-02-28 11:44:15 +01:00
rdataslab.c
move slab rdataset implementation to rdataslab.c
2023-07-17 14:50:25 +02:00
remote.c
remove nonfunctional DSCP implementation
2023-01-09 12:15:21 -08:00
request.c
use isc_loop_now() for dispentry timeouts
2023-07-19 15:32:21 +02:00
resconf.c
Properly process extra nameserver lines in resolv.conf
2023-05-16 02:04:55 +00:00
resolver.c
use isc_loop_now() for dispentry timeouts
2023-07-19 15:32:21 +02:00
result.c
Refactor how we map isc_result_t <-> dns_rcode_t
2023-06-15 15:32:04 +02:00
rootns.c
Apply the semantic patch to remove isc_stdtime_get()
2023-03-31 13:32:56 +02:00
rpz.c
Refactor isc_time_now() to return time, and not result
2023-03-31 15:02:06 +02:00
rriterator.c
…
rrl.c
Squash dns_name_fullhash() and dns_name_hash()
2023-03-31 12:43:30 +00:00
sdlz.c
clean up unused dns_db methods
2023-07-17 14:50:25 +02:00
soa.c
…
ssu_external.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
ssu.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
stats.c
Remove obsolete code from dns_stats
2023-04-03 12:08:05 +01:00
tests
…
time.c
Remove isc_stdtime_get() macro
2023-03-31 13:33:16 +02:00
tkey.c
improve code flow
2023-06-14 08:14:38 +00:00
transport.c
Add the reader-writer synchronization with modified C-RW-WP
2023-02-15 09:30:04 +01:00
tsig_p.h
remove dns__tsig_algallocated()
2023-06-14 08:14:38 +00:00
tsig.c
rename 'ret' to 'result'
2023-06-14 08:14:38 +00:00
ttl.c
Remove do-nothing header <isc/print.h>
2023-02-15 16:44:47 +00:00
update.c
Tiny refactor revoked key check
2023-07-20 12:44:19 +02:00
validator.c
Fix extra detach when dns_validator create_fetch() detects deadlock
2023-06-06 19:04:17 +02:00
view.c
Use RCU for view->adb access
2023-06-14 19:21:28 +10:00
xfrin.c
use isc_loop_now() for dispentry timeouts
2023-07-19 15:32:21 +02:00
zone_p.h
Obsolete dnssec-dnskey-kskonly update-check-ksk
2023-07-20 12:40:54 +02:00
zone.c
Obsolete dnssec-update-mode
2023-07-20 12:44:19 +02:00
zonekey.c
…
zoneverify.c
Replace DE_CONST(k, v) with v = UNCONST(k) macro
2023-04-03 10:25:56 +00:00
zt.c
The zone table no longer depends on the loop manager
2023-05-12 20:48:31 +01:00