3698. [cleanup] Replaced all uses of memcpy() with memmove().
[RT #35120]
(cherry picked from commit ebe54c7d2221c6a0a4b3d96bcae3280c823a45e6)
(cherry picked from commit 9b950c70f1a6406c0f3dff604822329d06fc4837)
(cherry picked from commit ae5f27d8856436d01f19c958d1a4afe8dc2bedb0)
cc: "netaddr.c", line 235: warning 508: Statement can never be reached.
cc: "netaddr.c", line 238: warning 508: Statement can never be reached.
... but now it won't say that anymore. "break"s following "return"s removed.
Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const. Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.
The macro DE_CONST was added to isc/util.h to deal with a handful of very
special places where something is qualified as const but really needs to have
its const qualifier removed.
Also cleaned up a few places where variable names clashed with reserved
identifiers. (Which mostly works fine, but strictly speaking is undefined
by the standard.)
Minor other ISC style cleanups.
Cleanup of redundant/useless header file inclusion.
ISC style lint, primarily for function declarations and standalone
comments -- ie, those that appear on a line without any code, which
should be written as follows:
/*
* This is a comment.
*/
isc_netaddr_masktoprefixlen(), isc_netaddr_fromsockaddr(),
isc_netaddr_fromin(), isc_netaddr_fromin6(), isc_sockaddr_fromnetaddr();
new result code ISC_R_MASKNONCONTIG
Tinderbox User
Evan Hunt
Mark Andrews
Automatic Updater
Rob Austein
Tatuya JINMEI 神明達哉
Michael Graff