Commit Graph
2395 Commits
Author SHA1 Message Date
Andreas Gustafsson f405ffddc8 added missing requirements 2000-07-08 17:27:28 +00:00
James Brister 475c936d4c 314. [func] Inet controls named.conf statement can now have
any non-negative number of keys specified.
2000-07-07 23:11:48 +00:00
James Brister b4124351ad typo in printing additional-data definition.. 2000-07-07 22:57:53 +00:00
David Lawrence d20d22616b A socket result of ISC_R_SUCCESS can still possibly be posted even after
isc_socket_cancel() has been called.  resquery_senddone() has been fixed
to account for this (there was a race condition because of the faulty
assumption that only ISC_R_CANCELED would be returned after
isc_socket_cancel()).

The interaction of resquery_response() with the dispatcher now has to be
closely reviewed to make sure it does not have a similar problem with
a canceled query.  If the faulty assumption hadn't been faulty, it was
fine, but now I'm not so sure.
2000-07-07 19:43:14 +00:00
James Brister 524c8ea0dc typo in print statement. 2000-07-07 14:30:00 +00:00
James Brister 952e9025b0 310. [func] Changes to named.conf "controls" statement (inet
subtype only)

                          - support "keys" clause

                                controls {
                                   inet * port 1024
                                        allow { any; } keys { "foo"; }
                                }

                          - allow "port xxx" to be left out of statement,
                            in which case it defaults to omapi's default port
                            of 953.
2000-07-07 13:56:14 +00:00
Brian Wellington 25496cebad If trying to validate a key set that happens to be a security root, the
validation should only consist of checking that each key in the key set
is also in the list of security root keys.

Strangeness occurs when the key set is signed, since the key set is marked
as secure, but the sig set is not, since it wasn't used in the validation
process.  This means that a query for a key set at a security root will
have the AD bit set if the key set is unsigned and not if the key set is signed.
2000-07-07 00:44:01 +00:00
David Lawrence 3658cf5419 comment cleanup (missing "not", spaces where tabs should have been) 2000-07-07 00:25:47 +00:00
David Lawrence 9fb4b3f08a Do not return an exact match from dns_rbt_findnode() when the exact
match does not have associated data and DNS_RBTFIND_EMPTYDATA is not set.
Return DNS_R_PARTIALMATCH instead if there is a superdomain with
data, or ISC_R_NOTFOUND if no superdomain has data.

Make dns_rbt_findname() honor DNS_RBTFIND_EMPTYDATA, per the rbt.h
documentation that has been saying it will.  It didn't.
2000-07-06 23:54:45 +00:00
Brian Wellington ca93ad9b9e If we're asking for a key and need to call dns_view_findzonecut(), set
the DNS_DB_NOEXACT flag.  This means that the resolver will start look for the
key at or above the parent zone, and will return the key set from the parent
zone if key sets are present in both the parent and child.
2000-07-06 02:33:43 +00:00
Andreas Gustafsson b7b5dd0d10 treat all responses to AXFR requests as AXFR responses 2000-07-05 20:28:34 +00:00
Michael Graff 8681403c16 Shut up a gcc warning 2000-07-05 20:26:46 +00:00
Mark Andrews 8c1aa8573d 308. [bug] Treat a SOA record not at top of zone as an error
when loading a zone. (RT #154)
2000-07-04 04:28:44 +00:00
Mark Andrews 3cf456d58e zone_get_from_db() now does as much as is possible. 2000-07-04 04:21:38 +00:00
Mark Andrews 84cb41f729 new error code DNS_R_NOTZONETOP 2000-07-04 03:59:54 +00:00
David Lawrence 24675e8e13 In dns_dispatch_createtcp(), REQUIRE() that attributes not include
DNS_DISPATCHATTR_UDP, and document that requirement as well as the
existing requirement for needing DNS_DISPATCHATTR_TCP.

No need to pull up.
2000-07-04 01:48:13 +00:00
Brian Wellington 9e37579870 Check that zone->view is not NULL before checking that zone->view->adb is not
NULL.  It appears that zone maintenance can occur when the zone is shutting
down and the view pointer is NULL.  We don't want to do zone maintenance in
this case.
2000-07-04 01:32:40 +00:00
David Lawrence c7c2522a32 query-replace-o in error message; no need to pull up since no code in 9.0.0
will use the function in which the error appears
2000-07-04 01:29:48 +00:00
David Lawrence 96ab25294b 307. [bug] When canceling a query, the resolver didn't check for
isc_socket_sendto() calls that did not yet have their
			completion events posted, so it could (rarely) end up
			destroying the query context and then want to use
			it again when the send event posted, triggering an
			assertion as it tried to cancel an already-canceled
			query.  (RT #77)

... so now the resolver counts the number of outstanding isc_socket_sendto()s
and only destroys the query context when there are no more.
2000-07-04 01:19:20 +00:00
Brian Wellington e68de4a7db 306. [bug] Reading HMAC-MD5 private key files didn't work. 2000-07-03 23:27:45 +00:00
Andreas Gustafsson b3e4ce3059 alternative fix to 303. [RT #157] 2000-07-03 22:42:36 +00:00
Andreas Gustafsson d8560fb7ff [RT #155]
305. [bug]             When reloading the server with a config file
                        containing a syntax error, it could catch an
                        assertion failure trying to perform zone
                        maintenance on tentatively created zones whose
                        views were never fully configured and lacked
                        an address database.
2000-07-03 20:21:53 +00:00
Mark Andrews 845e0b5f96 303. [bug] add additional sanity checks to differentiate a AXFR
response vs a IXFR response. (RT #157)
2000-07-03 13:33:05 +00:00
Brian Wellington e405739af2 297. [bug] Specifying a key name that wasn't fully qualified
in certain parts of the config file could cause
                        an assertion.
2000-06-30 15:39:23 +00:00
Andreas Gustafsson 428b78e56d RT #153: when invoked with type==CNAME and a message
not constructed by dns_message_parse(), dns_message_findname() failed to
find anything due to checking for attribute bits set only by dns_message_parse().
This caused an infinite loop when constructing the response to an ANY query
at a CNAME in a secure zone.
2000-06-29 19:49:43 +00:00
Andreas Gustafsson 824068b85b cut-and-paste-o: dns_message_findname() tested for
dns_rdatatype_cname twice instead of cname+dname
2000-06-29 18:58:32 +00:00
Andreas Gustafsson 26be84cdfc spelling, grammar, and formatting; no functional change 2000-06-29 16:48:53 +00:00
Mark Andrews b74e73c5b4 294. [bug] If we run out of space in while processing glue
when reading a master file and commit "current name"
			reverts to "name_current" instead of staying as
			"name_glue".
2000-06-29 15:55:19 +00:00
David Lawrence 5eae30a019 in fact, ISC_LANG_BEGINDECLS and ISC_LANG_ENDDECLS are not needed at all since
rdatastructpre.h and rdatastructsuf.h already provide the wrapper.
(no need to pull up.)
2000-06-28 19:07:19 +00:00
David Lawrence 778d24f5ba do not include isc/lang.h; rdatastructpre.h already gets it.
no need to pull these changes up to the 9.0.0 branch.
2000-06-28 19:03:24 +00:00
Michael Graff 0cd1ba32c1 put edns0 restarts back to 3, and fix up a few trace messages to be standard ones -- lower case first letter. 2000-06-28 16:30:29 +00:00
Andreas Gustafsson c4bf0b3906 don't issue warnings saying max-ncache-ttl and max-cache-ttl are
not yet implemented, because they are
2000-06-27 21:33:20 +00:00
Andreas Gustafsson 95e7cd1ecb commented 2000-06-26 22:09:49 +00:00
Michael Graff 7618ec31e3 bump restarts to 4. After 3, we change the retry times. This lets the query take longer, but it is more likely to succeed with EDNS0 if the server or the network is just slow, not broken. 2000-06-26 21:46:25 +00:00
Michael Graff 57ebb859ee After N restarts (currently 3) try again with EDNS0 disabled. 2000-06-26 21:07:36 +00:00
James Brister 406ce0cd96 281. [bug] fixed list of recognised config file category names. 2000-06-23 22:30:02 +00:00
Michael Sawyer 167f530b5b Only test rendering class for != NONE/ANY in non-update messages 2000-06-23 20:47:23 +00:00
Mark Andrews b74e3d974b comment update 2000-06-23 17:30:59 +00:00
Mark Andrews b03a619e1d set AA in notify messages 2000-06-23 17:26:38 +00:00
David Lawrence 33f236e3a1 protect sys/types.h and unistd.h from check-includes.pl removal recommendation 2000-06-23 03:10:02 +00:00
David Lawrence 7657358689 does not need isc/types.h 2000-06-23 03:00:30 +00:00
David Lawrence 0980761026 does not need mutex.h 2000-06-23 03:00:01 +00:00
David Lawrence aea59f157b does not need eventclass.h 2000-06-23 02:59:28 +00:00
David Lawrence 5c54d949cf style lint 2000-06-23 02:59:05 +00:00
Brian Wellington 22057930cd TSIG AXFR verify leaked memory when talking to a BIND 8 server. 2000-06-23 02:07:58 +00:00
Brian Wellington 0378429c74 Add some log messages 2000-06-23 01:51:35 +00:00
Brian Wellington d4edcfe5eb Add tsig and tkey log moduleS 2000-06-23 01:51:18 +00:00
Brian Wellington 809fdfba22 TSIG AXFR verify failed when talking to a BIND 8 server. 2000-06-23 00:48:28 +00:00
David Lawrence 03d33d6f87 wrap long line 2000-06-23 00:29:20 +00:00
Brian Wellington e0d98fa781 TKEY failure could leak memory. 2000-06-22 23:07:00 +00:00