Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const. Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.
The macro DE_CONST is used to deal with a handful of very special
places where something is qualified as const but really needs to have
its const qualifier removed.
rdata.c now defines macros for the prototypes of the basic rdata functions,
and all of the lib/dns/rdata/**/*.c files now use them.
Some minor integer-compatibility issues. (IE, ~0x03 is a signed int,
so assigning it to an unsigned int should use a cast. The type of an
enum member is int, so there are some conversion issues there, too.)
A pointers-to-function should not be cast to a pointer-to-object.
Variables should not be named for C reserved identifiers.
One or two set-but-not-used variables removed.
Minor other ISC style cleanups.
there are no major fixes in here but couple of bug fixes that
may affect operation in some cases. I updated rename.h to
make sure all symbols with T have dst__openssl prefix.
Any bugs found in this source code should be reported to the
openssl people.
Olafur
and int variable. in three of the four cases this cast is questionable,
as suitable range had not been checked, but the situation is no worse
than without the casts.
"bsafe_link.c", line 116: remark(1692): prototyped function redeclared without
prototype
dst_s_bsafersa_init() {
and several variations of:
"bsafe_link.c", line 155: remark(1552): variable "status" was set but never
used
int status = 0;
along with style lint (notably bitwise operands used as truth values:
mode & DST_SIGMODE_INIT versus (mode & DST_SIGMODE_INIT) != 0.
it overwrote old keys if new key key-id conflicted
It was generating non null-keys with id==0
It was not able to generate DSA null keys.
I changed size of maximum RSA key to 2048.
cc: "mem.c", line 173: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 180: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 188: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 194: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 205: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 212: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 222: warning 714: Function "realloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 228: warning 714: Function "realloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 236: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 242: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 258: warning 714: Function "set_debug_options_func" called with no prototype or definition in scope.
cc: "mem.c", line 264: warning 714: Function "get_debug_options_func" called with no prototype or definition in scope.
cc: "stack.c", line 231: warning 714: Function called with no prototype or definition in scope.
cc: "stack.c", line 275: warning 714: Function "func" called with no prototype or definition in scope.
cc: "lhash.c", line 294: warning 714: Function "func" called with no prototype or definition in scope.
cc: "lhash.c", line 401: warning 714: Function called with no prototype or definition in scope.
cc: "lhash.c", line 422: warning 714: Function called with no prototype or definition in scope.
cc: "algchoic.h", line 74: warning 617: Redeclaration of tag "B_AlgorithmInfoType" ignored.
cc: "algchoic.h", line 74: warning 617: Redeclaration of tag "B_AlgorithmInfoType" ignored.
by removing:
struct B_AlgorithmInfoType;
because balgmeth.h already defines that struct tag.
(So does balg.h, but that isn't causing warnings.)
Cleanup of redundant/useless header file inclusion.
ISC style lint, primarily for function declarations and standalone
comments -- ie, those that appear on a line without any code, which
should be written as follows:
/*
* This is a comment.
*/
Added:
isc_buffer_base(b) (pointer)
isc_buffer_current(b) (pointer)
isc_buffer_active(b) (pointer)
isc_buffer_used(b) (pointer)
isc_buffer_length(b) (int)
isc_buffer_usedlength(b) (int)
isc_buffer_consumedlength(b) (int)
isc_buffer_remaininglength(b) (int)
isc_buffer_activelength(b) (int)
isc_buffer_availablelength(b) (int)
Removed:
ISC_BUFFER_USEDCOUNT(b)
ISC_BUFFER_AVAILABLECOUNT(b)
isc_buffer_type(b)
Changed names:
isc_buffer_used(b, r) ->
isc_buffer_usedregion(b, r)
isc_buffer_available(b, r) ->
isc_buffer_available_region(b, r)
isc_buffer_consumed(b, r) ->
isc_buffer_consumedregion(b, r)
isc_buffer_active(b, r) ->
isc_buffer_activeregion(b, r)
isc_buffer_remaining(b, r) ->
isc_buffer_remainingregion(b, r)
Buffer types were removed, so the ISC_BUFFERTYPE_*
macros are no more, and the type argument to
isc_buffer_init and isc_buffer_allocate were removed.
isc_buffer_putstr is now void (instead of isc_result_t)
and requires that the caller ensure that there
is enough available buffer space for the string.
Brian Wellington
Michael Graff