Commit Graph
6723 Commits
Author SHA1 Message Date
Mark Andrews 3c3d824db7 initalize sigsize to zero; ATF_CHECK_EQ(sigsize, tsig.siglen);
(cherry picked from commit 9f61f6b46b)
2017-12-22 08:59:03 +11:00
Mark Andrews 0c38c73c4c don't attempt to call isc_buffer_free(&buf) twice; don't attempt to call dns_message_destroy(&msg) twice; don't test for key != NULL
(cherry picked from commit cb8650d875)
2017-12-12 13:24:59 +11:00
Mark Andrews 2d82ed9456 4842. [bug] Conditionally compile opensslecdsa_link.c to avoid
warnings about unused function. [RT #46790]

(cherry picked from commit 63459cdc05)
2017-12-07 13:31:57 +11:00
Mark Andrews a5a1cbece4 4841. [bug] Address -fsanitize=undefined warnings. [RT #46786]
(cherry picked from commit 9d5a0abe81)
2017-12-06 21:02:24 +11:00
Mukund Sivaraman 16f43564c6 Backport performance work to 9.11 (#45637) 2017-12-06 10:35:21 +05:30
Mark Andrews e01ef6f01c 4839. [bug] zone.c:zone_sign was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46774]

(cherry picked from commit 00f5ea91cf)
2017-12-05 16:11:53 +11:00
Mark Andrews 677f507de7 4838. [bug] zone.c:add_sigs was not properly determining
if there were active KSK and ZSK keys for
                        a algorithm when update-check-ksk is true
                        (default) leaving records unsigned with one or
                        more DNSKEY algorithms. [RT #46754]

(cherry picked from commit 6fa2a0691e)
2017-12-05 09:32:50 +11:00
Mark Andrews bf459d24a1 4837. [bug] dns_update_signatures{inc} (add_sigs) was not
properly determining if there were active KSK and
                        ZSK keys for a algorithm when update-check-ksk is
                        true (default) leaving records unsigned. [RT #46743]

(cherry picked from commit 196e01da5f)
2017-12-04 10:04:58 +11:00
Evan Hunt 4a5dfa2d51 [v9_11] silence compiler warning
(cherry picked from commit 49a8cd6c01)
2017-11-30 13:55:49 -08:00
Ondřej Surý c62d9ac65f [v9_11] Type the shifted values to isc_uint32_t so the top bit is unsigned (found by UBSAN) [RT #46740]
(cherry picked from commit a4a148cf9a)
2017-11-30 18:27:07 +01:00
Michał Kępień 81e3e30849 [v9_11] Fix LMDB support on OpenBSD; clean up and refactor LMDB-related code
4835.   [cleanup]       Clean up and refactor LMDB-related code. [RT #46718]

4834.   [port]          Fix LMDB support on OpenBSD. [RT #46718]

(cherry picked from commit 2c20fc0d13)
2017-11-30 14:34:43 +01:00
Tinderbox User 341ab4071f update copyright notice / whitespace 2017-11-29 23:46:06 +00:00
Mark Andrews 64d7fa3ec4 4833. [bug] isc_event_free should check that the event is not
linked when called. [RT #46725]

4832.   [bug]           Events were not being removed from zone->rss_events.
                        [RT #46725]

(cherry picked from commit 9ddf7d6c4c)
2017-11-30 10:38:46 +11:00
Mark Andrews 75505befa9 4831. [bug] Convert the RRSIG expirytime to 64 bits for
comparisions in diff.c:resign. [RT #46710]

(cherry picked from commit 0579a11658)
2017-11-29 15:20:49 +11:00
Mark Andrews 0adaa6be4b #define update_recordsandbytes update_recordsandbytes64 2017-11-28 14:14:04 +11:00
Mark Andrews f98a58d9e6 map more entry points to <name>64 2017-11-28 14:13:17 +11:00
Tinderbox User 4c713bf940 update copyright notice / whitespace 2017-11-27 23:47:09 +00:00
Mark Andrews eb59c7d35b restore setting header->heap_index to zero in setsigningtime
(cherry picked from commit c22b540e4c)
2017-11-28 06:47:06 +11:00
Michał Kępień 1f4a3c7088 [v9_11] Do not use thread-local storage for storing LMDB reader locktable slots
4828.	[bug]		Do not use thread-local storage for storing LMDB reader
			locktable slots. [RT #46556]

(cherry picked from commit 40a90fbf89)
2017-11-27 09:48:49 +01:00
Mark Andrews 89085bebd3 More:
4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fails. [RT #46473]

(cherry picked from commit 19f6a63184)
2017-11-27 15:22:20 +11:00
Mark Andrews cae9332121 add missing symbols 2017-11-27 14:04:47 +11:00
Mark Andrews 295a6bb5df silence %lu vs size_t warning by casting to (unsigned long)
(cherry picked from commit 1dc8208a89)
2017-11-24 10:26:35 +11:00
Mark Andrews 55abc014f7 in rdbdb.c:setsigningtime stop breaking heap invariant property unless we are going to restore the invariant property
(cherry picked from commit 6ead410268)
2017-11-24 08:51:01 +11:00
Michał Kępień 57b1d64d9a [v9_11] Prevent bogus warning from being logged
4825.	[bug]		Prevent a bogus "error during managed-keys processing
			(no more)" warning from being logged. [RT #46645]

(cherry picked from commit 165df18f75)
2017-11-23 09:37:08 +01:00
Michał Kępień 2d517e233f [v9_11] Refactor reclimit system test
4823.	[test]		Refactor reclimit system test to improve its
			reliability and speed. [RT #46632]

(cherry picked from commit 6035d557c4)
2017-11-21 10:33:08 +01:00
Tinderbox User 7d4205bea9 update copyright notice / whitespace 2017-11-17 23:46:02 +00:00
Mark Andrews 13bd0e3159 remove out of date comment
(cherry picked from commit a197094d76)
2017-11-18 08:51:57 +11:00
Mark Andrews 86d2f9abc8 4821. [bug] When resigning ensure that the SOA's expire time is
always later that the resigning time of other records.
                        [RT #46473]

4820.   [bug]           dns_db_subtractrdataset should transfer the resigning
                        information to the new header. [RT #46473]

4819.   [bug]           Fully backout the transaction when adding a RRset
                        to the resigning / removal heaps fail. [RT #46473]

(cherry picked from commit 656eed7c9b)
2017-11-18 07:21:28 +11:00
Tinderbox User 67a1122d50 update copyright notice / whitespace 2017-11-14 23:46:28 +00:00
Mark Andrews 953b3882cc whitespace
(cherry picked from commit bcce55197a)
2017-11-14 14:49:07 +11:00
Mark Andrews ce37f22724 more DNS_NAME_INITABSOLUTE cases
(cherry picked from commit e2f9dcfd86)
2017-11-14 11:52:45 +11:00
Tinderbox User 9b68b948f6 update copyright notice / whitespace 2017-11-13 23:46:08 +00:00
Mark Andrews 3ed16e796d 4817. [cleanup] Use DNS_NAME_INITABSOLUTE and DNS_NAME_INITNONABSOLUTE.
[RT #45433]

(cherry picked from commit 3d905e0533)
2017-11-13 17:16:31 +11:00
Mark Andrews 70e041bea1 4815. [bug] rbt_test.c:insert_and_delete needed to call
dns_rbt_addnode instead of dns_rbt_addname. [RT #46553]

(cherry picked from commit 04934b28ea)
2017-11-13 15:27:12 +11:00
Michał Kępień eeb919b6f5 [v9_11] Minor improvements to code handling managed keys
4812.	[bug]		Minor improvements to stability and consistency of code
			handling managed keys. [RT #46468]

(cherry picked from commit 312c84c73a)
2017-11-09 15:19:32 +01:00
Michał Kępień 79d54c20ad [v9_11] Prevent junk from being logged when using "also-notify { <ip> key <keyname>; };"
(cherry picked from commit 4034b098d8)
2017-11-08 09:22:01 +01:00
Michał Kępień 4b669b69ba [v9_11] Backport fix for RT #46055 and mkeys system test improvements
4803.   [bug]		Backport parts of RT #45293 and RT #46267, specifically
			the fix for RT #46055 and mkeys system test
			improvements. [RT #46430]
2017-10-31 06:06:07 +01:00
Mark Andrews 3e4480ae34 tmp should be a (struct in_addr) not (struct in_addr *)
(cherry picked from commit 6e02359034)
2017-10-31 10:35:52 +11:00
Tinderbox User fb177937be update copyright notice / whitespace 2017-10-28 23:46:15 +00:00
Michał Kępień 8daeae9b01 [v9_11] Improve clarity of keytable unit tests
4799.	[cleanup]	Improve clarity of keytable unit tests. [RT #46407]

(cherry picked from commit c6c1193e39)
2017-10-28 20:03:07 +02:00
Mark Andrews c5e68335a1 address resource leak [RT #46413]
(cherry picked from commit c341e524dc)
2017-10-27 10:01:38 +11:00
Evan Hunt e7c0f97842 [v9_11] check file and tree headers when loading map files
4792.	[bug]		Fix map file header correctness check. [RT #38418]

(cherry picked from commit 5b69d3da83)
2017-10-25 21:37:21 -07:00
Evan Hunt 6acd7b903b [v9_11] clean up DNS_MESSAGETEXTFLAG comments
(cherry picked from commit 89d1777560)
2017-10-25 21:34:09 -07:00
Tinderbox User 66ebd200f5 update copyright notice / whitespace 2017-10-25 23:50:03 +00:00
Evan Hunt 7c442d7fe0 [v9_11] log when update-policy local gets a key match from a remote host
4788.	[cleanup]	When using "update-policy local", log a warning
			when an update matching the session key is received
			from a remote host. [RT #46213]

- this completes change #4762.
2017-10-25 00:59:17 -07:00
Michał Kępień 5e1ca7a326 [v9_11] Rename nsec3param_salt_totext() to dns_nsec3param_salttotext(), make it public, add unit tests
4786.	[cleanup]	Turn nsec3param_salt_totext() into a public function,
			dns_nsec3param_salttotext(), and add unit tests for it.
			[RT #46289]

(cherry picked from commit 910a01550a)
2017-10-25 09:50:33 +02:00
Michał Kępień 17441aca3d [v9_11] Remove REQUIRE preventing change 4592 from working
Change 4592 was supposed to replace a REQUIRE with a conditional return.
While the latter was added, the former was not removed.  Remove the
relevant REQUIRE to fix RT #43822 for good.

(cherry picked from commit a94d68ce43)
2017-10-24 21:14:22 +02:00
Evan Hunt e5715e1fe1 [v9_11] update B.ROOT-SERVERS.NET 2017-10-24 09:17:21 -07:00
Mark Andrews 764e2f3413 4779. [bug] Expire NTA at the start of the second. Don't update
the expiry value if the record has already expired
                        after a successful check. [RT #46368]

(cherry picked from commit c9438ee2e0)
2017-10-24 09:55:33 +11:00
Tinderbox User ff2d95be3d update copyright notice / whitespace 2017-10-19 23:46:54 +00:00