Commit Graph
4745 Commits
Author SHA1 Message Date
Andreas Gustafsson 9a3ee1570d "hard" errors in accept() were handled really badly. They were logged
twice, and the socket object for the new socket was never destroyed,
causing the server to hang on exit (if multithreaded) or dump core on exit
(if singlethreaded).  Now the only difference between "hard" and "soft" errors
is that the latter are not logged.
2001-02-06 23:43:01 +00:00
Andreas Gustafsson 8dab78b566 as a workaround for various OS bugs, do not INSIST() that
accept() returns a valid peer address; instead just log an ugly error message
and continue if the peer address is left unchanged or insane by accept()
[RT #809]
2001-02-06 23:04:02 +00:00
Brian Wellington f96ad6baf5 Only check to make sure that the full number of bytes were sent if the
send operation succeeded.  I'm still not convinced that send_done() works
correctly, but making other changes that look correct causes assertion failures.
2001-02-06 22:54:27 +00:00
Brian Wellington 2305225a1c The interface name field was only partially initialized. 2001-02-06 01:20:46 +00:00
Brian Wellington 770d3b36da ctx->checkfree was only being initialized if USE_INTERNAL_MALLOC was on. 2001-02-05 23:48:25 +00:00
Brian Wellington 0ef3f4fb41 When memsetting the entropy pool to 0, the count should be the size in bytes,
not words.
2001-02-05 23:00:18 +00:00
Brian Wellington 7aac083523 The flags field of the request structures were not initialized (thanks, purify) 2001-02-05 20:48:42 +00:00
Brian Wellington c716477d2e don't free the structure twice (thanks, Andreas) 2001-02-05 20:29:56 +00:00
Brian Wellington 15bc0af6a1 chain_name() built the fully qualified name in a very inefficient way.
Reversing the order of the concatenations makes it significantly faster.
2001-02-05 20:07:20 +00:00
Brian Wellington 5e8ff069e2 clean up the code to determine if dns_rdata_freestruct() needs to be called 2001-02-05 19:50:42 +00:00
Brian Wellington b7cd261f2f dns_name_concatenate(foo, NULL, bar, NULL) -> dns_name_copy(foo, bar, NULL) 2001-02-05 19:47:05 +00:00
Brian Wellington f91dc72b42 725. [bug] Installing man pages could fail. 2001-02-04 15:52:44 +00:00
Andreas Gustafsson 6b2f58f5c1 removed inappropriate 'Any bitstring labels are in canonical form' comments 2001-02-02 22:08:27 +00:00
Andreas Gustafsson 7e361074bc 724. [func] New libisc functions isc_netaddr_any(),
isc_netaddr_any6().
2001-02-02 02:48:47 +00:00
Bob Halley d6b3d06db7 Referrals whose NS RRs had a 0 TTL caused the resolver to return
DNS_R_SERVFAIL.  [RT #783]
2001-02-02 00:10:26 +00:00
Mark Andrews 8e68489885 722. [func] Allow n/named/server.cincrememtal loads to be canceled.
721.   [cleanup]       Load manager and dns_master_loadfilequota() are no
                        more.
2001-02-01 21:29:41 +00:00
Andreas Gustafsson 6983bb151a #else -> #else NOMINUM_PUBLIC 2001-02-01 21:27:10 +00:00
Andreas Gustafsson fc16063c23 removed dns_qid_t::mctx since it was never used 2001-01-31 22:16:37 +00:00
Brian Wellington d378ec4758 The return value of lwres_net_pton was checked for != 0 in a few places,
not == 1.
2001-01-31 22:06:33 +00:00
Andreas Gustafsson 2571d4a73d make sanitation work when building into a separate build directory
directly from a CVS tree [RT #765]; also removed code for removing "#line" directives and the
comment saying that the code for removing #line directives should be removed. :-)
2001-01-31 21:34:38 +00:00
Andreas Gustafsson c17c59662f 720. [bug] Server could enter infinite loop in
dispatch.c:do_cancel(). [RT #743]
2001-01-31 17:21:11 +00:00
Mark Andrews ec4f7c6d0f 719. [bug] Rapid reloads could trigger an assertion failure.
[RT #743]
2001-01-31 05:22:55 +00:00
Andreas Gustafsson 8d5ec7195a new dns_master_load() option DNS_MASTER_NOINCLUDE 2001-01-30 23:12:27 +00:00
Andreas Gustafsson 651421a5db removed the "additional-data" option, since it was never
fully implemented and because it causes "internal" to be a reserved word in
named.conf, causing problems for those using "internal" as an ACL name.
Since additional-data was never documented, the user-visible aspect of the
change is:

 718.   [cleanup]       "internal" is no longer a reserved word in named.conf.
                        [RT #753, #731]
2001-01-30 22:02:31 +00:00
Bob Halley 7427490a67 Certain TKEY processing failure modes could
reference an uninitialized variable, causing the
server to crash. [RT #750]
2001-01-30 19:18:19 +00:00
Mark Andrews aac319b506 716. [bug] The first line of a $INCLUDE master file was lost if
a origin was specified. [RT #744]
 Adjust comment.
2001-01-30 13:23:32 +00:00
Andreas Gustafsson dfa0badebe 715. [bug] Resolving some A6 chains could cause an assertion
failure in adb.c. [RT #738]
2001-01-30 05:56:58 +00:00
Brian Wellington 63ca494e7e Added the isc_refcount_t type, which is a generic locked reference counter,
and make the rbtdb, zone, and view objects use it.
This should reduce contention on other locks, since (in the normal)
implementation, the reference count has its own lock.  In the future, it
should also be possible to implement an isc_refcount_t with atomic operations
instead of mutexes, which should also help performance.
2001-01-30 02:50:51 +00:00
Mark Andrews fd50497bbe isc_dir_chroot() 2001-01-29 03:17:45 +00:00
Brian Wellington 6f9786fdcf Consolidate duplicated code in isc_socket_sendto[v] and isc_socket_recv[v]. 2001-01-27 06:41:36 +00:00
Brian Wellington b3936096b8 fix get_key_struct() definition 2001-01-27 04:33:18 +00:00
Andreas Gustafsson 9e992ecf37 further cleanup of ADB dumps 2001-01-27 02:44:35 +00:00
Brian Wellington 3a66efb0cb remove the completely unused timer->mctx field. 2001-01-27 02:44:07 +00:00
Brian Wellington 94baac869a 712. [bug] Sending a large signed update message caused an
assertion failure. [RT #718]

- Resetting a message should clear the TSIG/SIG(0) sections
- Rerendering a message if the first try returned USETCP should not call
  dns_message_settsigkey() again.
2001-01-27 02:28:33 +00:00
Andreas Gustafsson fd73b3a68d fixed incorrect error message 2001-01-27 02:12:13 +00:00
Andreas Gustafsson a618f8d5b7 suppress compiler warnings 2001-01-27 02:11:35 +00:00
Brian Wellington 35f06ab0e6 Clients now listen on sockets instead of accepting queries from dispatchers.
When a socket is shared by clients and query-source, the client hands off
responses to the dispatcher.
2001-01-27 02:08:07 +00:00
Brian Wellington 562f162981 remove unused labels 2001-01-27 01:16:09 +00:00
Brian Wellington dd66e6306b Remove isc_socket/[send|recv]mark, which were never used. 2001-01-26 23:17:26 +00:00
Brian Wellington 7b5172166d Waking up once a second to clean one bucket is excessive. Change the
default values (and dependencies) so that the clenup routine is called once
ever 30 seconds and cleans 8-9 buckets.
2001-01-26 03:20:58 +00:00
Damien Neil dfb0717d75 - Receive and send operations on UDP sockets no longer need to acquire
the socket lock.  (Assuming the operation succeeds immediately, and doesn't
need to be queued.)

- Communications with the watcher thread tweaked to reduce the need for
locking.
2001-01-25 22:25:10 +00:00
Brian Wellington 9f7b524522 The forwarders statements in zones & views didn't work. 2001-01-25 21:10:18 +00:00
Brian Wellington 330705066b Wrap inet_ntop() and use that in the _totext() functions. The wrapper calls
inet_ntop() and copies the output (but not the trailing null) into the buffer.
2001-01-25 20:14:42 +00:00
Andreas Gustafsson b586eb4408 revert half of 711. - there was no off by one error in the v6 case,
only in the v4 case
2001-01-25 20:10:02 +00:00
Brian Wellington 1ac2c28488 711. [bug] The libisc and liblwres implementations of
inet_ntop contained an off by one error.
2001-01-25 19:39:48 +00:00
Andreas Gustafsson bc85580ff8 mask message id to 16 bits explicitly 2001-01-25 13:52:32 +00:00
Andreas Gustafsson 3530e10080 commented and removed dead code 2001-01-25 13:47:59 +00:00
Brian Wellington a12d9cfa59 710. [func] The forwarders statement now takes an optional port.
Also some assorted cleanup, which resulted in a lot of duplicated code removal.
2001-01-25 02:33:53 +00:00
Mark Andrews 1a2b3fbeb1 don't attempt to refresh while loading. 2001-01-25 02:30:21 +00:00
Damien Neil 3c31899857 Fix warning in the overrun detection code. 2001-01-25 01:38:01 +00:00