public functions did not have an isc__ prefix, and
referred to functions that had previously been
renamed.
184. [cleanup] Variables/functions which began with two leading
underscores were made to conform to the ANSI/ISO
function declaration and comment reformatting in accordance with coding
style document.
check_overrun conditionally compiled based on ISC_MEM_FILL and
ISC_MEM_CHECKOVERRUN to avoid compiler warnings about being defined
but not used if one of those two CPP symbols is not defined.
statements.
- Post-load of named.conf check verifies a slave zone has non-empty list
of masters defined.
- New per-zone boolean:
enable-zone yes | no ;
- intended to let a zone be disabled without having to comment out the
entire zone statement.
- New global and per-view option:
max-cache-ttl number
- New global and per-view option:
addition-data internal | minimal | maximal;
line 356: remark(1174): parameter "dev" was declared but never referenced
This is true when ISC_NET_BSD44MSGHDR is not defined. UNUSED()s were added.
line 1580: remark(1552): variable "task" was set but never used
line 1670: remark(1552): variable "task" was set but never used
I removed the stack variable and its assignment in each case.
line 2915: remark(1552): variable "ret" was set but never used
It was apparent that the variable was meant to be the return value
of isc_socket_getsockname, so the return statement was changed to use it.
Also ...
Changed function declarations to ISC coding style.
Wrapped two lines that were wider than column 79.
Removed two UNUSED() macros for variables that were no longer unused.
line 383: remark(1498): no prototype for the call to setup
line 405: remark(1498): no prototype for the call to cleanup
The missing prototypes were added.
line 684: remark(1692): prototyped function redeclared without prototype
line 700: remark(1692): prototyped function redeclared without prototype
Prototypes fixed.
line 331: remark(1552): variable "n" was set but never used.
Variable removed.
It was removed and the function call that set it (getword) was cast to void.
In the context in which it was being used, the return value was not needed.
line 84: remark(1692): prototyped function redeclared without prototype
line 137: remark(1692): prototyped function redeclared without prototype
The missing prototypes were added.
to "long": rounding, sign extension, or loss of accuracy may result
Fixed by ensuring unsigned long ctx->timeout does not overflow the signed
long timeout.tv_sec.
Michael Sawyer
Mark Andrews