Commit Graph
463 Commits
Author SHA1 Message Date
Mark Andrews 79dc8a0013 test devent->sigrdataset rather than devent->rdataset before calling query_putrdataset
(cherry picked from commit e08a31e317)
2018-01-05 12:41:51 +11:00
Tinderbox User f3e5a44f00 update copyright notice / whitespace 2018-01-04 23:47:43 +00:00
Mark Andrews 385d0b66e0 4857. [bug] Maintain attach/detach semantics for event->db,
event->node, event->rdataset and event->sigrdataset
                        in query.c. [RT #46891]

(cherry picked from commit cad79077bd)
2018-01-04 13:20:34 +11:00
Evan Hunt 3dbc4979c6 [v9_9] fix merge error; missing hunk from change 4780
(cherry picked from commit 4d39bffd95)
2017-10-24 10:10:04 -07:00
Evan Hunt 0a5b0a447e [v9_9] omit NS from authority section if it was in answer
4780.	[bug]		When answering ANY queries, don't include the NS
			RRset in the authority section if it was already
			in the answer section. [RT #44543]

(cherry picked from commit b7b76d6b85)
(cherry picked from commit 13435af49a)
2017-10-23 19:38:29 -07:00
Mark Andrews 80dd4971d9 4739. [cleanup] Address clang static analysis warnings. [RT #45952]
(cherry picked from commit f9f3f20d2d)
2017-09-27 13:19:37 +10:00
Evan Hunt d2516c6507 [v9_9] turn on minimal responses for CDS/CDNSKEY
4678.	[cleanup]	Turn on minimal responses for CDNSKEY and CDS in
			addition to DNSKEY and DS. Thanks to Tony Finch.
			[RT #45690]

(cherry picked from commit 391a3a2f20)
2017-08-25 13:32:39 -07:00
Mark Andrews 282980e448 4640. [bug] If query_findversion failed in query_getdb due to
memory failure the error status was incorrectly
                        discarded. [RT #45331]

(cherry picked from commit b551ee14bd)
(cherry picked from commit 18bb24bc37)
2017-06-23 17:19:15 +10:00
Evan Hunt 10f80ef83a [v9_9] fix rpz formerr loop
4531.	[security]	Some RPZ configurations could go into an infinite
			query loop when encountering responses with TTL=0.
			(CVE-2017-3140) [RT #45181]

(cherry picked from commit 3440cf9c60)
(cherry picked from commit a57b289ed0)
2017-05-30 12:43:57 -07:00
Evan Hunt 7334fbc55c [v9_9] Add DLZ db version to activeversions
4628.	[bug]		Fixed a potential reference leak in query_getdb().
			[RT #45247]

(cherry picked from commit 594eadcc34)
2017-05-28 14:34:14 -07:00
Mark Andrews 673dd20a78 remove unused assignments [RT #45147]
(cherry picked from commit 78551a3f2c)
2017-05-03 07:46:34 +10:00
Mukund Sivaraman e315a20bd4 Validate glue before adding it to the additional section (#45062)
(cherry picked from commit b0dbcba2d2)
(cherry picked from commit fec9247b8f)
(cherry picked from commit b958488b2e)
2017-04-21 16:03:28 +05:30
Mark Andrews 35ca802c7b 4575. [security] Dns64 with break-dnssec yes; can result in a
assertion failure. (CVE-2017-3136) [RT #44653]

(cherry picked from commit 3bce12e4b6)
2017-02-15 12:24:33 +11:00
Mark Andrews eaa394fcfa address rpz version issue 2017-01-24 11:21:55 +11:00
Mark Andrews 4b843e0cc8 4556. [security] Combining dns64 and rpz can result in dereferencing
a NULL pointer (read).  (CVE-2017-3135) [RT#44434]

(cherry picked from commit 5abe80ef13)
2017-01-24 09:56:20 +11:00
Tinderbox User 3d51a06d9d update copyright notice / whitespace 2017-01-19 23:47:43 +00:00
Mark Andrews 3f4d134e72 use TCP macro
(cherry picked from commit 2fa1676380)
2017-01-19 13:14:11 +11:00
Mark Andrews 3a125854c9 4472. [bug] Named could fail to find the correct NSEC3 records when
a zone was update between looking for the answer and
                        looking for the NSEC3 records proving non-existance
                        of the answer. [RT #43247]
2016-10-05 10:41:05 +11:00
Mark Andrews 0ba8ac54c7 also cleanup node 2016-06-03 18:35:07 +10:00
Mark Andrews e4ae68f50c detach before restore 2016-06-03 18:34:59 +10:00
Mark Andrews 944b398582 reset zversion on restart
(cherry picked from commit b4750b5991)
2016-06-03 14:33:52 +10:00
Mark Andrews cb735b3f90 fix merge error 2016-05-27 18:39:33 +10:00
Mark Andrews dfdf6773a6 REDIRECT macro is 9.11.0+ 2016-05-27 10:06:42 +10:00
Mark Andrews c3fbf330bc 4377. [bug] Don't reuse zero TTL responses beyond the current
client set (excludes ANY/SIG/RRSIG queries).
                        [RT #42142]

(cherry picked from commit aabcb1fde0)
2016-05-27 10:05:52 +10:00
Tinderbox User addd839e4a update copyright notice / whitespace 2016-05-26 23:46:02 +00:00
Mark Andrews 900a63cb04 4374. [bug] Use SAVE/RESTORE macros in query.c to reduce the
probability of reference counting errors as seen
                        in 4365. [RT #42405]

(cherry picked from commit ac11084829)
2016-05-26 13:37:43 +10:00
Mukund Sivaraman 65f562e5e4 Code cleanups (#41656)
(cherry picked from commit 9da98335c1)
(cherry picked from commit b15dde2889)
2016-03-04 13:00:43 +05:30
Mark Andrews 87c8fae1dc add missing line break
(cherry picked from commit 68ecf1c9a5)
2016-02-04 11:52:24 +11:00
Mark Andrews 04e34494ea 4313. [bug] Handle ns_client_replace failures in test mode.
[RT #41190]

(cherry picked from commit d88ba93712)
2016-02-03 15:04:06 +11:00
Evan Hunt 70280057b4 [v9_9] expanded query trace logging
4300.	[cleanup]	Added new querytrace logging. [RT #41155]
2016-01-22 14:33:50 -08:00
Tinderbox User 7b7d845166 update copyright notice / whitespace 2016-01-21 23:46:08 +00:00
Evan Hunt 4b8c357439 [v9_9] hold 2016-01-20 17:32:39 -08:00
Mark Andrews b1fd8ee3ad 4281. [bug] Teach dns_message_totext about BADCOOKIE. [RT #41257]
(cherry picked from commit f647c0df9f)

Conflicts:
	CHANGES
	bin/named/query.c
	bin/tests/system/sit/tests.sh
	lib/dns/message.c

(cherry picked from commit d090709551)

Conflicts:
	CHANGES
2015-12-15 20:10:37 +11:00
Mark Andrews 3b8f8695af 4227. [bug] Silence static analysis warnings. [RT #40828
(cherry picked from commit 2a12984ce6)
2015-09-30 14:35:42 +10:00
Mark Andrews 17747a8059 make macro name match category name
(cherry picked from commit 4d085258cc)
2015-09-29 15:05:53 +10:00
Mark Andrews 1c33552240 4081. [cleanup] Use dns_rdatalist_init consistently. [RT #38759]
(cherry picked from commit 29d52c001f)
(cherry picked from commit a55c3151b2)
2015-03-03 16:52:02 +11:00
Mukund Sivaraman e62afa3177 Add a --enable-querytrace configure switch for very verbose query tracelogging (#37520)
(cherry picked from commit 1783676a64)
(cherry picked from commit b83c20df65)

Conflicts:
	CHANGES
	config.h.in
	configure
	configure.in
2015-02-26 17:04:18 +05:30
Evan Hunt ec856a0ed6 [v9_9] add better servfail logging
3937.	[func]		Added some debug logging to better indicate the
			conditions causing SERVFAILs when resolving.
			[RT #35538]

(cherry picked from commit f5c24a7f48)
(cherry picked from commit 09a87d841f)
2015-02-25 16:05:45 -08:00
Evan Hunt adf9e1c676 [v9_9] silence RPZ log messages
4050.	[cleanup]	Silence occasional spurious "duplicate query" log
			messages from RPZ. [RT #38510]
2015-02-10 15:03:05 -08:00
Mukund Sivaraman 015371d584 Fix a leak of query fetchlock (#38454)
4052.	[bug]		Fix a leak of query fetchlock. [RT #38454]

Conflicts:
	CHANGES
2015-02-03 11:54:16 +05:30
Tinderbox User 9cbd625449 update copyright notice / whitespace 2015-01-20 23:47:26 +00:00
Evan Hunt 57f015bd2a [v9_9] clean up gcc -Wshadow warnings
4039.	[cleanup]	Cleaned up warnings from gcc -Wshadow. [RT #37381]
2015-01-20 14:55:41 -08:00
Evan Hunt 1d47cb124d [v9_9] refactor max-recursion-queries
- the counters weren't set correctly when fetches timed out.
  instead we now pass down a counter object.

(cherry picked from commit 05e448935c)
(cherry picked from commit 6c049c57d9)
2014-11-19 18:38:52 -08:00
Evan Hunt 603a0e2637 [v9_9] limit recursion depth and iterative queries
4006.	[security]	A flaw in delegation handling could be exploited
			to put named into an infinite loop.  This has
			been addressed by placing limits on the number
			of levels of recursion named will allow (default 7),
			and the number of iterative queries that it will
			send (default 50) before terminating a recursive
			query (CVE-2014-8500).

			The recursion depth limit is configured via the
			"max-recursion-depth" option.  [RT #35780]
2014-11-17 23:49:07 -08:00
Evan Hunt b2630b7363 [v9_9] fix nxrrset in nxdomain redirection
4000.	[bug]		NXDOMAIN redirection incorrectly handled NXRRSET
			from the redirect zone. [RT #37722]

(cherry picked from commit 3cc8c7d630)
(cherry picked from commit 56293cd148)
2014-11-04 23:54:25 -08:00
Mark Andrews fb7f157cd8 3921. [bug] AD was inappopriately set on RPZ responses. [RT #36833]
(cherry picked from commit cef76ee5bd)
(cherry picked from commit 0597c5fd5e)
2014-08-22 15:46:54 +10:00
Tinderbox User 3a1808bb0c update copyright notice 2014-07-31 23:46:06 +00:00
Mark Andrews 570effe386 3904. [func] Add the RPZ SOA to the additional section. [RT36507]
(cherry picked from commit 3a55d43527)
2014-07-31 10:53:33 +10:00
Mark Andrews c1c8bd9171 More changes for:
3864.   [bug]           RPZ didn't work well when being used as forwarder.
                        [RT #36060]
2014-05-30 08:53:42 +10:00
Mark Andrews e10c6afa15 3864. [bug] RPZ didn't work well when being used as forwarder.
[RT #36060]
2014-05-29 17:35:14 +10:00